root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-16373: KIP-1028: Modfiying download url for kafka dockerfile (#16281) 

This PR modifies the download url from https://downloads.apache.org/kafka/ to https://archive.apache.org/dist/kafka/ as the former is not permanent.

Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>, Vedarth Sharma <vesharma@confluent.io>
This commit is contained in:
KrishVora01 2024-06-11 21:02:33 +05:30 committed by GitHub
parent f746d67c3b
commit b7dcae44ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docker/docker_official_image_build_test.py
View File

@ -76,7 +76,7 @@ if __name__ == '__main__':
parser.add_argument("--test", "-t", action="store_true", dest="test_only", parser.add_argument("--test", "-t", action="store_true", dest="test_only",
default=False, help="Only run the tests, don't build the image") default=False, help="Only run the tests, don't build the image")
args = parser.parse_args() args = parser.parse_args()
kafka_url = f"https://downloads.apache.org/kafka/{args.kafka_version}/kafka_2.13-{args.kafka_version}.tgz" kafka_url = f"https://archive.apache.org/dist/kafka/{args.kafka_version}/kafka_2.13-{args.kafka_version}.tgz"
if args.build_only or not (args.build_only or args.test_only): if args.build_only or not (args.build_only or args.test_only):
if args.kafka_version: if args.kafka_version:
build_docker_official_image(args.image, args.tag, args.kafka_version, args.image_type) build_docker_official_image(args.image, args.tag, args.kafka_version, args.image_type)

10
docker/docker_official_images/3.7.0/jvm/Dockerfile
View File

@ -20,8 +20,8 @@ FROM eclipse-temurin:21-jre-alpine AS build-jsa
USER root USER root
# Get Kafka from https://downloads.apache.org/kafka, url passed as env var, for version 3.7.0 # Get Kafka from https://archive.apache.org/dist/kafka, url passed as env var, for version 3.7.0
ENV kafka_url https://downloads.apache.org/kafka/3.7.0/kafka_2.13-3.7.0.tgz ENV kafka_url https://archive.apache.org/dist/kafka/3.7.0/kafka_2.13-3.7.0.tgz
COPY jsa_launch /etc/kafka/docker/jsa_launch COPY jsa_launch /etc/kafka/docker/jsa_launch
@ -48,9 +48,9 @@ EXPOSE 9092
USER root USER root
# Get Kafka from https://downloads.apache.org/kafka, url passed as env var, for version 3.7.0 # Get Kafka from https://archive.apache.org/dist/kafka, url passed as env var, for version 3.7.0
ENV kafka_url https://downloads.apache.org/kafka/3.7.0/kafka_2.13-3.7.0.tgz ENV kafka_url https://archive.apache.org/dist/kafka/3.7.0/kafka_2.13-3.7.0.tgz
ENV build_date 2024-06-10 ENV build_date 2024-06-11
LABEL org.label-schema.name="kafka" \ LABEL org.label-schema.name="kafka" \

4
docker/prepare_docker_official_image_source.py
View File

@ -46,7 +46,7 @@ def remove_args_and_hardcode_values(file_path, kafka_version, kafka_url):
filedata = filedata.replace( filedata = filedata.replace(
"ARG build_date", f"ENV build_date {str(date.today())}") "ARG build_date", f"ENV build_date {str(date.today())}")
original_comment = re.compile(r"# Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments") original_comment = re.compile(r"# Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments")
updated_comment = f"# Get Kafka from https://downloads.apache.org/kafka, url passed as env var, for version {kafka_version}" updated_comment = f"# Get Kafka from https://archive.apache.org/dist/kafka, url passed as env var, for version {kafka_version}"
filedata = original_comment.sub(updated_comment, filedata) filedata = original_comment.sub(updated_comment, filedata)
with open(file_path, 'w') as file: with open(file_path, 'w') as file:
file.write(filedata) file.write(filedata)
@ -59,7 +59,7 @@ if __name__ == '__main__':
parser.add_argument("--kafka-version", "-v", dest="kafka_version", parser.add_argument("--kafka-version", "-v", dest="kafka_version",
help="Kafka version for which the source for docker official image is to be built") help="Kafka version for which the source for docker official image is to be built")
args = parser.parse_args() args = parser.parse_args()
kafka_url = f"https://downloads.apache.org/kafka/{args.kafka_version}/kafka_2.13-{args.kafka_version}.tgz" kafka_url = f"https://archive.apache.org/dist/kafka/{args.kafka_version}/kafka_2.13-{args.kafka_version}.tgz"
current_dir = os.path.dirname(os.path.realpath(__file__)) current_dir = os.path.dirname(os.path.realpath(__file__))
new_dir = os.path.join( new_dir = os.path.join(
current_dir, f'docker_official_images', args.kafka_version) current_dir, f'docker_official_images', args.kafka_version)