root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Add logging for ReplicationControlManager topic deletion (#17617) 

Reviewers: Colin P. McCabe <cmccabe@apache.org>
This commit is contained in:
Mahsa Seifikar 2024-11-01 15:24:22 -04:00 committed by GitHub
parent 568b9e8a6c
commit b864a66439
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 27 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
View File

@ -939,17 +939,39 @@ public class ReplicationControlManager {
Map<Uuid, ApiError> results = new HashMap<>(ids.size()); Map<Uuid, ApiError> results = new HashMap<>(ids.size());
List<ApiMessageAndVersion> records = List<ApiMessageAndVersion> records =
BoundedList.newArrayBacked(MAX_RECORDS_PER_USER_OP, ids.size()); BoundedList.newArrayBacked(MAX_RECORDS_PER_USER_OP, ids.size());
StringBuilder resultsBuilder = new StringBuilder();
String resultsPrefix = "";
for (Uuid id : ids) { for (Uuid id : ids) {
String topicName = "null";
ApiError error;
try { try {
log.trace("Starting deletion of topic with ID {}.", id);
deleteTopic(context, id, records); deleteTopic(context, id, records);
results.put(id, ApiError.NONE); error = ApiError.NONE;
} catch (ApiException e) { } catch (ApiException e) {
results.put(id, ApiError.fromThrowable(e)); error = ApiError.fromThrowable(e);
} catch (Exception e) { } catch (Exception e) {
log.error("Unexpected deleteTopics error for {}", id, e); log.error("Unexpected deleteTopics error for {}", id, e);
results.put(id, ApiError.fromThrowable(e)); error = ApiError.fromThrowable(e);
} }
results.put(id, error);
if (!error.isFailure() || error.error() != UNKNOWN_TOPIC_ID) {
topicName = topics.get(id).name;
} }
resultsBuilder.append(resultsPrefix)
.append("{id: ").append(id)
.append(", name: ").append(topicName)
.append(", result: ")
.append(error.isFailure() ? error.error() : "SUCCESS")
.append("}");
resultsPrefix = ", ";
}
log.info("DeleteTopics result(s): {}", resultsBuilder);
return ControllerResult.atomicOf(records, results); return ControllerResult.atomicOf(records, results);
} }
@ -959,8 +981,10 @@ public class ReplicationControlManager {
throw new UnknownTopicIdException(UNKNOWN_TOPIC_ID.message()); throw new UnknownTopicIdException(UNKNOWN_TOPIC_ID.message());
} }
int numPartitions = topic.parts.size(); int numPartitions = topic.parts.size();
log.trace("Deleting topic {} with ID {} and {} partitions", topic.name, id, numPartitions);
try { try {
context.applyPartitionChangeQuota(numPartitions); // check controller mutation quota context.applyPartitionChangeQuota(numPartitions); // check controller mutation quota
log.trace("Checked for a partition change quota on topic {} with ID {}", topic.name, id);
} catch (ThrottlingQuotaExceededException e) { } catch (ThrottlingQuotaExceededException e) {
// log a message and rethrow the exception // log a message and rethrow the exception
log.debug("Topic deletion of {} partitions not allowed because quota is violated. Delay time: {}", log.debug("Topic deletion of {} partitions not allowed because quota is violated. Delay time: {}",