root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: replace .stream().forEach() with .forEach() (#19626)
CI / build (push) Waiting to run Details 

replace all applicable `.stream().forEach()` in codebase with just
`.forEach()`.

Reviewers: TengYao Chi <kitingiao@gmail.com>, Ken Huang
<s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
This commit is contained in:
yunchi 2025-05-04 05:39:55 -07:00 committed by GitHub
parent c85e09f7a5
commit bff5ba4ad9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clients/src/main/java/org/apache/kafka/clients/Metadata.java
View File

@ -381,7 +381,7 @@ public class Metadata implements Closeable {
public synchronized Set<TopicPartition> updatePartitionLeadership(Map<TopicPartition, LeaderIdAndEpoch> partitionLeaders, List<Node> leaderNodes) {
Map<Integer, Node> newNodes = leaderNodes.stream().collect(Collectors.toMap(Node::id, node -> node));
// Insert non-overlapping nodes from existing-nodes into new-nodes.
this.metadataSnapshot.cluster().nodes().stream().forEach(node -> newNodes.putIfAbsent(node.id(), node));
this.metadataSnapshot.cluster().nodes().forEach(node -> newNodes.putIfAbsent(node.id(), node));
// Create partition-metadata for all updated partitions. Exclude updates for partitions -
// 1. for which the corresponding partition has newer leader in existing metadata.

2
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
View File

@ -69,7 +69,7 @@ public class DescribeUserScramCredentialsResult {
retval.completeExceptionally(Errors.forCode(optionalFirstFailedDescribe.get().errorCode()).exception(optionalFirstFailedDescribe.get().errorMessage()));
} else {
Map<String, UserScramCredentialsDescription> retvalMap = new HashMap<>();
data.results().stream().forEach(userResult ->
data.results().forEach(userResult ->
retvalMap.put(userResult.user(), new UserScramCredentialsDescription(userResult.user(),
getScramCredentialInfosFor(userResult))));
retval.complete(retvalMap);

4
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
View File

@ -4487,8 +4487,8 @@ public class KafkaAdminClient extends AdminClient {
* Be sure to do this after the NOT_CONTROLLER error check above
* so that all errors are consistent in that case.
*/
userIllegalAlterationExceptions.entrySet().stream().forEach(entry ->
futures.get(entry.getKey()).completeExceptionally(entry.getValue())
userIllegalAlterationExceptions.forEach((key, value) ->
futures.get(key).completeExceptionally(value)
);
response.data().results().forEach(result -> {
KafkaFutureImpl<Void> future = futures.get(result.user());

2
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java
View File

@ -2413,7 +2413,7 @@ public class SenderTest {
// Create a two broker cluster, with partition 0 on broker 0 and partition 1 on broker 1
MetadataResponse metadataUpdate1 = RequestTestUtils.metadataUpdateWithIds(2, Collections.singletonMap(topic, 2), TOPIC_IDS);
client.prepareMetadataUpdate(metadataUpdate1);
metadataUpdate1.brokers().stream().forEach(node ->
metadataUpdate1.brokers().forEach(node ->
apiVersions.update(node.idString(), NodeApiVersions.create(ApiKeys.PRODUCE.id, ApiKeys.PRODUCE.oldestVersion(), ApiKeys.PRODUCE.latestVersion()))
);

2
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/clients/admin/FakeLocalMetadataStore.java
View File

@ -66,7 +66,7 @@ public class FakeLocalMetadataStore {
*/
public static void updateTopicConfig(String topic, Config newConfig) {
ConcurrentHashMap<String, String> topicConfigs = FakeLocalMetadataStore.ALL_TOPICS.getOrDefault(topic, new ConcurrentHashMap<>());
newConfig.entries().stream().forEach(configEntry -> {
newConfig.entries().forEach(configEntry -> {
if (configEntry.name() != null) {
if (configEntry.value() != null) {
log.debug("Topic '{}' update config '{}' to '{}'", topic, configEntry.name(), configEntry.value());

6
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerIntegrationTestUtils.java
View File

@ -88,10 +88,10 @@ public class QuorumControllerIntegrationTestUtils {
.setName(MetadataVersion.FEATURE_NAME)
.setMinSupportedVersion(minVersion.featureLevel())
.setMaxSupportedVersion(maxVersion.featureLevel()));
featureMaxVersions.entrySet().forEach(entry -> {
featureMaxVersions.forEach((key, value) -> {
features.add(new BrokerRegistrationRequestData.Feature()
.setName(entry.getKey())
.setMaxSupportedVersion(entry.getValue())
.setName(key)
.setMaxSupportedVersion(value)
.setMinSupportedVersion((short) 0));
});
return features;

2
server/src/main/java/org/apache/kafka/server/AssignmentsManager.java
View File

@ -368,7 +368,7 @@ public final class AssignmentsManager {
previousGlobalFailures++;
log.error("handleResponse: {} assignments failed; global error: {}. Retrying.",
sent.size(), globalResponseError.get());
sent.entrySet().forEach(e -> ready.putIfAbsent(e.getKey(), e.getValue()));
sent.forEach(ready::putIfAbsent);
return;
}
previousGlobalFailures = 0;

4
tools/src/main/java/org/apache/kafka/tools/ClusterTool.java
View File

@ -167,7 +167,7 @@ public class ClusterTool {
if (listControllerEndpoints) {
String format = "%-10s %-" + maxHostLength + "s %-10s %-" + maxRackLength + "s %-15s%n";
stream.printf(format, "ID", "HOST", "PORT", "RACK", "ENDPOINT_TYPE");
nodes.stream().forEach(node -> stream.printf(format,
nodes.forEach(node -> stream.printf(format,
node.idString(),
node.host(),
node.port(),
@ -177,7 +177,7 @@ public class ClusterTool {
} else {
String format = "%-10s %-" + maxHostLength + "s %-10s %-" + maxRackLength + "s %-10s %-15s%n";
stream.printf(format, "ID", "HOST", "PORT", "RACK", "STATE", "ENDPOINT_TYPE");
nodes.stream().forEach(node -> stream.printf(format,
nodes.forEach(node -> stream.printf(format,
node.idString(),
node.host(),
node.port(),