root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 4 Packages Projects Releases Wiki Activity

MINOR: Remove version check when setting reason for `Join/LeaveGroupRequest` in `RequestResponseTest` (#11680) 

This patch ensures that the `Reason` field can be set for all versions (ignorable field).

Reviewers: David Jacot <djacot@confluent.io>
This commit is contained in:
Jeff Kim 2022-01-17 01:20:53 -08:00 committed by GitHub
parent 30c9087d74
commit c45cf35d30
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
View File

@ -1715,7 +1715,8 @@ public class RequestResponseTest {
.setSessionTimeoutMs(30000)
.setMemberId("consumer1")
.setProtocolType("consumer")
.setProtocols(protocols);
.setProtocols(protocols)
.setReason("reason: test");
// v1 and above contains rebalance timeout
if (version >= 1)
@ -1725,10 +1726,6 @@ public class RequestResponseTest {
if (version >= 5)
data.setGroupInstanceId("groupInstanceId");
// v8 and above can set reason
if (version >= 8)
data.setReason("reason: test");
return new JoinGroupRequest.Builder(data).build(version);
}
@ -1841,10 +1838,7 @@ public class RequestResponseTest {
}
private LeaveGroupRequest createLeaveGroupRequest(short version) {
MemberIdentity member = new MemberIdentity().setMemberId("consumer1");
if (version >= 5) {
member.setReason("reason: test");
}
MemberIdentity member = new MemberIdentity().setMemberId("consumer1").setReason("reason: test");
return new LeaveGroupRequest.Builder("group1", Collections.singletonList(member))
.build(version);
}