From cee55dbdeca79cba5cbfca2f53a37344ebe2e38a Mon Sep 17 00:00:00 2001 From: Andrew Schofield Date: Tue, 1 Apr 2025 16:52:06 +0100 Subject: [PATCH] KAFKA-18794: Disable flaky tests pending investigation (#19340) KafkaShareConsumerTest is proving very flaky. The behaviour of MockClient does not appear to match the expectations of the test. This PR disables the flaky tests to reduce build noise. When a proper solution has been worked out, the tests can be re-enabled. Reviewers: Chia-Ping Tsai --- .../kafka/clients/consumer/KafkaShareConsumerTest.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaShareConsumerTest.java b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaShareConsumerTest.java index c7c05acf9b5..53105e7d306 100644 --- a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaShareConsumerTest.java +++ b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaShareConsumerTest.java @@ -45,11 +45,11 @@ import org.apache.kafka.common.requests.ShareGroupHeartbeatRequest; import org.apache.kafka.common.requests.ShareGroupHeartbeatResponse; import org.apache.kafka.common.serialization.Deserializer; import org.apache.kafka.common.serialization.StringDeserializer; -import org.apache.kafka.common.test.api.Flaky; import org.apache.kafka.common.utils.LogContext; import org.apache.kafka.common.utils.MockTime; import org.apache.kafka.common.utils.Time; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Timeout; @@ -140,7 +140,9 @@ public class KafkaShareConsumerTest { } } - @Flaky("KAFKA-18488") + // This test is proving sufficiently flaky that it has been disabled pending investigation + @Disabled + // @Flaky("KAFKA-18488") @Test public void testVerifyFetchAndCommitSyncImplicit() { ConsumerMetadata metadata = new ConsumerMetadata(0, 0, Long.MAX_VALUE, false, false, @@ -215,7 +217,9 @@ public class KafkaShareConsumerTest { } } - @Flaky("KAFKA-18794") + // This test is proving sufficiently flaky that it has been disabled pending investigation + @Disabled + //@Flaky("KAFKA-18794") @Test public void testVerifyFetchAndCloseImplicit() { ConsumerMetadata metadata = new ConsumerMetadata(0, 0, Long.MAX_VALUE, false, false,