root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-15873: Filter topics before sorting (#19304)
CI / build (push) Waiting to run Details 

Partially addresses KAFKA-15873. When filtering and sorting, we should
be applying the filter before the sort of topics. Order that
unauthorizedForDescribeTopicMetadata is added to not relevant as it is a
HashSet.

Reviewers: TaiJuWu <tjwu1217@gmail.com>, Calvin Liu
 <caliu@confluent.io>, Matthias J. Sax <matthias@confluent.io>
This commit is contained in:
lorcan 2025-09-29 17:02:32 +01:00 committed by GitHub
parent 1ebca7817b
commit d1a821226c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/main/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandler.java
View File

@ -89,7 +89,7 @@ public class DescribeTopicPartitionsRequestHandler {
// Do not disclose the existence of topics unauthorized for Describe, so we've not even checked if they exist or not // Do not disclose the existence of topics unauthorized for Describe, so we've not even checked if they exist or not
Set<DescribeTopicPartitionsResponseTopic> unauthorizedForDescribeTopicMetadata = new HashSet<>(); Set<DescribeTopicPartitionsResponseTopic> unauthorizedForDescribeTopicMetadata = new HashSet<>();
Stream<String> authorizedTopicsStream = topics.stream().sorted().filter(topicName -> { Stream<String> authorizedTopicsStream = topics.stream().filter(topicName -> {
boolean isAuthorized = authHelper.authorize( boolean isAuthorized = authHelper.authorize(
abstractRequest.context(), DESCRIBE, TOPIC, topicName, true, true, 1); abstractRequest.context(), DESCRIBE, TOPIC, topicName, true, true, 1);
if (!fetchAllTopics && !isAuthorized) { if (!fetchAllTopics && !isAuthorized) {
@ -99,7 +99,7 @@ public class DescribeTopicPartitionsRequestHandler {
); );
} }
return isAuthorized; return isAuthorized;
}); }).sorted();
DescribeTopicPartitionsResponseData response = metadataCache.describeTopicResponse( DescribeTopicPartitionsResponseData response = metadataCache.describeTopicResponse(
authorizedTopicsStream.iterator(), authorizedTopicsStream.iterator(),