From d2a699954d964d0b0e675fa29fadb697c68622f3 Mon Sep 17 00:00:00 2001 From: Sanskar Jhajharia Date: Sun, 28 Sep 2025 20:45:28 +0530 Subject: [PATCH] MINOR: Cleanup `toString` methods in Storage Module (#20432) Getting rid of a bunch of `toString` functions in record classes in Storage Module. Reviewers: Chia-Ping Tsai --- .../kafka/storage/internals/log/EpochEntry.java | 8 -------- .../kafka/storage/internals/log/LastRecord.java | 8 -------- .../storage/internals/log/LoadedLogOffsets.java | 9 --------- .../storage/internals/log/LogOffsetSnapshot.java | 10 ---------- .../kafka/storage/internals/log/LogReadInfo.java | 12 ------------ .../kafka/storage/internals/log/OffsetPosition.java | 8 -------- .../internals/log/RemoteStorageFetchInfo.java | 11 ----------- .../kafka/storage/internals/log/RollParams.java | 13 ------------- .../storage/internals/log/TimestampOffset.java | 7 ------- 9 files changed, 86 deletions(-) diff --git a/storage/src/main/java/org/apache/kafka/storage/internals/log/EpochEntry.java b/storage/src/main/java/org/apache/kafka/storage/internals/log/EpochEntry.java index a024919b665..f51c7c81939 100644 --- a/storage/src/main/java/org/apache/kafka/storage/internals/log/EpochEntry.java +++ b/storage/src/main/java/org/apache/kafka/storage/internals/log/EpochEntry.java @@ -18,12 +18,4 @@ package org.apache.kafka.storage.internals.log; // Mapping of epoch to the first offset of the subsequent epoch public record EpochEntry(int epoch, long startOffset) { - - @Override - public String toString() { - return "EpochEntry(" + - "epoch=" + epoch + - ", startOffset=" + startOffset + - ')'; - } } diff --git a/storage/src/main/java/org/apache/kafka/storage/internals/log/LastRecord.java b/storage/src/main/java/org/apache/kafka/storage/internals/log/LastRecord.java index e000c77864d..69e9cfe34ef 100644 --- a/storage/src/main/java/org/apache/kafka/storage/internals/log/LastRecord.java +++ b/storage/src/main/java/org/apache/kafka/storage/internals/log/LastRecord.java @@ -27,12 +27,4 @@ public record LastRecord(OptionalLong lastDataOffset, short producerEpoch) { public LastRecord { Objects.requireNonNull(lastDataOffset, "lastDataOffset must be non null"); } - - @Override - public String toString() { - return "LastRecord(" + - "lastDataOffset=" + lastDataOffset + - ", producerEpoch=" + producerEpoch + - ')'; - } } diff --git a/storage/src/main/java/org/apache/kafka/storage/internals/log/LoadedLogOffsets.java b/storage/src/main/java/org/apache/kafka/storage/internals/log/LoadedLogOffsets.java index 30bcf312588..aec4c88fe51 100644 --- a/storage/src/main/java/org/apache/kafka/storage/internals/log/LoadedLogOffsets.java +++ b/storage/src/main/java/org/apache/kafka/storage/internals/log/LoadedLogOffsets.java @@ -26,13 +26,4 @@ public record LoadedLogOffsets(long logStartOffset, long recoveryPoint, LogOffse this.recoveryPoint = recoveryPoint; this.nextOffsetMetadata = Objects.requireNonNull(nextOffsetMetadata, "nextOffsetMetadata should not be null"); } - - @Override - public String toString() { - return "LoadedLogOffsets(" + - "logStartOffset=" + logStartOffset + - ", recoveryPoint=" + recoveryPoint + - ", nextOffsetMetadata=" + nextOffsetMetadata + - ')'; - } } diff --git a/storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetSnapshot.java b/storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetSnapshot.java index b96f68ba8dd..ecadf16f4ae 100644 --- a/storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetSnapshot.java +++ b/storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetSnapshot.java @@ -23,14 +23,4 @@ package org.apache.kafka.storage.internals.log; */ public record LogOffsetSnapshot(long logStartOffset, LogOffsetMetadata logEndOffset, LogOffsetMetadata highWatermark, LogOffsetMetadata lastStableOffset) { - - @Override - public String toString() { - return "LogOffsetSnapshot(" + - "logStartOffset=" + logStartOffset + - ", logEndOffset=" + logEndOffset + - ", highWatermark=" + highWatermark + - ", lastStableOffset=" + lastStableOffset + - ')'; - } } diff --git a/storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java b/storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java index d50f00ddba1..6a603e5aa76 100644 --- a/storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java +++ b/storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java @@ -25,16 +25,4 @@ import java.util.Optional; */ public record LogReadInfo(FetchDataInfo fetchedData, Optional divergingEpoch, long highWatermark, long logStartOffset, long logEndOffset, long lastStableOffset) { - - @Override - public String toString() { - return "LogReadInfo(" + - "fetchedData=" + fetchedData + - ", divergingEpoch=" + divergingEpoch + - ", highWatermark=" + highWatermark + - ", logStartOffset=" + logStartOffset + - ", logEndOffset=" + logEndOffset + - ", lastStableOffset=" + lastStableOffset + - ')'; - } } diff --git a/storage/src/main/java/org/apache/kafka/storage/internals/log/OffsetPosition.java b/storage/src/main/java/org/apache/kafka/storage/internals/log/OffsetPosition.java index 31ca0183276..ab32a1212e0 100644 --- a/storage/src/main/java/org/apache/kafka/storage/internals/log/OffsetPosition.java +++ b/storage/src/main/java/org/apache/kafka/storage/internals/log/OffsetPosition.java @@ -32,12 +32,4 @@ public record OffsetPosition(long offset, int position) implements IndexEntry { public long indexValue() { return position; } - - @Override - public String toString() { - return "OffsetPosition(" + - "offset=" + offset + - ", position=" + position + - ')'; - } } diff --git a/storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageFetchInfo.java b/storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageFetchInfo.java index 3e70f8c7120..da37c98d892 100644 --- a/storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageFetchInfo.java +++ b/storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageFetchInfo.java @@ -22,15 +22,4 @@ import org.apache.kafka.server.storage.log.FetchIsolation; public record RemoteStorageFetchInfo(int fetchMaxBytes, boolean minOneMessage, TopicIdPartition topicIdPartition, FetchRequest.PartitionData fetchInfo, FetchIsolation fetchIsolation) { - - @Override - public String toString() { - return "RemoteStorageFetchInfo{" + - "fetchMaxBytes=" + fetchMaxBytes + - ", minOneMessage=" + minOneMessage + - ", topicIdPartition=" + topicIdPartition + - ", fetchInfo=" + fetchInfo + - ", fetchIsolation=" + fetchIsolation + - '}'; - } } diff --git a/storage/src/main/java/org/apache/kafka/storage/internals/log/RollParams.java b/storage/src/main/java/org/apache/kafka/storage/internals/log/RollParams.java index cbb934a725c..ca5874b61b9 100644 --- a/storage/src/main/java/org/apache/kafka/storage/internals/log/RollParams.java +++ b/storage/src/main/java/org/apache/kafka/storage/internals/log/RollParams.java @@ -21,17 +21,4 @@ package org.apache.kafka.storage.internals.log; */ public record RollParams(long maxSegmentMs, int maxSegmentBytes, long maxTimestampInMessages, long maxOffsetInMessages, int messagesSize, long now) { - - @Override - public String toString() { - return "RollParams(" + - "maxSegmentMs=" + maxSegmentMs + - ", maxSegmentBytes=" + maxSegmentBytes + - ", maxTimestampInMessages=" + maxTimestampInMessages + - ", maxOffsetInMessages=" + maxOffsetInMessages + - ", messagesSize=" + messagesSize + - ", now=" + now + - ')'; - } - } diff --git a/storage/src/main/java/org/apache/kafka/storage/internals/log/TimestampOffset.java b/storage/src/main/java/org/apache/kafka/storage/internals/log/TimestampOffset.java index fecf458ed46..a09a1910868 100644 --- a/storage/src/main/java/org/apache/kafka/storage/internals/log/TimestampOffset.java +++ b/storage/src/main/java/org/apache/kafka/storage/internals/log/TimestampOffset.java @@ -36,11 +36,4 @@ public record TimestampOffset(long timestamp, long offset) implements IndexEntry public long indexValue() { return offset; } - - @Override - public String toString() { - return String.format("TimestampOffset(offset = %d, timestamp = %d)", - offset, - timestamp); - } }