root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-18675 Add tests for valid and invalid broker addresses (#18781) 

Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
This commit is contained in:
Ming-Yen Chung 2025-02-05 17:01:51 +08:00 committed by GitHub
parent a1d5dc0f9e
commit d830179375
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java
View File

@ -19,6 +19,8 @@ package org.apache.kafka.clients;
import org.apache.kafka.common.config.ConfigException;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
import org.mockito.MockedConstruction;
import org.mockito.MockedStatic;
@ -27,8 +29,10 @@ import java.net.InetSocketAddress;
import java.net.UnknownHostException;
import java.util.Collections;
import java.util.List;
import java.util.stream.Stream;
import static java.util.Arrays.asList;
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertThrows;
@ -95,6 +99,28 @@ public class ClientUtilsTest {
}
}
@Test
public void testValidBrokerAddress() {
List<String> validBrokerAddress = List.of("localhost:9997", "localhost:9998", "localhost:9999");
assertDoesNotThrow(() -> ClientUtils.parseAndValidateAddresses(validBrokerAddress, ClientDnsLookup.USE_ALL_DNS_IPS));
}
static Stream<List<String>> provideInvalidBrokerAddressTestCases() {
return Stream.of(
List.of("localhost:9997\nlocalhost:9998\nlocalhost:9999"),
List.of("localhost:9997", "localhost:9998", " localhost:9999"),
// Intentionally provide a single string, as users may provide space-separated brokers, which will be parsed as a single string.
List.of("localhost:9997 localhost:9998 localhost:9999")
);
}
@ParameterizedTest
@MethodSource("provideInvalidBrokerAddressTestCases")
public void testInvalidBrokerAddress(List<String> addresses) {
assertThrows(ConfigException.class,
() -> ClientUtils.parseAndValidateAddresses(addresses, ClientDnsLookup.USE_ALL_DNS_IPS));
}
@Test
public void testInvalidConfig() {
assertThrows(IllegalArgumentException.class,