From d83a734c41c43a03aa571e602cf8535f0893fd79 Mon Sep 17 00:00:00 2001 From: Manyanda Chitimbo Date: Tue, 25 Apr 2023 12:02:24 +0200 Subject: [PATCH] MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server (#13626) The sslEngine.setUseClientMode(false) was duplicated when ssl mode is server during SSLEngine creation in DefaultSslEngineFactory.java. The patch attemps to remove the duplicated call. Reviewers: maulin-vasavada , Divij Vaidya , Manikumar Reddy --- .../kafka/common/security/ssl/DefaultSslEngineFactory.java | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java b/clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java index ac16c21bfc8..0175139fea3 100644 --- a/clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java +++ b/clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java @@ -200,7 +200,6 @@ public final class DefaultSslEngineFactory implements SslEngineFactory { case NONE: break; } - sslEngine.setUseClientMode(false); } else { sslEngine.setUseClientMode(true); SSLParameters sslParams = sslEngine.getSSLParameters();