root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: pass in timeout to Admin.close() (#16422) 

Reviewers: Luke Chen <showuon@gmail.com>, Kamal Chandraprakash <kamal.chandraprakash@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>, Apoorv Mittal <amittal@confluent.io>, Bruno Cadonna <bruno@confluent.io>
This commit is contained in:
Matthias J. Sax 2024-06-27 12:14:05 -07:00 committed by GitHub
parent 3ebad6349d
commit dc7c9ad068
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
View File

@ -1514,7 +1514,13 @@ public class KafkaStreams implements AutoCloseable {
}
stateDirectory.close();
adminClient.close();
// passing in `timeoutMs` here is a quick fix to avoid blocking forever
// cf https://issues.apache.org/jira/browse/KAFKA-7996
if (timeoutMs >= 0) {
adminClient.close(Duration.ofMillis(timeoutMs));
} else {
adminClient.close();
}
streamsMetrics.removeAllClientLevelSensorsAndMetrics();
metrics.close();