From e14d5b01cbe63c74af63e117347cfa80d55015f5 Mon Sep 17 00:00:00 2001 From: Lucas Brutschy Date: Tue, 7 Oct 2025 16:10:59 +0200 Subject: [PATCH] comments --- .../kafka/coordinator/group/streams/StreamsGroup.java | 2 +- .../kafka/coordinator/group/GroupMetadataManagerTest.java | 4 ++-- .../group/streams/StreamsCoordinatorRecordHelpersTest.java | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java index aa19e76f219..6cf5fe64f41 100644 --- a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java +++ b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java @@ -150,7 +150,7 @@ public class StreamsGroup implements Group { /** * The topology epoch for which the subscribed topics identified by metadataHash are validated. */ - protected final TimelineInteger validatedTopologyEpoch; + private final TimelineInteger validatedTopologyEpoch; /** * The metadata hash which is computed based on the all subscribed topics. diff --git a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java index 9533791e0df..39756f1c4fe 100644 --- a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java +++ b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java @@ -9752,7 +9752,7 @@ public class GroupMetadataManagerTest { context.replay(StreamsCoordinatorRecordHelpers.newStreamsGroupMemberRecord(streamsGroupId, memberBuilder2.build())); context.replay(StreamsCoordinatorRecordHelpers.newStreamsGroupTargetAssignmentRecord(streamsGroupId, memberId2, assignment)); context.replay(StreamsCoordinatorRecordHelpers.newStreamsGroupCurrentAssignmentRecord(streamsGroupId, memberBuilder2.build())); - context.replay(StreamsCoordinatorRecordHelpers.newStreamsGroupMetadataRecord(streamsGroupId, epoch + 2, 0, -1)); + context.replay(StreamsCoordinatorRecordHelpers.newStreamsGroupMetadataRecord(streamsGroupId, epoch + 2, 0, 0)); List actual = context.groupMetadataManager.streamsGroupDescribe(List.of(streamsGroupId), context.lastCommittedOffset); StreamsGroupDescribeResponseData.DescribedGroup describedGroup = new StreamsGroupDescribeResponseData.DescribedGroup() @@ -9783,7 +9783,7 @@ public class GroupMetadataManagerTest { ) ) ) - .setGroupState(StreamsGroup.StreamsGroupState.NOT_READY.toString()) + .setGroupState(StreamsGroup.StreamsGroupState.ASSIGNING.toString()) .setGroupEpoch(epoch + 2); assertEquals(1, actual.size()); assertEquals(describedGroup, actual.get(0)); diff --git a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsCoordinatorRecordHelpersTest.java b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsCoordinatorRecordHelpersTest.java index a93a276ef26..457bd55c602 100644 --- a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsCoordinatorRecordHelpersTest.java +++ b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsCoordinatorRecordHelpersTest.java @@ -257,13 +257,13 @@ class StreamsCoordinatorRecordHelpersTest { new ApiMessageAndVersion( new StreamsGroupMetadataValue() .setEpoch(42) - .setMetadataHash(42) - .setValidatedTopologyEpoch(43), + .setMetadataHash(43) + .setValidatedTopologyEpoch(44), (short) 0 ) ); - assertEquals(expectedRecord, StreamsCoordinatorRecordHelpers.newStreamsGroupMetadataRecord(GROUP_ID, 42, 42, 43)); + assertEquals(expectedRecord, StreamsCoordinatorRecordHelpers.newStreamsGroupMetadataRecord(GROUP_ID, 42, 43, 44)); } @Test