root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Notify FetchBuffer from background thread if pausing due to application thread callbacks 

FetchBuffer is now provided to CompositePollEventProcessorContext and its supplier, allowing the context to call fetchBuffer.wakeup() after completing an event. The wakeup method in FetchBuffer is made public to support this usage.
This commit is contained in:
Kirk True 2025-10-01 13:08:19 -07:00
parent bc660d6462
commit e9dbc61bff
3 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java
View File

@ -467,7 +467,8 @@ public class AsyncKafkaConsumer<K, V> implements ConsumerDelegate<K, V> {
networkClientDelegateSupplier,
backgroundEventHandler,
offsetCommitCallbackInvoker,
applicationEventReaper
applicationEventReaper,
fetchBuffer
);
final Supplier<ApplicationEventProcessor> applicationEventProcessorSupplier = ApplicationEventProcessor.supplier(logContext,
metadata,
@ -686,7 +687,8 @@ public class AsyncKafkaConsumer<K, V> implements ConsumerDelegate<K, V> {
networkClientDelegateSupplier,
backgroundEventHandler,
offsetCommitCallbackInvoker,
applicationEventReaper
applicationEventReaper,
fetchBuffer
);
Supplier<ApplicationEventProcessor> applicationEventProcessorSupplier = ApplicationEventProcessor.supplier(
logContext,

2
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java
View File

@ -193,7 +193,7 @@ public class FetchBuffer implements AutoCloseable {
}
}
void wakeup() {
public void wakeup() {
try {
lock.lock();
wokenup.set(true);

13
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompositePollEventProcessorContext.java
View File

@ -20,6 +20,7 @@ import org.apache.kafka.clients.consumer.internals.CachedSupplier;
import org.apache.kafka.clients.consumer.internals.ClassicKafkaConsumer;
import org.apache.kafka.clients.consumer.internals.ConsumerNetworkThread;
import org.apache.kafka.clients.consumer.internals.ConsumerUtils;
import org.apache.kafka.clients.consumer.internals.FetchBuffer;
import org.apache.kafka.clients.consumer.internals.NetworkClientDelegate;
import org.apache.kafka.clients.consumer.internals.OffsetCommitCallbackInvoker;
import org.apache.kafka.common.KafkaException;
@ -44,17 +45,20 @@ public class CompositePollEventProcessorContext {
private final BackgroundEventHandler backgroundEventHandler;
private final OffsetCommitCallbackInvoker offsetCommitCallbackInvoker;
private final CompletableEventReaper applicationEventReaper;
private final FetchBuffer fetchBuffer;
private CompositePollEventProcessorContext(LogContext logContext,
NetworkClientDelegate networkClientDelegate,
BackgroundEventHandler backgroundEventHandler,
OffsetCommitCallbackInvoker offsetCommitCallbackInvoker,
CompletableEventReaper applicationEventReaper) {
CompletableEventReaper applicationEventReaper,
FetchBuffer fetchBuffer) {
this.log = logContext.logger(getClass());
this.networkClientDelegate = networkClientDelegate;
this.backgroundEventHandler = backgroundEventHandler;
this.offsetCommitCallbackInvoker = offsetCommitCallbackInvoker;
this.applicationEventReaper = applicationEventReaper;
this.fetchBuffer = fetchBuffer;
}
/**
@ -65,7 +69,8 @@ public class CompositePollEventProcessorContext {
Supplier<NetworkClientDelegate> networkClientDelegateSupplier,
BackgroundEventHandler backgroundEventHandler,
OffsetCommitCallbackInvoker offsetCommitCallbackInvoker,
CompletableEventReaper applicationEventReaper) {
CompletableEventReaper applicationEventReaper,
FetchBuffer fetchBuffer) {
return new CachedSupplier<>() {
@Override
protected CompositePollEventProcessorContext create() {
@ -76,7 +81,8 @@ public class CompositePollEventProcessorContext {
networkClientDelegate,
backgroundEventHandler,
offsetCommitCallbackInvoker,
applicationEventReaper
applicationEventReaper,
fetchBuffer
);
}
};
@ -125,6 +131,7 @@ public class CompositePollEventProcessorContext {
nextEventType
);
event.completeWithCallbackRequired(nextEventType);
fetchBuffer.wakeup();
return true;
}