diff --git a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java index 6df8e237933..ef638f011f7 100644 --- a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java +++ b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java @@ -17017,7 +17017,7 @@ public class GroupMetadataManagerTest { acls.put(fooTopicName, AuthorizationResult.ALLOWED); acls.put(barTopicName, AuthorizationResult.DENIED); when(authorizer.authorize(any(), any())).thenAnswer(invocation -> { - List actions = invocation.getArgument(1, List.class); + List actions = invocation.getArgument(1); return actions.stream() .map(action -> acls.getOrDefault(action.resourcePattern().name(), AuthorizationResult.DENIED)) .collect(Collectors.toList()); diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java index ab37fa6c9d3..2f6f29fdbda 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java @@ -68,6 +68,7 @@ import static java.util.Arrays.asList; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.is; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertInstanceOf; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertThrows; @@ -352,12 +353,10 @@ public class KTableImplTest { final String topic1 = "topic1"; final String topic2 = "topic2"; - final KTableImpl table1 = - (KTableImpl) builder.table(topic1, consumed); + final var table1 = builder.table(topic1, consumed); builder.table(topic2, consumed); - final KTableImpl table1Mapped = - (KTableImpl) table1.mapValues(s -> Integer.valueOf(s)); + final var table1Mapped = table1.mapValues(s -> Integer.valueOf(s)); table1Mapped.filter((key, value) -> (value % 2) == 0); try (final TopologyTestDriver driver = new TopologyTestDriver(builder.build(), props)) { @@ -371,15 +370,11 @@ public class KTableImplTest { final String topic1 = "topic1"; final String topic2 = "topic2"; - final KTableImpl table1 = - (KTableImpl) builder.table(topic1, consumed); - final KTableImpl table2 = - (KTableImpl) builder.table(topic2, consumed); + final var table1 = builder.table(topic1, consumed); + final var table2 = builder.table(topic2, consumed); - final KTableImpl table1Mapped = - (KTableImpl) table1.mapValues(s -> Integer.valueOf(s)); - final KTableImpl table1MappedFiltered = - (KTableImpl) table1Mapped.filter((key, value) -> (value % 2) == 0); + final var table1Mapped = table1.mapValues(s -> Integer.valueOf(s)); + final var table1MappedFiltered = table1Mapped.filter((key, value) -> (value % 2) == 0); table2.join(table1MappedFiltered, (v1, v2) -> v1 + v2); try (final TopologyTestDriver driver = new TopologyTestDriver(builder.build(), props)) { @@ -391,9 +386,7 @@ public class KTableImplTest { public void shouldNotEnableSendingOldValuesIfNotMaterializedAlreadyAndNotForcedToMaterialize() { final StreamsBuilder builder = new StreamsBuilder(); - final KTableImpl table = - (KTableImpl) builder.table("topic1", consumed); - + final var table = assertInstanceOf(KTableImpl.class, builder.table("topic1", consumed)); table.enableSendingOldValues(false); assertThat(table.sendingOldValueEnabled(), is(false)); @@ -403,9 +396,7 @@ public class KTableImplTest { public void shouldEnableSendingOldValuesIfNotMaterializedAlreadyButForcedToMaterialize() { final StreamsBuilder builder = new StreamsBuilder(); - final KTableImpl table = - (KTableImpl) builder.table("topic1", consumed); - + final var table = assertInstanceOf(KTableImpl.class, builder.table("topic1", consumed)); table.enableSendingOldValues(true); assertThat(table.sendingOldValueEnabled(), is(true)); @@ -429,8 +420,7 @@ public class KTableImplTest { final String topic1 = "topic1"; final String storeName1 = "storeName1"; - final KTableImpl table1 = - (KTableImpl) builder.table( + final var table1 = builder.table( topic1, consumed, Materialized.>as(storeName1) @@ -587,19 +577,14 @@ public class KTableImplTest { assertThrows(NullPointerException.class, () -> table.transformValues(null)); } - @SuppressWarnings("unchecked") @Test public void shouldThrowNullPointerOnTransformValuesWithKeyWhenMaterializedIsNull() { - final ValueTransformerWithKeySupplier valueTransformerSupplier = - mock(ValueTransformerWithKeySupplier.class); - assertThrows(NullPointerException.class, () -> table.transformValues(valueTransformerSupplier, (Materialized>) null)); + assertThrows(NullPointerException.class, () -> table.transformValues(mock(), (Materialized>) null)); } - @SuppressWarnings("unchecked") + @Test public void shouldThrowNullPointerOnTransformValuesWithKeyWhenStoreNamesNull() { - final ValueTransformerWithKeySupplier valueTransformerSupplier = - mock(ValueTransformerWithKeySupplier.class); - assertThrows(NullPointerException.class, () -> table.transformValues(valueTransformerSupplier, (String[]) null)); + assertThrows(NullPointerException.class, () -> table.transformValues(mock(), (String[]) null)); } } diff --git a/tools/src/test/java/org/apache/kafka/tools/ConfigCommandIntegrationTest.java b/tools/src/test/java/org/apache/kafka/tools/ConfigCommandIntegrationTest.java index 8cb15c148ed..2587a6c150f 100644 --- a/tools/src/test/java/org/apache/kafka/tools/ConfigCommandIntegrationTest.java +++ b/tools/src/test/java/org/apache/kafka/tools/ConfigCommandIntegrationTest.java @@ -69,6 +69,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyMap; public class ConfigCommandIntegrationTest { private final String defaultBrokerId = "0"; @@ -413,7 +414,7 @@ public class ConfigCommandIntegrationTest { AlterConfigsResult mockResult = AdminClientTestUtils.alterConfigsResult( new ConfigResource(ConfigResource.Type.BROKER, ""), new UnsupportedVersionException("simulated error")); Mockito.doReturn(mockResult).when(spyAdmin) - .incrementalAlterConfigs(any(java.util.Map.class), any(AlterConfigsOptions.class)); + .incrementalAlterConfigs(anyMap(), any(AlterConfigsOptions.class)); assertEquals( "The INCREMENTAL_ALTER_CONFIGS API is not supported by the cluster. The API is supported starting from version 2.3.0. You may want to use an older version of this tool to interact with your cluster, or upgrade your brokers to version 2.3.0 or newer to avoid this error.", assertThrows(UnsupportedVersionException.class, () -> { @@ -426,7 +427,7 @@ public class ConfigCommandIntegrationTest { "--entity-default")))); }).getMessage() ); - Mockito.verify(spyAdmin).incrementalAlterConfigs(any(java.util.Map.class), any(AlterConfigsOptions.class)); + Mockito.verify(spyAdmin).incrementalAlterConfigs(anyMap(), any(AlterConfigsOptions.class)); } }