root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-14887: FinalizedFeatureChangeListener should not shut down when ZK session expires 

FinalizedFeatureChangeListener shuts the broker down when it encounters an issue trying to process feature change
events. However, it does not distinguish between issues related to feature changes actually failing and other
exceptions like ZooKeeper session expiration. This introduces the possibility that Zookeeper session expiration
could cause the broker to shutdown, which is not intended. This patch updates the code to distinguish between
these two types of exceptions. In the case of something like a ZK session expiration it logs a warning and continues.
We shutdown the broker only for FeatureCacheUpdateException.

Reviewers: Kamal Chandraprakash <kamal.chandraprakash@gmail.com>, Christo Lolov <christololov@gmail.com>, Colin P. McCabe <cmccabe@apache.org>
This commit is contained in:
Ron Dagostino 2023-04-19 19:45:26 -04:00 committed by Ron Dagostino
parent 0189aa6288
commit f033a71ee5
No known key found for this signature in database
GPG Key ID: 8A97B0CD0BE3571B
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala
View File

@ -153,10 +153,12 @@ class FinalizedFeatureChangeListener(private val finalizedFeatureCache: Finalize
// safe to ignore the exception if the thread is being shutdown. We raise the exception // safe to ignore the exception if the thread is being shutdown. We raise the exception
// here again, because, it is ignored by ShutdownableThread if it is shutting down. // here again, because, it is ignored by ShutdownableThread if it is shutting down.
throw ie throw ie
case e: Exception => { case cacheUpdateException: FeatureCacheUpdateException =>
error("Failed to process feature ZK node change event. The broker will eventually exit.", e) error("Failed to process feature ZK node change event. The broker will eventually exit.", cacheUpdateException)
throw new FatalExitError(1) throw new FatalExitError(1)
} case e: Exception =>
// do not exit for exceptions unrelated to cache change processing (e.g. ZK session expiration)
warn("Unexpected exception in feature ZK node change event processing; will continue processing.", e)
} }
} }
} }