root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

KAFKA-19267 the min version used by ListOffsetsRequest should be 1 rather than 0 (#19709)
CI / build (push) Waiting to run Details 

Updates the min version used by `ListOffsetsRequest` to
`ApiKeys.LIST_OFFSETS.oldestVersion()` rather than hardcoding `1`.

Reviewers: Ken Huang <s7133700@gmail.com>, PoAn Yang
 <payang@apache.org>, TengYao Chi <frankvicky@apache.org>, Chia-Ping
 Tsai <chia7712@gmail.com>
This commit is contained in:
Yunchi Pang 2025-05-15 19:33:16 -07:00 committed by GitHub
parent bbf48ad677
commit f55565d321
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java
View File

@ -66,7 +66,7 @@ public class ListOffsetsRequest extends AbstractRequest {
boolean requireMaxTimestamp, boolean requireMaxTimestamp,
boolean requireEarliestLocalTimestamp, boolean requireEarliestLocalTimestamp,
boolean requireTieredStorageTimestamp) { boolean requireTieredStorageTimestamp) {
short minVersion = 0; short minVersion = ApiKeys.LIST_OFFSETS.oldestVersion();
if (requireTieredStorageTimestamp) if (requireTieredStorageTimestamp)
minVersion = 9; minVersion = 9;
else if (requireEarliestLocalTimestamp) else if (requireEarliestLocalTimestamp)
@ -81,7 +81,7 @@ public class ListOffsetsRequest extends AbstractRequest {
} }
public static Builder forReplica(short allowedVersion, int replicaId) { public static Builder forReplica(short allowedVersion, int replicaId) {
return new Builder((short) 0, allowedVersion, replicaId, IsolationLevel.READ_UNCOMMITTED); return new Builder(ApiKeys.LIST_OFFSETS.oldestVersion(), allowedVersion, replicaId, IsolationLevel.READ_UNCOMMITTED);
} }
private Builder(short oldestAllowedVersion, private Builder(short oldestAllowedVersion,

2
clients/src/test/java/org/apache/kafka/common/requests/ListOffsetsRequestTest.java
View File

@ -135,7 +135,7 @@ public class ListOffsetsRequestTest {
ListOffsetsRequest.Builder requireTieredStorageTimestampRequestBuilder = ListOffsetsRequest.Builder ListOffsetsRequest.Builder requireTieredStorageTimestampRequestBuilder = ListOffsetsRequest.Builder
.forConsumer(false, IsolationLevel.READ_UNCOMMITTED, false, false, true); .forConsumer(false, IsolationLevel.READ_UNCOMMITTED, false, false, true);
assertEquals((short) 0, consumerRequestBuilder.oldestAllowedVersion()); assertEquals((short) 1, consumerRequestBuilder.oldestAllowedVersion());
assertEquals((short) 1, requireTimestampRequestBuilder.oldestAllowedVersion()); assertEquals((short) 1, requireTimestampRequestBuilder.oldestAllowedVersion());
assertEquals((short) 2, requestCommittedRequestBuilder.oldestAllowedVersion()); assertEquals((short) 2, requestCommittedRequestBuilder.oldestAllowedVersion());
assertEquals((short) 7, maxTimestampRequestBuilder.oldestAllowedVersion()); assertEquals((short) 7, maxTimestampRequestBuilder.oldestAllowedVersion());