root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Fix typo in DumpLogSegments' TransactionLogMessageParser (#18505) 

The value should use `version` instead of `type`.

Reviewers: Jeff Kim <jeff.kim@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>
This commit is contained in:
David Jacot 2025-01-14 08:10:10 +01:00 committed by GitHub
parent da0c3beffa
commit f6912a9a6a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/main/scala/kafka/tools/DumpLogSegments.scala
View File

@ -548,7 +548,7 @@ object DumpLogSegments {
} }
val json = new ObjectNode(JsonNodeFactory.instance) val json = new ObjectNode(JsonNodeFactory.instance)
json.set("type", new TextNode(version.toString)) json.set("version", new TextNode(version.toString))
json.set("data", messageAsJson) json.set("data", messageAsJson)
json.toString json.toString
} }

4
core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala
View File

@ -858,7 +858,7 @@ class DumpLogSegmentsTest {
assertEquals( assertEquals(
( (
Some("{\"type\":\"0\",\"data\":{\"transactionalId\":\"txnId\"}}"), Some("{\"type\":\"0\",\"data\":{\"transactionalId\":\"txnId\"}}"),
Some("{\"type\":\"0\",\"data\":{\"producerId\":123,\"producerEpoch\":0,\"transactionTimeoutMs\":0," + Some("{\"version\":\"0\",\"data\":{\"producerId\":123,\"producerEpoch\":0,\"transactionTimeoutMs\":0," +
"\"transactionStatus\":0,\"transactionPartitions\":[],\"transactionLastUpdateTimestampMs\":0," + "\"transactionStatus\":0,\"transactionPartitions\":[],\"transactionLastUpdateTimestampMs\":0," +
"\"transactionStartTimestampMs\":0}}") "\"transactionStartTimestampMs\":0}}")
), ),
@ -915,7 +915,7 @@ class DumpLogSegmentsTest {
assertEquals( assertEquals(
( (
Some("{\"type\":\"0\",\"data\":{\"transactionalId\":\"txnId\"}}"), Some("{\"type\":\"0\",\"data\":{\"transactionalId\":\"txnId\"}}"),
Some("{\"type\":\"1\",\"data\":{\"producerId\":12,\"previousProducerId\":11,\"nextProducerId\":10," + Some("{\"version\":\"1\",\"data\":{\"producerId\":12,\"previousProducerId\":11,\"nextProducerId\":10," +
"\"producerEpoch\":2,\"transactionTimeoutMs\":14,\"transactionStatus\":0," + "\"producerEpoch\":2,\"transactionTimeoutMs\":14,\"transactionStatus\":0," +
"\"transactionPartitions\":[{\"topic\":\"topic1\",\"partitionIds\":[0,1,2]}," + "\"transactionPartitions\":[{\"topic\":\"topic1\",\"partitionIds\":[0,1,2]}," +
"{\"topic\":\"topic2\",\"partitionIds\":[3,4,5]}],\"transactionLastUpdateTimestampMs\":123," + "{\"topic\":\"topic2\",\"partitionIds\":[3,4,5]}],\"transactionLastUpdateTimestampMs\":123," +