From f914ed73e9de028d2e6bb1353cec02bcc2275c19 Mon Sep 17 00:00:00 2001 From: feyman2016 Date: Mon, 21 Jun 2021 18:19:05 +0000 Subject: [PATCH] KAFKA-12515; Feature support should be ignorable in ApiVersion response (#10377) Feature support should be treated as ignorable in the api version response so that we can gracefully downgrade for older clients without additional logic in the broker. Reviewers: Rajini Sivaram , Jason Gustafson --- .../main/resources/common/message/ApiVersionsResponse.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/src/main/resources/common/message/ApiVersionsResponse.json b/clients/src/main/resources/common/message/ApiVersionsResponse.json index 31d2dc3eb6c..06c343b6fa3 100644 --- a/clients/src/main/resources/common/message/ApiVersionsResponse.json +++ b/clients/src/main/resources/common/message/ApiVersionsResponse.json @@ -43,7 +43,7 @@ ]}, { "name": "ThrottleTimeMs", "type": "int32", "versions": "1+", "ignorable": true, "about": "The duration in milliseconds for which the request was throttled due to a quota violation, or zero if the request did not violate any quota." }, - { "name": "SupportedFeatures", "type": "[]SupportedFeatureKey", + { "name": "SupportedFeatures", "type": "[]SupportedFeatureKey", "ignorable": true, "versions": "3+", "tag": 0, "taggedVersions": "3+", "about": "Features supported by the broker.", "fields": [ @@ -58,7 +58,7 @@ { "name": "FinalizedFeaturesEpoch", "type": "int64", "versions": "3+", "tag": 1, "taggedVersions": "3+", "default": "-1", "ignorable": true, "about": "The monotonically increasing epoch for the finalized features information. Valid values are >= 0. A value of -1 is special and represents unknown epoch."}, - { "name": "FinalizedFeatures", "type": "[]FinalizedFeatureKey", + { "name": "FinalizedFeatures", "type": "[]FinalizedFeatureKey", "ignorable": true, "versions": "3+", "tag": 2, "taggedVersions": "3+", "about": "List of cluster-wide finalized features. The information is valid only if FinalizedFeaturesEpoch >= 0.", "fields": [