Commit Graph

1203 Commits

Author SHA1 Message Date
Owen Leung d233eb98f7
KAFKA-14957: Update-Description-String (#13909)
HTML code for configs is auto-generated and for Kafka Streams config `state.dir` produces a confusing default value.
This PR adds a new property `alternativeString` to set a "default" value which should be rendered in HTML instead of the actual default value.

Reviewers: Manyanda Chitimbo <manyanda.chitimbo@gmail.com>, @eziosudo <eziosudo@gmail.com>, Matthias J. Sax <matthias@confluent.io>
2024-02-10 12:46:51 -08:00
Hector Geraldino 24a79c2613
KAFKA-14683: Migrate WorkerSinkTaskTest to Mockito (1/3) (#14663)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-02-05 10:55:57 -08:00
Chris Egerton 4f0a405908
KAFKA-15575: Begin enforcing 'tasks.max' property for connectors (#15180)
Reviewers: Ashwin Pankaj <apankaj@confluent.io>, Greg Harris <greg.harris@aiven.io>
2024-02-01 11:33:04 -05:00
Chris Egerton 7bc4afee11
KAFKA-15675: Improve worker liveness check during Connect integration tests (#15249)
Reviewers: Greg Harris <greg.harris@aiven.io>, Yash Mayya <yash.mayya@gmail.com>
2024-02-01 09:20:24 -05:00
Yash Mayya 4e6920cc5f
KAFKA-16196: Handle invalid whole value casts in the Cast transform gracefully (#15267)
Reviewers: Chris Egerton <chrise@aiven.io>
2024-01-26 19:04:39 +05:30
Greg Harris d1d6b5096f
KAFKA-16166: Generify RetryWithToleranceOperator, ErrorReporter, and WorkerTask (#15233)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Chris Egerton <chrise@aiven.io>
2024-01-22 16:56:52 -08:00
Greg Harris 93971465b6
KAFKA-15827: Prevent KafkaBasedLog subclasses from leaking passed-in clients (#14763)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Chris Egerton <chrise@aiven.io>
2024-01-19 12:50:01 -08:00
Greg Harris e45e032b8d
KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all (#15154)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Chris Egerton <chrise@aiven.io>
2024-01-18 13:26:26 -08:00
Greg Harris 72b70288eb
KAFKA-5863: Avoid NPE when RestClient calls expecting no-content receive content. (#13294)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Hector Geraldino <hgeraldino@gmail.com>, Yash Mayya <yash.mayya@gmail.com>
2024-01-18 11:41:27 -08:00
Chris Egerton a989329ee3
MINOR: Stop leaking threads in BlockingConnectorTest (#12290)
Reviewers: Kvicii <kvicii.yu@gmail.com>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>, Greg Harris <greg.harris@aiven.io>
2024-01-18 11:11:32 -05:00
Octavian Ciubotaru 988aea3f58
KAFKA-16051: Fixed deadlock in StandaloneHerder (#15080)
Reviewers: Greg Harris <greg.harris@aiven.io>, Sagar Rao <sagarmeansocean@gmail.com>
2024-01-12 15:46:17 -08:00
Divij Vaidya 65424ab484
MINOR: New year code cleanup - include final keyword (#15072)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Ismael Juma <ismael@juma.me.uk>, Sagar Rao <sagarmeansocean@gmail.com>
2024-01-11 17:53:35 +01:00
Chris Egerton dbf00bcf45
KAFKA-16093: Fix spurious REST-related warnings on Connect startup (#15149)
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Greg Harris <greg.harris@aiven.io>
2024-01-10 09:03:23 -05:00
Chris Egerton c7e1fdca64
KAFKA-15988: Reuse embedded clusters across test cases in Connect OffsetsApiIntegrationTest suite (#14966)
Reviewers: Sudesh Wasnik <swasnik@confluent.io>, Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com>, Greg Harris <greg.harris@aiven.io>
2024-01-09 10:32:39 -05:00
Mickael Maison eccfb03e9a
MINOR: Small cleanups in Connect (#15128)
Reviewers: Divij Vaidya <diviv@amazon.com>
2024-01-05 11:00:10 +01:00
Greg Harris cd1eb634c5
KAFKA-15816: Fix leaked sockets in runtime tests (#14764)
This commit fixes to prevent socket leaks, mostly through clients that are left open.

Reviewers: Mickael Maison <mickael.maison@gmail.com>
2024-01-01 11:38:11 +01:00
Fiore Mario Vitale 314de9f23c
KAFKA-15996: Improve JsonConverter performance (#14992)
Improve JsonConverter performance by using afterBurnModule of Jackson library.

Reviewers: Divij Vaidya <diviv@amazon.com>, Mickael Maison <mickael.maison@gmail.com>
2023-12-24 21:47:12 +01:00
Said Boudjelda 05014badf2
KAFKA-15208: Upgrade Jackson dependencies to version 2.16.0 (#13662)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Divij Vaidya <diviv@amazon.com>
2023-12-19 15:31:24 +01:00
Greg Harris 3f7eadaa00
KAFKA-15372: Reconfigure dedicated MM2 connectors after leadership change (#14293)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Chris Egerton <chrise@aiven.io>
2023-12-12 13:57:56 -08:00
Greg Harris 75ad884161
KAFKA-15906: Emit latest MM2 offset syncs every offset.flush.interval.ms (#14967)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Chris Egerton <chrise@aiven.io>
2023-12-11 16:39:54 -08:00
Chris Egerton 2a5fbf2882
KAFKA-15563: Provide informative error messages when Connect REST requests time out (#14562)
Reviewers: Greg Harris <greg.harris@aiven.io>
2023-12-11 16:48:16 -05:00
Chris Egerton dc857fb6bf
KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes (#14304)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Greg Harris <greg.harris@aiven.io>
2023-12-08 15:00:44 -05:00
Matthew de Detrich 964e73178b
KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest (#12728)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-12-07 10:01:17 -05:00
Greg Harris a2d596c428
KAFKA-15816: Fix leaked sockets in mirror tests (#14761)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2023-12-06 10:44:32 -08:00
Chris Egerton a83bc2d977
KAFKA-13988: Enable replicating from latest offset with MirrorMaker 2 (#14567)
Reviewers: hudeqi <1217150961@qq.com>, Federico Valeri <fedevaleri@gmail.com>, Greg Harris <gharris1727@gmail.com>
2023-12-04 16:37:37 -05:00
vamossagar12 e8edc279f4
MINOR: Correcting Javadoc for ConnectAssertions (#14827)
Reviewers: Yash Mayya <yash.mayya@gmail.com>

---------

Co-authored-by: Yash Mayya <yash.mayya@gmail.com>
2023-11-27 15:29:08 +05:30
Yash Mayya ebf435e718
KAFKA-15888: DistributedHerder log context should not use the same client ID for each Connect worker by default (#14825)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-11-23 15:31:39 +05:30
Yash Mayya 5d717f2343
MINOR: Fix broken method link in DistributedHerder::writeToConfigTopicAsLeader Javadoc (#14824)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-11-23 03:22:56 +05:30
Yash Mayya 1bc4de75a2
KAFKA-15470: Allow creating connectors in a stopped state (#14704)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-11-15 11:37:50 +05:30
Greg Harris 989618a56e
KAFKA-15800: Prevent DataExceptions from corrupting KafkaOffsetBackingStore (#14718)
Signed-off-by: Greg Harris <greg.harris@aiven.io>

Reviewers: Yash Mayya <yash.mayya@gmail.com>
2023-11-10 08:40:16 -08:00
Chris Egerton 39c6170aa9
KAFKA-15693: Immediately reassign lost connectors and tasks when scheduled rebalance delay is disabled (#14647)
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com>
2023-11-09 10:48:43 -05:00
kumarpritam863 ca05da95c3
KAFKA-15680: Fix sink task partition-count metric when cooperative consumer protocol is used (#14630)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-11-06 11:32:05 -05:00
hudeqi 4083cd627e
KAFKA-15607: Fix NPE in MirrorCheckpointTask::syncGroupOffset (#14587)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-10-20 12:17:51 -04:00
Chris Egerton 091eb9b349
KAFKA-15428: Cluster-wide dynamic log adjustments for Connect (#14538)
Reviewers: Greg Harris <greg.harris@aiven.io>, Yang Yang <yayang@uber.com>, Yash Mayya <yash.mayya@gmail.com>
2023-10-20 09:52:37 -04:00
Matthias J. Sax 9b468fb278
MINOR: Do not end Javadoc comments with `**/` (#14540)
Reviewers: Bruno Cadonna <bruno@confluent.io>, Bill Bejeck <bill@confluent.io>, Hao Li <hli@confluent.io>, Josep Prat <josep.prat@aiven.io>
2023-10-17 21:11:04 -07:00
Hector Geraldino 4150595b0a
KAFKA-14684: Replace EasyMock/PowerMock with Mockito in WorkerSinkTaskThreadedTest (#14505)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Christo Lolov <christololov@gmail.com>
2023-10-16 11:24:52 +02:00
Yash Mayya 1c8bb61a43
KAFKA-15387: Deprecate Connect's redundant task configurations endpoint (#14361)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Sagar Rao <sagarmeansocean@gmail.com>
2023-10-14 14:46:50 +05:30
Omnia G.H Ibrahim 4bad90835b
KAFKA-15465: Don't throw if MirrorMaker not authorized to create internal topics. (#14388)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Ahmed Hibot
2023-10-13 12:53:09 +02:00
Yash Mayya 41c0d44402
KAFKA-15570: Add unit tests for MemoryConfigBackingStore (#14518)
Reviewers: Chris Egerton <chrise@aiven.io>, Kalpesh Patel <kpatel@confluent.io>
2023-10-12 14:25:40 +05:30
kpatelatwork fbc39bcdbe
KAFKA-15547: Fix thread leak in MirrorMakerConfigTest (#14487)
Reviewers: Akhilesh Chaganti <akhileshchg@users.noreply.github.com>, Rajini Sivaram <rajinisivaram@googlemail.com>, Yash Mayya <yash.mayya@gmail.com>
2023-10-05 10:19:15 +05:30
Lucas Brutschy 9c2e5daf60
MINOR: Revert log level changes in LogCaptureAppender (#14436)
LogCaptureAppender sets the log level in various tests to check if a certain log message is produced. The log level is however never reverted, changing the log level across the board and introducing flakiness due to non-determinism since the log level depends on execution order. Some log messages change the timing inside tests significantly.

Reviewer: Bruno Cadonna <cadonna@apache.org>
2023-09-26 10:49:41 +02:00
Hector Geraldino 7107a750ba
KAFKA-15248 (KIP-959): Add BooleanConverter to Kafka Connect (#14093)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Sagar Rao <sagarmeansocean@gmail.com>, Qichao Chu <5326144+ex172000@users.noreply.github.com>
2023-09-26 12:42:16 +05:30
Ismael Juma 98febb989a
KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N) (#14427)
This is one of the steps required for kafka to compile with Java 21.

For each case, one of the following fixes were applied:
1. Suppress warning if fixing would potentially result in an incompatible change (for public classes)
2. Add final to one or more methods so that the escape is not possible
3. Replace method calls with direct field access.

In addition, we also fix a couple of compiler warnings related to deprecated references in the `core` module.

See the following for more details regarding the new lint warning:
https://www.oracle.com/java/technologies/javase/21-relnote-issues.html#JDK-8015831

Reviewers: Divij Vaidya <diviv@amazon.com>, Satish Duggana <satishd@apache.org>, Chris Egerton <chrise@aiven.io>
2023-09-24 05:59:29 -07:00
Greg Harris b088307612
KAFKA-15473: Hide duplicate plugins in /connector-plugins (#14398)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Sagar Rao <sagarmeansocean@gmail.com>, Hector Geraldino <hgeraldino@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-09-19 12:37:21 -04:00
Yash Mayya 7872a1ff5b
KAFKA-14855: Harden integration testing logic for asserting that a connector is deleted (#14371)
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-09-19 11:39:39 -04:00
Chris Egerton 54ab5b29e4
KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case (#14313)
Reviewers: Philip Nee <pnee@confluent.io>, Greg Harris <greg.harris@aiven.io>
2023-09-07 19:24:17 -04:00
Yash Mayya 88b554fdbd
KAFKA-15179: Add integration tests for the file sink and source connectors (#14279)
Reviewers: Ashwin Pankaj <apankaj@confluent.io>, Chris Egerton <chrise@aiven.io>
2023-09-07 12:24:13 -04:00
Andrew Schofield b49013b73e
KAFKA-9800: Exponential backoff for Kafka clients - KIP-580 (#14111)
Implementation of KIP-580 to add exponential back-off to situations in which retry.backoff.ms
is used to delay backoff attempts. This KIP adds exponential backoff behavior with a maximum
controlled by a new config retry.backoff.max.ms, together with a +/- 20% of jitter to spread the
retry attempts of the client fleet.

Reviewers: Mayank Shekhar Narula <mayanks.narula@gmail.com>, Milind Luthra <i.milind.luthra@gmail.com>, Kirk True <kirk@mustardgrain.com>, Jun Rao<junrao@gmail.com>
2023-09-05 11:57:51 -07:00
Chris Egerton 1c5020e142
KAFKA-13327: Gracefully report connector validation errors instead of returning 500 responses (#14303)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Greg Harris <greg.harris@aiven.io>
2023-08-29 15:44:22 -04:00
Greg Harris 8611d28b2e
KAFKA-15392: Prevent shadowing RestServer shutdown exceptions (#14277)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-29 12:25:30 -07:00
Yash Mayya 880288879e
KAFKA-15377: Don't expose externalized secret values in tasks-config API endpoint (#14244)
Reviewers: Greg Harris <greg.harris@aiven.io>
2023-08-24 15:44:53 -07:00
Greg Harris a3303b6112
KAFKA-15393: Improve shutdown behavior in MM2 integration tests (#14278)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-08-24 12:24:34 -07:00
Yash Mayya 064a14795c
MINOR: Update OpenAPI summary documentation for Connect's /tasks endpoint (#14267)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2023-08-22 18:26:29 +02:00
Yash Mayya 7802c264c9
MINOR: Allow writing tombstone offsets for arbitrary partitions in the FileStreamSourceConnector (#14234)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-17 14:13:53 -04:00
Chris Egerton de409b389d
KAFKA-15177: Implement KIP-875 SourceConnector::alterOffset API in MirrorMaker 2 connectors (#14005)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Greg Harris <greg.harris@aiven.io>
2023-08-17 09:33:59 -04:00
Greg Harris 6bd17419b7
KAFKA-15228: Add sync-manifests command to connect-plugin-path (KIP-898) (#14195)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-16 11:37:33 -07:00
Greg Harris a9efca0bf6
KAFKA-14759: Move Mock, Schema, and Verifiable connectors to new test-plugins module (#13302)
Reviewers: Hector Geraldino <hgeraldino@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-08-16 10:30:24 -07:00
Omnia G.H Ibrahim 35e925f353
KAFKA-15102: Add replication.policy.internal.topic.separator.enabled property to MirrorMaker 2 (KIP-949) (#14082)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-15 19:58:52 -04:00
Greg Harris 28858f3a3e
MINOR: Fix SynchronizationTest classloaders sometimes not being parallel capable (#14177)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-15 14:24:48 -07:00
Greg Harris 1a001c1e88
KAFKA-15336: Add ServiceLoader Javadocs for Connect plugins (#14194)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-15 13:21:45 -07:00
Greg Harris f5655d31d3
KAFKA-15030: Add connect-plugin-path command-line tool (#14064)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-11 12:05:51 -07:00
bachmanity1 f137da04fa
KAFKA-14132: Replace Easymock & Powermock with Mockito in KafkaBasedLogTest (#14153)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Divij Vaidya <diviv@amazon.com>
2023-08-11 10:50:37 +02:00
Federico Valeri 8de3e0436a
KAFKA-15239: Fix system tests using producer performance service (#14092)
Reviewers: Greg Harris <greg.harris@aiven.io>
2023-08-10 14:23:43 -07:00
Yash Mayya f2ebd333e8
KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest (#14102)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-10 16:47:30 -04:00
Greg Harris 0ee26640e5
KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced (#14156)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-10 13:25:50 -07:00
aindriu-aiven db34f8b9a1
KAFKA-15291: Connect plugins should declare a version (#14159)
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Reviewers: Andrew Schofield, Greg Harris <greg.harris@aiven.io>
2023-08-10 10:45:12 -07:00
Yash Mayya f23394336a
MINOR: Use Mockito's strict stubs functionality for Connect tests and cleanup unused stubs (#14166)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2023-08-09 11:13:28 +02:00
Greg Harris ff4fed5cbe
KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898) (#14055)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-08 10:06:35 -07:00
Yash Mayya b9936d6292
KAFKA-7438: Replace PowerMockRunner with MockitoJUnitRunner in RetryUtilTest (#14143)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-03 13:07:35 -04:00
Greg Harris b9a45546a7
KAFKA-15244: Remove PluginType.from(Class) (#14089)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-08-01 10:05:46 -07:00
Yash Mayya 3ba718e159
MINOR: Remove duplicate instantiation of MockConnectMetrics in AbstractWorkerSourceTaskTest (#14091)
Reviewers: Christo Lolov <christololov@gmail.com>, Manyanda Chitimbo <manyanda.chitimbo@gmail.com>, Greg Harris <greg.harris@aiven.io>
2023-07-28 11:35:42 -07:00
Yash Mayya 08b3820d5e
KAFKA-15238: Move DLQ reporter setup from the DistributedHerder's tick thread to the sink task thread (#14079)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-07-25 09:03:29 -04:00
Chris Egerton 58b8c5c7b1
MINOR: Downgrade log level for conflicting Connect plugin aliases (#14081)
Reviewers: Greg Harris <greg.harris@aiven.io>
2023-07-25 08:12:46 -04:00
Yash Mayya 4daeb2714c
KAFKA-13431 (KIP-793): Expose the original pre-transform topic partition and offset in sink records (#14024)
Reviewers: Greg Harris <greg.harris@aiven.io>, Chris Egerton <chrise@aiven.io>
2023-07-21 12:06:01 -04:00
Greg Harris 125dbb9286
KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime (#13313)
Reviewers: Ismael Juma <ismael@juma.me.uk>
2023-07-20 12:58:48 -07:00
Yash Mayya ea6e100ec3
KAFKA-15216: InternalSinkRecord::newRecord should not ignore new headers (#14044)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-07-20 10:22:35 -04:00
Greg Harris f6e7aa3763
KAFKA-15150: Add ServiceLoaderScanner implementation (#13971)
Reviewers: Chris Egerton <chris.egerton@aiven.io>
2023-07-19 16:21:58 -07:00
Greg Harris 844469311a
KAFKA-10579: Upgrade reflections from 0.9.12 to 0.10.2 (#14029)
Reviewers: Divij Vaidya <diviv@amazon.com>, Chris Egerton <chris.egerton@aiven.io>
2023-07-19 14:00:15 -07:00
Greg Harris d5a00cca74
KAFKA-15162: Reflectively find plugins in parent ClassLoaders that aren't on the classpath (#13977)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewed-by: Chris Egerton <chris.egerton@aiven.io>
2023-07-19 12:49:25 -07:00
Yash Mayya a68281bf3c
MINOR: Fix Connect compatibility javadocs to use NoSuchMethodError instead of NoSuchMethodException (#14036)
Reviewed-by: Greg Harris <greg.harris@aiven.io>
2023-07-19 10:23:02 -07:00
Greg Harris 1f7f6ceebf
KAFKA-15211: Mock InvalidParameterException in DistributedConfigTest (#14039)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewed-by: Chris Egerton <chris.egerton@aiven.io>
2023-07-19 09:02:44 -07:00
Yash Mayya d6aaddf6ee
KAFKA-15091: Fix misleading Javadoc for SourceTask::commit (#13948)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-07-18 16:38:30 -04:00
Gantigmaa Selenge 5cb2504c49
KAFKA-14669: Use the generated docs for MirrorMaker configs in the doc (#13658)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-07-18 11:27:19 -04:00
Yash Mayya 0b025b7711
KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector (#13945)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-07-18 10:37:51 -04:00
Yash Mayya 2b19b7325a
KAFKA-15182: Normalize source connector offsets before invoking SourceConnector::alterOffsets (#14003)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-07-14 12:14:03 -04:00
hudeqi 8d24716f27
MINOR: Avoid slow Set.removeAll(List) in MirrorSourceConnector (#13992)
Reviewed-by: Greg Harris <greg.harris@aiven.io>
2023-07-12 12:19:35 -07:00
Sambhav Jain d114d8e29c
KAFKA-14938: Fixing flaky test testConnectorBoundary (#13646)
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Yash Mayya <yash.mayya@gmail.com>, 
Sudesh Wasnik <swasnik@confluent.io>, Chris Egerton <chrise@aiven.io>
2023-07-12 11:45:49 -04:00
ezio 170f5f4ed0
KAFKA-15148: Mark tests correctly as integration tests where they running as unit tests (#13973)
Reviewers: Divij Vaidya <diviv@amazon.com>
2023-07-12 13:41:58 +02:00
vamossagar12 adacfea2d6
KAFKA-12525: Ignoring stale status statuses when reading from Connect status topic (#13453)
During fast consecutive rebalances where a task is revoked from one worker and assigned to another one, it has been observed that there is a small time window and thus a race condition during which a RUNNING status record in the new generation is produced and is immediately followed by a delayed UNASSIGNED status record belonging to the same or a previous generation before the worker that sends this message reads the RUNNING status record that corresponds to the latest generation.
Although this doesn't inhibit the actual execution of tasks, it reports an incorrect status for those tasks(i.e UNASSIGNED). If the users have setup some kind of monitoring on tasks status then this could lead to false alarms for example.
This fix addresses this problem by checking if a status message is stale after reading it and updates it's status only when it is safe to. 

Reviewers: Lucent-Wong <manchesterfans@live.cn>, Chris Egerton <chrise@aiven.io>, Yash Mayya <yash.mayya@gmail.com>, Konstantine Karantasis <k.karantasis@gmail.com>
2023-07-11 08:05:10 -07:00
hudeqi 51bc41031b
KAFKA-15139: Avoid slow Set.removeAll(List) in MirrorCheckpointConnector (#13946)
Reviewed-by: Greg Harris <greg.harris@aiven.io>
2023-07-10 14:35:46 -07:00
Yash Mayya 9ee28d1fe6
KAFKA-15145: Don't re-process records filtered out by SMTs on Kafka client retriable exceptions in AbstractWorkerSourceTask (#13955)
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-07-10 13:26:58 -04:00
Hector Geraldino 6368d14a1d
KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest (#13383)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-07-10 12:58:54 -04:00
Divij Vaidya d9a3e60dcc
KAFKA-14718: Wait for MirrorMaker to start before executing test (#13284) 2023-07-10 12:53:01 -04:00
Greg Harris 1b925e9ee7
KAFKA-15069: Refactor plugin scanning logic into ReflectionScanner (#13821)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-07-06 13:22:28 -04:00
Yash Mayya a1a3ec0bcb
MINOR: Update connector status metric description to include 'stopped' as a potential value (#13967)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2023-07-06 15:28:07 +02:00
vamossagar12 96e59d7bfd
[MINOR] Correcting few WARN log lines in DistributedHerder#handleRebalance (#13939)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-30 12:39:37 -04:00
Ismael Juma 1f4cbc5d53
MINOR: Add JDK 20 CI build and remove some branch builds (#12948)
It's good for us to add support for Java 20 in preparation for Java 21 - the next LTS.

Given that Scala 2.12 support has been deprecated, a Scala 2.12 variant is not included.

Also remove some branch builds that add load to the CI, but have
low value: JDK 8 & Scala 2.13 (JDK 8 support has been deprecated),
JDK 11 & Scala 2.12 (Scala 2.12 support has been deprecated) and
JDK 17 & Scala 2.12 (Scala 2.12 support has been deprecated).

A newer version of Mockito (4.9.0 -> 4.11.0) is required for Java 20 support, but we
only use it with Scala 2.13+ since it causes compilation errors with Scala 2.12. Similarly,
we upgrade easymock when the Java version is 16 or newer as it's incompatible
with powermock (which doesn't support Java 16 or newer).

Filed KAFKA-15117 for a test that fails with Java 20 (SslTransportLayerTest.testValidEndpointIdentificationCN).

Finally, fixed some lossy conversions that were added after #13582 was submitted.

Reviewers: Ismael Juma <ismael@juma.me.uk>
2023-06-30 01:12:00 -07:00
Yash Mayya 32bcdac6a1
MINOR: Replace synchronization with atomic update in Connect's StateTracker::changeState method (#13934)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-29 15:05:06 -04:00
Bo Gao 005416879e
KAFKA-15053: Use case insensitive validator for security.protocol config (#13831)
Fixed a regression described in KAFKA-15053 that security.protocol only allows uppercase values like PLAINTEXT, SSL, SASL_PLAINTEXT, SASL_SSL. With this fix, both lower case and upper case values will be supported (e.g. PLAINTEXT, SSL, SASL_PLAINTEXT, SASL_SSL, plaintext, ssl, sasl_plaintext, sasl_ssl)

Reviewers: Chris Egerton <chrise@aiven.io>, Divij Vaidya <diviv@amazon.com>
2023-06-29 10:13:21 +02:00
Greg Harris 3978684126
MINOR: Silence error logs for faulty plugins in integration tests (#13912)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-23 14:10:18 -04:00
Yash Mayya 6e72986949
KAFKA-14784: Connect offset reset REST API (#13818)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-23 13:27:46 -04:00
Mickael Maison 3c059133d3
MINOR: Fix generated client ids for Connect (#13896)
Reviewers: Chris Egerton <fearthecellos@gmail.com>
2023-06-21 21:44:14 +02:00
Greg Harris 3b72b0abb1
MINOR: Optimize runtime of MM2 integration tests by batching transactions (#13816)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-21 14:51:54 -04:00
minjian.cai d751c13950
MINOR: Fix typos for connect (#13885)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-20 16:16:16 -04:00
Chris Egerton 73dd51e137
Revert "MINOR: Reduce MM2 integration test flakiness due to missing dummy offset commits (#13838)" (#13864)
Reviewers: Josep Prat <josep.prat@aiven.io>

Reverts commit 505c7b6487.
2023-06-16 12:10:26 -04:00
Chris Egerton e1d59920f4
KAFKA-15059: Remove pending rebalance check when fencing zombie source connector tasks (#13819)
Discovered while researching KAFKA-14718

Currently, we perform a check during zombie fencing that causes the round of zombie fencing to fail when a rebalance is pending (i.e., when we've detected from a background poll of the config topic that a new connector has been created, that an existing connector has been deleted, or that a new set of connector tasks has been generated).

It's possible but not especially likely that this check causes issues when running vanilla Kafka Connect. Even when it does, it's easy enough to restart failed tasks via the REST API.

However, when running MirrorMaker 2 in dedicated mode, this check is more likely to cause issues as we write three connector configs to the config topic in rapid succession on startup. And in that mode, there is no API to restart failed tasks aside from restarting the worker that they are hosted on.

In either case, this check can lead to test flakiness in integration tests for MirrorMaker 2 both in dedicated mode and when deployed onto a vanilla Kafka Connect cluster.

This check is not actually necessary, and we can safely remove it. Copied from Jira:

>If the worker that we forward the zombie fencing request to is a zombie leader (i.e., a worker that believes it is the leader but in reality is not), it will fail to finish the round of zombie fencing because it won't be able to write to the config topic with a transactional producer.

>If the connector has just been deleted, we'll still fail the request since we force a read-to-end of the config topic and refresh our snapshot of its contents before checking to see if the connector exists.

>And regardless, the worker that owns the task will still do a read-to-end of the config topic and verify that (1) no new task configs have been generated for the connector and (2) the worker is still assigned the connector, before allowing the task to process any data.

In addition, while waiting on a fix for KAFKA-14718 that adds more granularity for diagnosing failures in the DedicatedMirrorIntegrationTest suite (#13284), some of the timeouts in that test are bumped to work better on our CI infrastructure.

Reviewers: Mickael Maison <mickael.maison@gmail.com>, Yash Mayya <yash.mayya@gmail.com>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>
2023-06-16 11:58:36 +02:00
Greg Harris 505c7b6487
MINOR: Reduce MM2 integration test flakiness due to missing dummy offset commits (#13838)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2023-06-15 12:02:32 +02:00
Gantigmaa Selenge 930744c3a8
KAFKA-14709: Move content in connect/mirror/README.md to the docs (#13650)
Most of the contents in the README.md was already covered in the docs therefore only had to add the section for Exactly Once support.

Reviewers: Luke Chen <showuon@gmail.com>
2023-06-15 10:16:52 +08:00
Chris Egerton 6b128d7e30
KAFKA-14006: Parameterize WorkerConnectorTest suite (#12307)
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Christo Lolov <lolovc@amazon.com>, Kvicii <kvicii.yu@gmail.com>, Mickael Maison <mickael.maison@gmail.com>
2023-06-08 11:20:35 -04:00
Greg Harris c8cb85274e
MINOR: Refactor DelegatingClassLoader to emit immutable PluginScanResult (#13771)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-06 09:37:57 -04:00
Chris Egerton 17fd30e6b4
MINOR: Fix flaky DistributedHerderTest cases related to zombie fencing (#13806)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-06-05 15:50:54 -04:00
Yash Mayya 383a8d6114
MINOR: Handle the config topic read timeout edge case in DistributedHerder's stopConnector method (#13750)
Reviewers: Chris Egerton
2023-06-05 11:10:59 -04:00
Yash Mayya fca7ee7270
MINOR: Remove reference to 'offset backing store' from exception message in KafkaBasedLog (#13810)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-05 10:04:17 -04:00
Yash Mayya 8e60368d90
MINOR: Re-introduce Transformation import to fix TransformationChain Javadoc (#13808)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-05 09:43:03 -04:00
Greg Harris 6678f1b66a
KAFKA-14863: Fix failing tests for invalid plugins that are no longer visible (#13805)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-03 12:55:20 -04:00
Yash Mayya 02fb4b882b
KAFKA-15012: Allow leading zeros in numeric fields while deserializing JSON messages using the JsonConverter (#13800)
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-06-02 11:20:37 -04:00
Greg Harris 89581a738f
KAFKA-14863: Hide plugins with invalid constructors during plugin discovery (#13467)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-02 11:09:43 -04:00
Yash Mayya 9bb2f78d53
KAFKA-15034: Improve performance of the ReplaceField SMT; add JMH benchmark (#13776)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-06-01 15:14:31 -04:00
Greg Harris 6846f51445
MINOR: Remove spurious warning about plugin.path config provider usage when null (#13783)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-05-31 12:57:58 -04:00
vamossagar12 03ab563206
MINOR: Fixing typo in ExactlyOnceWorkerSourceTask#committableRecords (#13755)
Co-authored-by: Sagar Rao <sagarrao@Sagars-MacBook-Pro.local>

Reviewers: Yash Mayya <yash.mayya@gmail.com>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>
2023-05-31 16:26:31 +02:00
Greg Harris 1957be19d9
KAFKA-8713: JsonConverter replace.null.with.default should prevent emitting default for Struct fields (#13781)
Co-authored-by: GeunJae Jeon <krespo>
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2023-05-31 15:48:03 +02:00
Greg Harris 9aac5ff1fe
MINOR: Move plugin path parsing from DelegatingClassLoader to PluginUtils (#13334)
Reviewers: Chaitanya Mukka <chaitanya.mvs2007@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-05-26 12:36:00 -04:00
Greg Harris 2ec6b5e1e2
KAFKA-14789: Prevent mis-attributing classpath plugins, allow discovery of classpath RestExtension and ConfigProvider (#13356)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-05-26 12:17:07 -04:00
Yash Mayya 7ff2dbb107
KAFKA-14368: Connect offset write REST API (#13465)
Reviewers: Greg Harris <greg.harris@aiven.io>, Chris Egerton <chrise@aiven.io>
2023-05-26 12:08:06 -04:00
Greg Harris dc00832b96
KAFKA-14654: Connector classes should statically initialize with plugin classloader (#13165)
Reviewers: Chaitanya Mukka <chaitanya.mvs2007@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-05-25 10:22:44 -04:00
Sungyun Hur 916e801010
MINOR: Fix whitespace typo in Connect Config docs (#13752)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Yash Mayya <yash.mayya@gmail.com>, Divij Vaidya <diviv@amazon.com>
2023-05-24 21:48:47 +02:00
Andras Katona 5b3b385881
KAFKA-13504: Retry connect internal topics' creation in case of InvalidReplicationFactorException (#11565)
In case the Kafka Broker cluster and the Kafka Connect cluster is started together and Connect would want to create its topics, there's a high chance to fail the creation with InvalidReplicationFactorException.

---------

Co-authored-by: Daniel Urban <durban@cloudera.com>

Reviewers: Daniel Urban <durban@cloudera.com>, Mickael Maison <mickael.maison@gmail.com>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>, Chris Egerton <chrise@aiven.io>, Laszlo Hunyadi <laszlo.istvan.hunyady@gmail.com>
2023-05-24 11:05:02 +02:00
Chris Egerton a14e73a036
KAFKA-14980: Fix MirrorSourceConnector source consumer configuration (#13723)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Josep Prat <josep.prat@aiven.io>
2023-05-19 14:45:01 +02:00
Dániel Urbán f17fb75b2d
KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics (#13690)
Reviewers: Chris Egerton <chrise@aiven.io>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>
2023-05-10 16:41:52 +02:00
Yash Mayya 59ba9dbbc9
KAFKA-14974: Restore backward compatibility in KafkaBasedLog (#13688)
`KafkaBasedLog` is a widely used utility class that provides a generic implementation of a shared, compacted log of records in a Kafka topic. It isn't in Connect's public API, but has been used outside of Connect and we try to preserve backward compatibility whenever possible. KAFKA-14455 modified the two overloaded void `KafkaBasedLog::send` methods to return a `Future`. While this change is source compatible, it isn't binary compatible. We can restore backward compatibility simply by renaming the new Future returning send methods, and reinstating the older send methods to delegate to the newer methods.

This refactoring changes no functionality other than restoring the older methods.

Reviewers: Randall Hauch <rhauch@gmail.com>
2023-05-09 07:28:45 -05:00
vamossagar12 86daf8ce65
KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime (#13594)
#13557 introduced a utils method to close executors silently. This PR leverages that method to close executors in connect runtime. There was duplicate code while closing the executors which isn't the case with this PR.

Note that there are a few more executors used in Connect runtime but their close methods don't follow this pattern of shutdown, await and shutdown. Some of them have some logic like executor like Worker, so not changing at such places.

---------

Co-authored-by: Sagar Rao <sagarrao@Sagars-MacBook-Pro.local>

Reviewers: Daniel Urban <durban@cloudera.com>, Yash Mayya <yash.mayya@gmail.com>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>
2023-05-08 16:39:47 +02:00
Christo Lolov f44ee4fab7
MINOR: Remove unnecessary code in client/connect (#13259)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2023-05-02 17:39:31 +02:00
Yash Mayya 4773961a44
MINOR: Fix Javadoc for configureAdminResources in Connect's RestServer (#13635)
Reviewers: Manyanda Chitimbo <manyanda.chitimbo@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-05-01 12:21:09 -04:00
vamossagar12 007c0d375a
KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure (#13634)
Co-authored-by: Sagar Rao <sagarrao@Sagars-MacBook-Pro.local>

Reviewers: Daniel Urban <durban@cloudera.com>, Justine Olshan <jolshan@confluent.io>, Manyanda Chitimbo <manyanda.chitimbo@gmail.com>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>
2023-04-26 14:23:56 +02:00
Greg Harris baf127a663
KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication (#13429)
Reviewers: Daniel Urban <durban@cloudera.com>, Chris Egerton <chrise@aiven.io>
2023-04-26 03:30:13 -04:00
Yash Mayya 4780dc773f
KAFKA-14933: Document Connect's log level REST APIs from KIP-495 (#13636)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Manyanda Chitimbo <manyanda.chitimbo@gmail.com>
2023-04-25 17:50:35 +02:00
Greg Harris 7061475445
KAFKA-14905: Reduce flakiness in MM2 ForwardingAdmin test due to admin timeouts (#13575)
Reduce flakiness of `MirrorConnectorsWithCustomForwardingAdminIntegrationTest`

Reviewers: Josep Prat <jlprat@apache.org>
2023-04-21 21:55:41 +02:00
Dimitar Dimitrov e14dd8024a
KAFKA-14821 Implement the listOffsets API with AdminApiDriver (#13432)
We are handling complex workflows ListOffsets by chaining together MetadataCall instances and ListOffsetsCall instances, there are many complex and error-prone logic. In this PR we rewrote it with the `AdminApiDriver` infra, notable changes better than old logic:
1. Retry lookup stage on receiving `NOT_LEADER_OR_FOLLOWER` and `LEADER_NOT_AVAILABLE`, whereas in the past we failed the partition directly without retry.
2. Removing class field `supportsMaxTimestamp` and calculating it on the fly to avoid the mutable state, this won't change any behavior of  the client.
3. Retry fulfillment stage on `RetriableException`, whereas in the past we just retry fulfillment stage on `InvalidMetadataException`, this means we will retry on `TimeoutException` and other `RetriableException`.

We also `handleUnsupportedVersionException` to `AdminApiHandler` and `AdminApiLookupStrategy`, they are used to keep consistency with old logic, and we can continue improvise them. 

Reviewers: Ziming Deng <dengziming1993@gmail.com>, David Jacot <djacot@confluent.io>
2023-04-20 11:29:27 +08:00
Dániel Urbán 454b72161a
KAFKA-14902: KafkaStatusBackingStore retries on a dedicated background thread to avoid stack overflows (#13557)
KafkaStatusBackingStore uses an infinite retry logic on producer send, which can lead to a stack overflow.
To avoid the problem, a background thread was added, and the callback submits the retry onto the background thread.
2023-04-18 09:40:14 +02:00
Greg Harris f252c75bf3
MINOR: Fix regression in MM2 task forwarding introduced by KAFKA-14783 (#13548)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-04-13 09:50:02 -04:00
dorwi 9c0caca660
MINOR: update the connect task metrics documentation (#13494)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-04-12 12:08:07 -04:00
Chris Egerton e49a5a265f
KAFKA-14783 (KIP-875): New STOPPED state for connectors (#13424)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Yash Mayya <yash.mayya@gmail.com>, Greg Harris <gharris1727@gmail.com>
2023-04-11 09:37:26 -04:00
Gantigmaa Selenge 751a8af1f0
KAFKA-14420: Use incrementalAlterConfigs API for syncing topic configurations in MirrorMaker 2 (KIP-894) (#13373)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-04-10 11:55:49 -04:00
Chris Egerton 5e820571de
MINOR: Fix base ConfigDef in AbstractHerder::connectorPluginConfig (#13466)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Greg Harris <gharris1727@gmail.com>
2023-04-04 11:57:42 +02:00
Yash Mayya 970dea60e8
KAFKA-14785 (KIP-875): Connect offset read REST API (#13434)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-04-02 13:09:33 -04:00
Dániel Urbán 0aa365add8
KAFKA-14838: Add flow/connector/task/role information to MM2 Kafka client.id configs (#13458)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-03-31 10:50:11 -04:00
Jorge Esteban Quilcate Otoya 5afedd9ac3
KAFKA-14843: Include Connect framework properties when retrieving connector config definitions (#13445)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Greg Harris <greg.harris@aiven.io>, Chris Egerton <chrise@aiven.io>
2023-03-28 11:26:23 -04:00
hudeqi f7ea9cfb50
KAFKA-14837/14842:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector (#13446)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-03-28 09:19:52 -04:00
Greg Harris 3c4fb01ba8
MINOR: Refactor Mirror integration tests to reduce duplication (#13428)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2023-03-24 16:18:26 +01:00
Chaitanya Mukka 3c25b311cb
KAFKA-14814: Skip Connect target state updates when the configs store has same state (#13426)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-03-23 11:23:38 -04:00
Mickael Maison 1d8f79964e
KAFKA-14740: Add source tag to MirrorSourceMetrics - KIP-911 (#13420)
New add.source.alias.to.metrics setting to add the source cluster alias to the MirrorSourceConnector metrics

Reviewers: Chris Egerton <fearthecellos@gmail.com>
2023-03-21 19:16:04 +01:00
Mickael Maison 1b278c4e55
KAFKA-8713: Allow using null for field in JsonConverter (KIP-581) (#13419)
Add a new configuration replace.null.with.default to allow using null instead of the default value.

Reviewers: Chris Egerton <fearthecellos@gmail.com>
2023-03-21 17:57:28 +01:00
Greg Harris 897ced12ee
KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag (#13367)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-03-21 09:31:08 -04:00
Zheng-Xian Li ccda370e95
KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect (#13398)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2023-03-21 16:45:40 +08:00
Chris Egerton e427897c67
KAFKA-14816: Only load SSL properties when issuing cross-worker requests to HTTPS URLs (#13415)
This fixes a regression introduced in #12828, which caused workers to start unconditionally loading (and therefore validating) SSL-related properties when issuing REST requests to other workers. That was fine for the most part, but caused unnecessary failures when workers were configured with invalid SSL-related properties and their REST API used HTTP instead of HTTPS.

Reviewers: Ian McDonald <imcdonald@confluent.io>, Greg Harris <greg.harris@aiven.io>, Yash Mayya <yash.mayya@gmail.com>, Justine Olshan <jolshan@confluent.io>
2023-03-20 08:32:01 -07:00
Mickael Maison 34ec6bdef8
MINOR: Log consumer groups mirrored by checkpoint tasks (#13389)
Reviewers: Chris Egerton <fearthecellos@gmail.com>
2023-03-16 14:22:36 +01:00
Hector Geraldino 7bf1906132
KAFKA-14809 Fix logging conditional on WorkerSourceTask (#13386)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-03-16 08:39:31 -04:00
Chris Egerton 404a833df7
KAFKA-14799: Ignore source task requests to abort empty transactions (#13379)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2023-03-14 15:10:29 -04:00
Yash Mayya 4608070db1
MINOR: Fix error check in Connect Worker zombie fencing (#13392) 2023-03-14 12:09:52 -04:00
Chris Egerton 39d41e5aac
KAFKA-14781: Downgrade MM2 log message severity when no ACL authorizer is configured on source broker (#13351)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2023-03-08 10:25:55 -05:00
Mickael Maison 71fa008b45
KAFKA-14745: Cache the ReplicationPolicy instance in MirrorConnectorConfig (#13328)
Reviewers: Chris Egerton <fearthecellos@gmail.com>
2023-03-03 12:14:17 +01:00
Greg Harris 3109e9c843
KAFKA-14649: Isolate failures during plugin path scanning to single plugin classes (#13182)
Reviewers: Christo Lolov <christo_lolov@yahoo.com>, Chris Egerton <chrise@aiven.io>
2023-03-02 15:10:01 -05:00
Greg Harris b0e28351ec
MINOR: Refactor task change logic to AbstractHerder, reuse for standalone mode. (#13287)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-03-02 09:53:52 -05:00
Greg Harris 7322f4cd55
MINOR: reformat ClusterConfigState constructions in Abstract & DistributedHerder (#13286)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-02-28 12:50:44 -05:00
Greg Harris f586fa59d3
KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation (#13184)
Reviewers: Christo Lolov <christololov@gmail.com>, Yash Mayya <yash.mayya@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-02-28 11:23:19 -05:00
Yash Mayya 8dd697b05f
KAFKA-14732: Use an exponential backoff retry mechanism while reconfiguring connector tasks (#13276)
Reviewers: Chaitanya Mukka <chaitanya.mvs2007@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-02-28 10:36:34 -05:00
Hector Geraldino a1b8586a57
KAFKA-14659 source-record-write-[rate|total] metrics should exclude filtered records (#13193)
Reviewers: Christo Lolov <christololov@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-02-28 09:40:18 -05:00
Greg Harris 867fb295d0
KAFKA-14742: Throttle connectors in ExactlyOnceSourceIntegrationTest to fix flakey OOMEs (#13291)
KAFKA-14742: Throttle connectors in ExactlyOnceSourceIntegrationTest to fix flakey OOMEs
fixup: rename config constant, use meaningful constant names in EOSIT

Signed-off-by: Greg Harris <greg.harris@aiven.io>

Reviewers: Edoardo Comar <edocomar@gmail.com>
2023-02-28 10:21:36 +00:00
Hector Geraldino 5f9d01668c
KAFKA-14060: Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest (#13191)
Reviewers: Christo Lolov <christololov@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-02-27 09:25:21 -05:00
Mickael Maison 8d7d563231
MINOR: Remove duplicate empty string check (#13145)
Reviewers: Chris Egerton <fearthecellos@gmail.com>, Christo Lolov <christololov@gmail.com>
2023-02-27 14:49:12 +01:00
Greg Harris a54a34a11c
KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag, syncing stale offsets, and flaky integration tests (#13178)
KAFKA-12468: Fix negative lag on down consumer groups synced by MirrorMaker 2

KAFKA-13659: Stop syncing consumer groups with stale offsets in MirrorMaker 2

KAFKA-12566: Fix flaky MirrorMaker 2 integration tests

Reviewers: Chris Egerton <chrise@aiven.io>
2023-02-17 17:25:17 -05:00
Chris Egerton 38e4311622
MINOR: Fix PluginInfoTest for Connect (#13266)
Reviewers: Kamal Chandraprakash <kchandraprakash@uber.com>

Note: Merged without committer review in order to fix the build on trunk
2023-02-17 10:31:32 -05:00
Greg Harris aea6090ce4
KAFKA-14727: Enable periodic offset commits for EOS source tasks (#13262)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-02-16 18:51:34 -05:00
Christo Lolov ba0c5b0902
MINOR: Simplify JUnit assertions in tests; remove accidental unnecessary code in tests (#13219)
* assertEquals called on array
* Method is identical to its super method
* Simplifiable assertions
* Unused imports

Reviewers: Mickael Maison <mickael.maison@gmail.com>, Divij Vaidya <diviv@amazon.com>
2023-02-16 16:13:31 +01:00
Greg Harris 958bc0601c
KAFKA-5756: Wait for concurrent source task offset flush to complete before starting next flush (#13208)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chris Egerton <chrise@aiven.io>
2023-02-15 21:29:20 -05:00
Dániel Urbán b9754747d6
KAFKA-14653: Use raw properties instead of post-resolution properties for MirrorMaker connectors(#13163)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-02-14 16:36:34 -05:00
Chris Egerton 8cfafba279
KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector (#12366)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2023-02-13 10:09:14 -05:00
Chris Egerton f93d5af839
KAFKA-15086, KAFKA-9981: Intra-cluster communication for Mirror Maker 2 (#13137)
Reviewers: Daniel Urban <durban@cloudera.com>, Greg Harris <greg.harris@aiven.io>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>, Mickael Maison <mickael.maison@gmail.com>
2023-02-09 10:50:07 -05:00
Christo Lolov a0a9b6ffea
MINOR: Remove unnecessary code (#13210)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Divij Vaidya <diviv@amazon.com>
2023-02-07 17:37:45 +01:00
Yash Mayya 8f00782be7
MINOR: Connect Javadocs improvements (#13120)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Greg Harris <gharris1727@gmail.com>
2023-02-06 12:07:53 +01:00
Chris Egerton 9ab689f7d4
KAFKA-14610: Publish Mirror Maker 2 offset syncs in task commit() method (#13181)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Greg Harris <gharris1727@gmail.com>
2023-02-06 10:53:58 +01:00
Yash Mayya 6e2b86597d
MINOR: Update incorrect / misleading comment regarding rebalance exceptions in WorkerSinkTask (#13194)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-02-03 09:00:08 -05:00
Yash Mayya a3cf8b54e0
KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic (#12984)
Reviewers: Greg Harris <greg.harris@aiven.io>, Chris Egerton <chrise@aiven.io>
2023-02-02 11:03:38 -05:00
Chris Egerton 17559d581e
KAFKA-14645: Use plugin classloader when retrieving connector plugin config definitions (#13148)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Greg Harris <gharris1727@gmail.com>
2023-01-30 18:06:02 +01:00
Nikolay 26119bae90
KAFKA-14463 Close ConnectorClientConfigOverridePolicy instances (#13144)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-01-23 21:38:37 -05:00
vamossagar12 cfbd8979bc
KAFKA-14311: Cleanly cleanly stop connectors/tasks on Connect worker shutdown (#12802)
Reviewers: Chris Egerton <chrise@aiven.io>
2023-01-23 14:15:59 -05:00
Chris Egerton a382acd31d
KAFKA-13709 (follow-up): Avoid mention of 'exactly-once delivery' or 'delivery guarantees' in Connect (#13106) 2023-01-13 09:19:29 -05:00
emilnkrastev 6e7e2e08a9
KAFKA-12558: Do not prematurely mutate internal partition state in Mirror Maker 2 (#11818)
Reviewers: Greg Harris <greg.harris@aiven.io>, Chris Egerton <chrise@aiven.io>
2023-01-10 09:46:25 -05:00
csolidum ad94dc2134
KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null OffsetAndMetadata gracefully (#13052)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Greg Harris <gharris1727@gmail.com>
2023-01-04 12:02:52 +01:00
Yash Mayya a286891566
KAFKA-6586: Refactor ConnectDistributed and ConnectStandalone to re-use shared logic (#12947)
Reviewers: Christo Lolov  <christo_lolov@yahoo.com>, Chris Egerton <chrise@aiven.io>
2022-12-21 13:13:56 -05:00
Shekhar Rajak 2dcf306ef8
KAFKA-14132: Replace EasyMock and PowerMock with Mockito in connect/runtime/ErrorHandlingTaskTest (#12735)
Reviewers: Divij Vaidya <divijvaidya13@gmail.com>, Chris Egerton <chrise@aiven.io>
2022-12-21 11:41:03 -05:00
Mickael Maison 429a2570b0
MINOR: Don't throw if MirrorMaker topics already exist (#13005)
Reviewers: Luke Chen <showuon@gmail.com>
2022-12-20 14:33:32 +01:00
Chris Egerton dd76872264
KAFKA-13709: Add docs for exactly-once support in Connect (#12941)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2022-12-15 11:20:49 -05:00
Greg Harris 526af63cfe
KAFKA-13881: Add Connect package infos (#12937)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-12-13 09:39:10 -05:00
Greg Harris 83732489ab
KAFKA-14443: Close topic creation Admin clients in MM2 connectors (#12955)
Reviewers: Omnia G H Ibrahim <o.g.h.ibrahim@gmail.com>, Chris Egerton <chrise@aiven.io>
2022-12-07 16:59:46 -05:00
Yash Mayya b6fb95e4c4
KAFKA-14342: Clear offsets for connector source partitions on tombstone messages (#12800)
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <chrise@aiven.io>
2022-12-06 09:25:41 -05:00
Patrik Marton 1c10d107fe
KAFKA-14293: Basic Auth filter should set the SecurityContext after a successful login (#12846)
Reviewers: Greg Harris <greg.harris@aiven.io>, Chris Egerton <chrise@aiven.io>
2022-12-05 09:38:40 -05:00
Mickael Maison 8bb89c4beb
MINOR: Fix compilation issue in FileStreamSourceConnector (#12938)
Fix compilation failure introduced in https://github.com/apache/kafka/pull/12355.

Reviewers: Mickael Maison <mickael.maison@gmail.com>
2022-12-01 13:01:12 -08:00
Chris Egerton e11b515ef3
KAFKA-14017: Implement new KIP-618 APIs in FileStreamSourceConnector (#12355)
Reviewers: Yash Mayya <yash.mayya@gmail.com>,  Maison <mickael.maison@gmail.com>
2022-12-01 11:20:55 -05:00
Mickael Maison 40af3a7450
KAFKA-14413: Separate MirrorMaker configurations for each connector (#12899)
Reviewers: Luke Chen <showuon@gmail.com>, Chris Egerton <fearthecellos@gmail.com>, Christo Lolov  <christo_lolov@yahoo.com>
2022-11-30 18:37:37 +01:00
Chris Egerton 548348c9e7
KAFKA-13731: Allow standalone workers to be started without providing any connector configurations (#11890)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Mickael Maison <mickael.maison@gmail.com>
2022-11-30 11:49:24 -05:00
Greg Harris 3799125c2f
KAFKA-14339 : Do not perform producerCommit on serializationError when trying offsetWriter flush (#12920)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-11-29 19:06:30 -05:00
Greg Harris d3ee9341cc
KAFKA-12476: Prevent herder tick thread from sleeping excessively after slow operations (#12876)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-11-29 09:40:39 -05:00
Greg Harris cc77a38d28
KAFKA-12610: Implement PluginClassLoader::getResource and getResources (#12805)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-11-23 08:37:51 -05:00
Dan Stelljes 93dd6ce21a
KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder (#12295)
Reviewers: Kvicii <kvicii.yu@gmail.com>, Chris Egerton <chrise@aiven.io>
2022-11-18 09:49:52 -05:00
Greg Harris 31c69ae932
KAFKA-14346: Remove hard-to-mock javax.crypto calls (#12866)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-11-17 18:10:17 -05:00
Greg Harris fca5bfe13c
KAFKA-14346: Remove hard-to-mock RestClient calls (#12828)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-11-17 17:51:54 -05:00
Greg Harris 7a93d5c833
KAFKA-14346: Replace static mocking of WorkerConfig::lookupKafkaClusterId (#12839)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2022-11-17 10:32:39 +01:00
David Jacot c2fc36f331
MINOR: Handle JoinGroupResponseData.protocolName backward compatibility in JoinGroupResponse (#12864)
This is a small refactor extracted from https://github.com/apache/kafka/pull/12845. It basically moves the logic to handle the backward compatibility of `JoinGroupResponseData.protocolName` from `KafkaApis` to `JoinGroupResponse`.

The patch adds a new unit test for `JoinGroupResponse` and relies on existing tests as well.

Reviewers: Justine Olshan <jolshan@confluent.io>, Jason Gustafson <jason@confluent.io>
2022-11-16 12:43:00 -08:00
Christo Lolov 1894856d0e
KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest (#12418)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-11-15 16:30:52 -05:00
vamossagar12 09da44ed80
KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance (#12561)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Luke Chen <showuon@gmail.com>, Chris Egerton <chrise@aiven.io>
2022-11-15 16:26:21 -05:00
Omnia G H Ibrahim 46bee5bcf3
KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation. (#12577)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Tom Bentley <tombentley@users.noreply.github.com>

Co-authored-by: Tom Bentley <tombentley@users.noreply.github.com>
Co-authored-by: oibrahim3 <omnia@apple.com>
2022-11-15 11:21:24 +01:00
Chris Egerton bb84476215
KAFKA-14098: Add meaningful client IDs for Connect workers (#12544)
Reviewers: Greg Harris <greg.harris@aiven.io>, Mickael Maison <mickael.maison@gmail.com>
2022-11-08 10:22:30 -05:00
Christo Lolov 4af5dae05c
KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests (#12823)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-11-07 11:34:55 -05:00
Greg Harris 98ed31c95b
KAFKA-14346: Remove difficult to mock Plugins.compareAndSwapLoader usages (#12817)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-11-07 09:37:24 -05:00
Omnia G H Ibrahim 9608f3a2e7
KAFKA-14344: Build EmbeddedKafkaCluster with common configs used for all clients (#12804)
Reviewers: Mickael Maison <mickael.maison@gmail.com>

, Tom Bentley <tbentley@redhat.com>
2022-11-07 11:11:16 +01:00
Chris Egerton 14c36c7539
KAFKA-14058: Migrate ExactlyOnceWorkerSourceTaskTest from EasyMock and Powermock to Mockito (#12409)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2022-11-03 12:42:08 -04:00
Matthew de Detrich 9ab140d541
KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest (#12725)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-10-31 20:08:41 -04:00
Greg Harris 98bf375b6f
KAFKA-13989: Errors while evaluating connector type should return UNKNOWN (#12789)
Reviewers: Igor Soarez <i@soarez.me>, Chris Egerton <chrise@aiven.io>
2022-10-31 16:54:32 -04:00
Greg Harris f7304db6d2
KAFKA-14338: Use MockTime in RetryUtilTest to eliminate flakiness (#12791)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-10-29 06:38:24 -04:00
(+ (* 1 2 3 4) 5 6 7) 61f48a9f63
KAFKA-14314: Add check for null upstreamTopic (#12769)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
Co-authored-by: John Krupka <john.krupka@united.com>
2022-10-28 17:28:26 +02:00
Chris Egerton 18e60cb000
KAFKA-12497: Skip periodic offset commits for failed source tasks (#10528)
Also moves the Streams LogCaptureAppender class into the clients module so that it can be used by both Streams and Connect.

Reviewers: Nigel Liang <nigel@nigelliang.com>, Kalpesh Patel <kpatel@confluent.io>, John Roesler <vvcephei@apache.org>, Tom Bentley <tbentley@redhat.com>
2022-10-13 10:15:42 -04:00
Alexandre Garnier 62914129c7
KAFKA-14099 - Fix request logging in connect (#12434)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-10-12 10:28:55 -04:00
Ramesh a6b60e7cf3
KAFKA-12965 - Graceful clean up of task error metrics (#10910)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-10-12 09:59:52 -04:00
Matthew de Detrich ba0f105e2f
MINOR: Use LEADER_URL variable in ConnectorsResourceTest (#12722)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-10-07 10:18:31 -04:00
Matthew de Detrich de05665876
KAFKA-14283: Fix connector creation Auth tests (#12721)
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <chrise@aiven.io>
2022-10-07 10:14:15 -04:00
Divij Vaidya 9b2e290423
KAFKA-14132: Replace PowerMock/Easymock with Mockito for WorkerMetricsGroupTest (#12677)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-09-23 16:14:09 -04:00
Jordan Bull 8ddc9509cf
KAFKA-13927: Fix sink task offset tracking during exception retries (#12566)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-09-20 13:46:35 -04:00
Federico Valeri 6d463c1733
MINOR: Update offset.storage.topic description (#12656)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-09-19 13:21:59 -04:00
Rens Groothuijsen b09cadcaa7
KAFKA-13985: Skip committing MirrorSourceTask records without metadata (#12602)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-09-15 09:55:44 -04:00
Yash Mayya bdf2cdb27f
KAFKA-14132: Migrate some Connect tests from EasyMock/PowerMock to Mockito (#12615)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-09-14 11:00:32 -04:00
Nandini Anagondi 21eae2f29a
MINOR: Use MessageDigest equals when comparing signature (#11516)
The motivation for this change is to guard against timing attacks when using InternalRequestSignature.equals()

Pros of this PR

    if the InternalRequestSignature.equal() method could be used for a timing attack, then this PR fixes a security vulnerability

Cons of this PR

    MessageDigest.isEquals() is slower than Arrays.equal since the former is time constant i.e. it runs for a fixed time irrespective of the length of original signature. The execution time of MessageDigest.isEquals() is a function of length of the byte array that it is being tested against.

Even if InternalRequestSignature.equals() is not being used anywhere in code today where it may cause a timing attack, we should still guard against the possibility where a future change might start using it (especially in an open source project where changes might be contributed & reviewed by multiple group of people). The downside of slower equality comparison over a signature is risk worth accepting given the upside we get to safeguard future use cases.

Co-authored-by: Nandini Krishna Anagondi <nandini@mac.local>

Reviewers: Luke Chen <showuon@gmail.com>, Divij Vaidya <diviv@amazon.com>,  Karan Kumar <karankumar1100@gmail.com>, Andrew Eugene Choi <andrew.choi@uwaterloo.ca>
2022-09-14 21:06:43 +08:00
Divij Vaidya d4fc3186b4
MINOR: Replace usage of File.createTempFile() with TestUtils.tempFile() (#12591)
Why
Current set of integration tests leak files in the /tmp directory which makes it cumbersome if you don't restart the machine often.

Fix
Replace the usage of File.createTempFile with existing TestUtils.tempFile method across the test files. TestUtils.tempFile automatically performs a clean up of the temp files generated in /tmp/ folder.

Reviewers: Luke Chen <showuon@gmail.com>, Ismael Juma <mlists@juma.me.uk>
2022-09-13 08:44:21 +08:00
Chris Egerton 897bf4741c
KAFKA-14143: Exactly-once source connector system tests (#11783)
Also includes a minor quality-of-life improvement to clarify why some internal REST requests to workers may fail while that worker is still starting up.

Reviewers: Tom Bentley <tbentley@redhat.com>, Luke Chen <showuon@gmail.com>, José Armando García Sancio <jsancio@gmail.com>, Mickael Maison <mickael.maison@gmail.com>
2022-09-08 15:13:43 -04:00
Yash Mayya 0c97be53fa
KAFKA-13952 fix RetryWithToleranceOperator to respect infinite retries configuration (#12478)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-09-08 10:14:04 -04:00
Yash Mayya 9b947a5ca3
MINOR: Fix usage of @see in IncrementalCooperativeAssignor doc comments (#12606)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2022-09-08 11:27:06 +02:00
Yash Mayya c359558826
KAFKA-14015: Reconfigure tasks if configs have been changed for restarted connectors in standalone mode(#12568)
Reviewers: Chris Egerton <chrise@aiven.io>
2022-09-06 09:05:21 -04:00
Mickael Maison d606eb46ef
MINOR: Small javadoc/code cleanups in connect api and transforms (#12558)
Reviewers: Luke Chen <showuon@gmail.com>, Divij Vaidya <diviv@amazon.com>
2022-08-29 09:44:56 +02:00
Mickael Maison 0507597597
KAFKA-10360: Allow disabling JMX Reporter (KIP-830) (#12046)
This implements KIP-830: https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter
It adds a new configuration `auto.include.jmx.reporter` that can be set to false to disable the JMX Reporter. This configuration is deprecated and will be removed in the next major version.

Reviewers: Tom Bentley <tbentley@redhat.com>, Christo Lolov <christo_lolov@yahoo.com>
2022-08-24 18:30:31 +02:00
Divij Vaidya 4b310d1fe1
KAFKA-13133: Replace EasyMock and PowerMock with Mockito for AbstractHerderTest (#12473)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Yash Mayya <yash.mayya@gmail.com>

Co-authored-by: wycccccc <493172422@qq.com>
Co-authored-by: wycccccc <43372856+wycccccc@users.noreply.github.com>
2022-08-23 17:49:38 +02:00
Mickael Maison 4bd3fd840d
KAFKA-14160: Streamline clusterId retrieval in Connect (#12536)
Cache the Kafka cluster Id once it has been retrieved to avoid creating many Admin clients at startup.

Reviewers: Chris Egerton <fearthecellos@gmail.com>
2022-08-23 17:09:22 +02:00
Yash Mayya 6df57679d0
KAFKA-14162: Stop adding immutable maps/lists to record keys/values in HoistField and MaskField SMTs (#12502)
Reviewers:  Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <fearthecellos@gmail.com>
2022-08-23 10:22:02 -04:00
Yash Mayya ddb7fdd88f
KAFKA-14133: Replace EasyMock with Mockito in WorkerCoordinatorTest and RootResourceTest (#12509)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Dalibor Plavcic <dalibor.os@proton.me>
2022-08-22 20:17:34 +02:00
Yash Mayya 519d8ac5b9
KAFKA-14147: Prevent deferredTaskUpdates map from growing monotonically in KafkaConfigBackingStore (#12490)
Reviewers: Chris Egerton <fearthecellos@gmail.com>
2022-08-22 10:13:43 -04:00
Chris Egerton 73e8d5dd5b
MINOR: Remove unused ShutdownableThread class and ineffective ThreadedTest class (#12410)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Christo Lolov <christo_lolov@yahoo.com>
2022-08-18 12:08:03 +02:00
Kvicii d8e93c368d
KAFKA-13971:Atomicity violations caused by improper usage of ConcurrentHashMap (#12277)
Reviewers: Divij Vaidya <diviv@amazon.com>, Chris Egerton <fearthecellos@gmail.com>
2022-08-17 12:32:24 -04:00
Yash Mayya 18142bff4b
KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors (#12450)
Reviewers: Chris Egerton <fearthecellos@gmail.com>
2022-08-15 15:25:29 -04:00
Divij Vaidya 9a3a34cab0
KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest.java (#12484)
This PR is created on top of #10904 and includes commits from original author for attribution. 

## Testing
1. `./gradlew connect:runtime:unitTest --tests WorkerGroupMemberTest` is successful.
2. Verified that test is run as part of `./gradlew connect:runtime:unitTest` (see report in the PR)

Reviewers: Ismael Juma <ismael@juma.me.uk>

Co-authored-by: Chun-Hao Tang <tang7526@gmail.com>
2022-08-10 06:45:07 -07:00
Yash Mayya 465d8fa94f
KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest (#12472)
Reviewers: Divij Vaidya <diviv@amazon.com>, Chris Egerton <fearthecellos@gmail.com>
2022-08-09 10:10:47 -04:00
venkatteki a02c8d336a
KAFKA-13546: Do not fail connector validation if default topic creation group is explicitly specified (#11615)
Reviewers: Chris Egerton <fearthecellos@gmail.com>
2022-08-02 14:03:57 -04:00