Commit Graph

1103 Commits

Author SHA1 Message Date
Greg Harris b40b5a24f4
KAFKA-17369: Remove Reflections from logging and update licenses (#16924)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
2024-08-19 16:27:36 -07:00
Steven Xu e24354a21d
KAFKA-15203: Use Classgraph since org.reflections is no longer under maintenance (#16604)
Reviewers: Liam Miller-Cushon <cushon@google.com>, Greg Harris <greg.harris@aiven.io>
2024-08-19 10:46:24 -07:00
Dmitry Werner 4763d0fc30
KAFKA-17242: Do not log spurious timeout message for MirrorCheckpointTask sync store startup (#16773)
Reviewers: Chris Egerton <chrise@aiven.io>
2024-08-08 10:03:42 -04:00
TengYao Chi 0dc74c5556
KAFKA-17232: Do not generate task configs in MirrorCheckpointConnector if initial consumer group load times out (#16767)
Reviewers: Hongten <hongtenzone@foxmail.com>, Chris Egerton <chrise@aiven.io>
2024-08-08 09:58:11 -04:00
Chris Egerton 8152ee6519
MINOR: Increase test producer max.block.ms in MirrorConnectorsIntegrationTransactionsTest (#16785)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-08-05 14:37:17 -04:00
Chris Egerton 3f3e376797
MINOR: Fix stage recording in DistributedHerder::addRequest (#16784)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-08-05 14:36:39 -04:00
Chris Egerton 39b1586f93
MINOR: Fix ConnectWorkerIntegrationTest::testRequestTimeouts (#16772)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-08-02 16:41:34 -04:00
Chris Egerton 5afdb17092
MINOR: Fix consumer group warmup in MirroMaker 2 integration tests (#16771)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-08-02 13:57:05 -04:00
Chris Egerton a524609f4c
MINOR: Add extended cluster readiness check for Connect's embedded Kafka cluster (#16757)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-08-01 16:12:57 -04:00
Kondrat Bertalan 8d8c367066
KAFKA-17192 Fix MirrorMaker2 worker config does not pass config.provi… (#16678)
Reviewers: Chris Egerton <chrise@aiven.io>
2024-07-31 16:50:22 -04:00
Chris Egerton 342bd2844f
MINOR: Unify Log4j levels across Connect runtime and MirrorMaker 2 integration tests (#16733)
Reviewers: Yash Mayya <yash.mayya@gmail.com>
2024-07-31 12:07:38 +02:00
Chung, Ming-Yen 7c0a96d08d
KAFKA-17185 Declare Loggers as static to prevent multiple logger instances (#16680)
As discussed in #16657 (comment) , we should make logger as static to avoid creating multiple logger instances.
I use the regex private.*Logger.*LoggerFactory to search and check all the results if certain logs need to be static.

There are some exceptions that loggers don't need to be static:
1) The logger in the inner class. Since java8 doesn't support static field in the inner class.
        https://github.com/apache/kafka/blob/trunk/clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java#L3676

2) Custom loggers for each instance (non-static + non-final). In this case, multiple logger instances is actually really needed.
        https://github.com/apache/kafka/blob/trunk/storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorage.java#L166

3) The logger is initialized in constructor by LogContext. Many non-static but with final modifier loggers are in this category, that's why I use .*LoggerFactory to only check the loggers that are assigned initial value when declaration.
    
4) protected final Logger log = Logger.getLogger(getClass())
    This is for subclass can do logging with subclass name instead of superclass name.
    But in this case, if the log access modifier is private, the purpose cannot be achieved since subclass cannot access the log defined in superclass. So if access modifier is private, we can replace getClass() with <className>.class

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-07-31 02:37:36 +08:00
Chris Egerton 61f61d6240
KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode (#16599)
Reviewers: Omnia Ibrahim <o.g.h.ibrahim@gmail.com>, Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
2024-07-29 10:43:55 -04:00
PaulRMellor 738d8cc91e
MINOR: Update bootstrap.servers doc string (#16655)
Reviewers: Mickael Maison <mickael.maison@gmail.com>
2024-07-26 15:08:01 +02:00
Chris Egerton 956d740c46
KAFKA-16068: Use TestPlugins mechanism in ConnectorValidationIntegrationTest to prevent ERROR-level log spam in unrelated test suites (#16647)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-07-23 13:15:03 -04:00
PoAn Yang defcbb51ee
KAFKA-17082 replace kafka.utils.LogCaptureAppender with org.apache.kafka.common.utils.LogCaptureAppender (#16601)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-07-21 18:22:05 +08:00
Chris Egerton 208bb1fbc2
MINOR: Add integration test for plugin aliases (#16621)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-07-19 12:47:41 -04:00
Greg Harris c97421c100
KAFKA-17150: Use Utils.loadClass instead of Class.forName to resolve aliases correctly (#16608)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Chris Egerton <chrise@aiven.io>, Chia-Ping Tsai <chia7712@gmail.com>, Josep Prat <josep.prat@aiven.io>
2024-07-17 16:00:45 -07:00
Chris Egerton 53ec055394
KAFKA-17105: Prevent redundant restarts for newly-created connectors (#16581)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-07-17 14:33:47 -04:00
Chris Egerton 177b38ad66
KAFKA-16383: Ensure tasks have already polled their consumers before producing verified records in MirrorConnectorsIntegrationBaseTest::testReplicateFromLatest (#16598)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-07-16 19:42:31 -04:00
Zhengke Zhou 6cffed56f6
KAFKA-16943: Synchronously verify Connect worker startup failure in InternalTopicsIntegrationTest (#16451)
Reviewers: Chris Egerton <chrise@aiven.io>
2024-07-16 14:20:44 -04:00
vamossagar12 808498e939
KAFKA-14401: Fail kafka log read end requests if underneath work thread fails (#14372)
Reviewers: Chris Egerton <chrise@aiven.io>
2024-07-15 20:55:52 -04:00
PoAn Yang 6e9c039eea
KAFKA-17097 Add replace.null.with.default configuration to ValueToKey and ReplaceField (#16571)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-07-15 18:12:59 +08:00
Chris Egerton 83081652ab
MINOR: Fix ConnectWorkerIntegrationTest::testBrokerCoordinator (#16585)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-07-13 03:48:19 -04:00
Vikas Balani 3f43d27483
KAFKA-17111: explicitly register Afterburner module in JsonSerializer and JsonDeserializer (#16565)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Josep Prat <josep.prat@aiven.io>, Greg Harris <greg.harris@aiven.io>
2024-07-11 14:17:27 +02:00
Omnia Ibrahim 0781151794
KAFKA-16254: Allow MM2 to fully disable offset sync feature (#15999)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chris Egerton <fearthecellos@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>, Igor Soarez <soarez@apple.com>
2024-07-09 12:38:03 +02:00
Chris Egerton 515cdbb707
MINOR: Fix retry logic in DedicatedMirrorIntegrationTest::awaitTaskConfigurations (#16525)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-07-08 14:51:23 -04:00
Fiore Mario Vitale e2ec389a7c
KAFKA-15838: KIP-1040: Add replace.null.with.default to InsertField, ExtractField, HeaderFrom, Cast, SetSchemaMetadata, TimestampConverter, MaskField transforms (#15756)
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Greg Harris <greg.harris@aiven.io>
2024-07-08 11:09:54 -07:00
Chris Egerton 27220d146c
KAFKA-10816: Add health check endpoint for Kafka Connect (#16477)
Reviewers: Greg Harris <gharris1727@gmail.com>
2024-07-03 14:15:15 -04:00
Greg Harris 4550550c7c
MINOR: Cleanup TestPlugins and normalize TestPlugin enum (#13333)
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Chris Egerton <chrise@aiven.io>
2024-07-03 09:44:09 -07:00
Chris Egerton e93242283d
KAFKA-15917: Wait for zombie sink tasks' consumers to commit offsets before trying to modify their offsets in integration tests (#15302)
Reviewers: Yash Mayya <yash.mayya@gmail.com>, Greg Harris <greg.harris@aiven.io>
2024-07-03 10:25:23 -04:00
abhi-ksolves 6897b06b03
KAFKA-3346 Rename Mode to ConnectionMode (#16403)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-07-03 02:46:04 +08:00
PoAn Yang 645eefe95a
KAFKA-17007 Fix SourceAndTarget#equal (#16416)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-21 20:52:07 +08:00
Mickael Maison 0772144e51
MINOR: Add javadoc for Connect public packages/classes (#16404)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-21 10:23:35 +02:00
gongxuanzhang 8d92535382
KAFKA-10787 apply spotless to connect:runtime module (#16412)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-21 16:04:51 +08:00
Ken Huang 4de6a90801
KAFKA-16921 [6/N] Remove junit 4 dependency from connect:runtime module (#16383)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-19 14:39:16 +08:00
TingIāu "Ting" Kì d5592d8fe6
KAFKA-16921 [5/N] Migrate test of connect module to Junit5 (Runtime subpackage) (#16350)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-18 18:20:14 +08:00
gongxuanzhang 3a3f9ce48e
KAFKA-16921 [4/N] Migrate test of connect module to Junit5 (Runtime direct) (#16351)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-18 18:09:40 +08:00
Ken Huang fc6f8b6591
KAFKA-16921 [3/N] migrate connect module to junit 5 (#16330)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-15 00:37:59 +08:00
PoAn Yang 8682334b6a
KAFKA-16921 [2/N] migrate connect module to junit 5 (#16328)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-15 00:25:41 +08:00
dujian0068 133f2b0f31
KAFKA-16879 SystemTime should use singleton mode (#16266)
Reviewers: Greg Harris <gharris1727@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
2024-06-14 08:49:19 +08:00
abhi-ksolves 6af937639d
KAFKA-16076 Fix Missing thread interrupt call in RestClient class (#16282)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-14 08:07:13 +08:00
Ken Huang ea60666513
KAFKA-16921 [1/N] Migrate all junit 4 code to junit 5 for connect module (#16253)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-13 16:11:37 +08:00
gongxuanzhang 596b945072
KAFKA-16643 Add ModifierOrder checkstyle rule (#15890)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-13 15:39:32 +08:00
Chris Egerton 9ddd58bd6c
MINOR: Add readiness check for connector and separate Kafka cluster in ExactlyOnceSourceIntegrationTest::testSeparateOffsetsTopic (#16306)
Reviewers: Greg Harris <gharris1727@gmail.com>
2024-06-12 23:43:33 -04:00
Chris Egerton e76e1da5ea
KAFKA-16935: Automatically wait for cluster startup in embedded Connect integration tests (#16288)
Reviewers: Greg Harris <gharris1727@gmail.com>
2024-06-12 20:18:23 -04:00
Ivan Yurchenko dd755b7ea9
KAFKA-8206: KIP-899: Allow client to rebootstrap (#13277)
This commit implements KIP-899: Allow producer and consumer clients to rebootstrap. It introduces the new setting `metadata.recovery.strategy`, applicable to all the types of clients.

Reviewers: Greg Harris <gharris1727@gmail.com>, Rajini Sivaram <rajinisivaram@googlemail.com>
2024-06-12 20:48:32 +01:00
gongxuanzhang 79b9c44acd
KAFKA-10787 Apply spotless to connect module (#16299)
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
2024-06-12 22:19:47 +08:00
Chris Egerton 2fa2c72581
MINOR: Wait for embedded clusters to start before using them in Connect OffsetsApiIntegrationTest (#16286)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-06-11 17:15:07 -04:00
Chris Egerton ac2a642ba9
MINOR: Fix flaky test ConnectWorkerIntegrationTest::testReconfigureConnectorWithFailingTaskConfigs (#16273)
Reviewers: Greg Harris <greg.harris@aiven.io>
2024-06-11 15:13:35 -04:00