Test sends large request using multiple writes of length followed by request body. The first write should succeed, but since the server closes the connection on processing the length that is too big, subsequent writes may fail. Modified test to handle this exception.
Author: Rajini Sivaram <rajinisivaram@googlemail.com>
Reviewers: Ismael Juma <ismael@juma.me.uk>
Closes#1349 from rajinisivaram/KAFKA-3662
(cherry picked from commit bce3415b18)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Add references to the new consumer property 'max.partition.fetch.bytes' along with the old consumer property 'fetch.message.max.bytes' in the corresponding warning messages of TopicCommand.
Also, create and leverage a static variable for the default value of the new consumer property.
Also, use 'DEFAULT_...' for default propoerty constant names in the code instead of '..._DEFAULT'.
Author: Vahid Hashemian <vahidhashemian@us.ibm.com>
Reviewers: Manikumar reddy O <manikumar.reddy@gmail.com>, Ashish Singh <asingh@cloudera.com>, Grant Henke <granthenke@gmail.com>, Ismael Juma <ismael@juma.me.uk>
Closes#1239 from vahidhashemian/KAFKA-3579
(cherry picked from commit 62b9fa2254)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Author: Ismael Juma <ismael@juma.me.uk>
Reviewers: Jun Rao <junrao@gmail.com>
Closes#1338 from ijuma/kafka-3670-controlled-shutdown-leader-selector-preferred-replica
(cherry picked from commit 51f7a35c92)
Signed-off-by: Jun Rao <junrao@gmail.com>
This contribution is my original work and I license the work under Apache 2.0.
Author: Dana Powers <dana.powers@gmail.com>
Author: Ismael Juma <ismael@juma.me.uk>
Reviewers: Jun Rao <junrao@gmail.com>, Ismael Juma <ismael@juma.me.uk>
Closes#1212 from dpkp/KAFKA-3160
(cherry picked from commit 8fe2552239)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
so that unresolvable DNS names are ignored and only throw an error if no other bootstrap servers are resolvable.
Author: Jonathan Bond <jbond@netflix.com>
Reviewers: Ewen Cheslack-Postava <me@ewencp.org>, Grant Henke <granthenke@gmail.com>, Ismael Juma <ismael@juma.me.uk>
Closes#792 from bondj/KAFKA-3112
(cherry picked from commit c4bbf34243)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Author: Chen Zhu <amandazhu19620701@gmail.com>
Reviewers: Ismael Juma <ismael@juma.me.uk>
Closes#1315 from zhuchen1018/KAFKA-3655
(cherry picked from commit 717eea8350)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
…value for doLog
Author: Mark Grover <mark@apache.org>
Reviewers: Grant Henke <granthenke@gmail.com>, Ismael Juma <ismael@juma.me.uk>
Closes#1334 from markgrover/kafka-3669-trunk
(cherry picked from commit 58f9d7cf8a)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
This patch adds logic for the following:
- remove hard-coded paths to various scripts and jars in kafkatest service classes
- provide a mechanism for overriding path resolution logic with a "pluggable" path resolver class
Author: Geoff Anderson <geoff@confluent.io>
Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>
Closes#1245 from granders/configurable-install-path
(cherry picked from commit 54092c12ed)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
Pull request to update the consumer API links in the docs.
Author: Dustin Cote <dustin@dustins-mbp.attlocal.net>
Reviewers: Ismael Juma <ismael@juma.me.uk>
Closes#1331 from cotedm/KAFKA-3666
(cherry picked from commit 78de891ace)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Author: Guozhang Wang <wangguoz@gmail.com>
Reviewers: Stig Døssing, Ismael Juma, Jun Rao
Closes#1327 from guozhangwang/K725r
(cherry picked from commit 4a076a03be)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
Whenever the BufferPool throws a "Failed to allocate memory within the configured max blocking time" exception, it should also remove the condition object from the waiters deque
Author: MayureshGharat <gharatmayuresh15@gmail.com>
Reviewers: Chen Zhu <amandazhu19620701@gmail.com>, Ismael Juma <ismael@juma.me.uk>
Closes#1314 from MayureshGharat/kafka-3651
(cherry picked from commit 6856c5c214)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
AbstractPartitionAssignor.assign has an ambiguous line in its documentation:
> param partitionsPerTopic The number of partitions for each subscribed topic (may be empty for some topics)
Does empty mean the topic has an entry with value zero, or that the entry is excluded from the map altogether? The current implementation in AbstractPartitionAssignor excludes the entry from partitionsPerTopic if the topic isn't in the metadata.
RoundRobinAssignorTest.testOneConsumerNonexistentTopic interprets emptiness as providing the topic with a zero value.
RangeAssignor interprets emptiness as excluding the entry from the map.
RangeAssignorTest.testOneConsumerNonexistentTopic interprets emptiness as providing the topic with a zero value.
This implementation chooses to solve the NPE by deciding to exclude topics from partitionsPerTopic when the topic is not in the metadata.
Author: Onur Karaman <okaraman@linkedin.com>
Reviewers: Jason Gustafson <jason@confluent.io>, Ismael Juma <ismael@juma.me.uk>
Closes#1326 from onurkaraman/KAFKA-3661
(cherry picked from commit 8429db937e)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Author: Eno Thereska <eno.thereska@gmail.com>
Reviewers: Ismael Juma, Guozhang Wang
Closes#1324 from enothereska/hotfix-timeouts
(cherry picked from commit 7f4e3ccde8)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
This actually removes joins altogether, as well as references to self.worker_threads, which is best left as an implementation detail in BackgroundThreadService.
This makes use of hachikuji 's recent ducktape patch, and updates ducktape dependency to 0.5.0.
Author: Geoff Anderson <geoff@confluent.io>
Reviewers: Jason Gustafson <jason@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>
Closes#1297 from granders/KAFKA-3581-systest-add-join-timeout
(cherry picked from commit b6cd0e2791)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
Handle unsupported version of ApiVersionsRequest during SASL auth as well as normal operation by returning an error response.
Author: Rajini Sivaram <rajinisivaram@googlemail.com>
Reviewers: Ismael Juma <ismael@juma.me.uk>, Jun Rao <junrao@gmail.com>
Closes#1310 from rajinisivaram/KAFKA-3652
(cherry picked from commit 64451af9e0)
Signed-off-by: Jun Rao <junrao@gmail.com>
Author: Guozhang Wang <wangguoz@gmail.com>
Reviewers: Michael G. Noll <michael@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Ismael Juma <ismael@juma.me.uk>
Closes#1311 from guozhangwang/K3639
(cherry picked from commit c8c6ac3f6d)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Author: William Thurston <wthurston@linkedin.com>
Author: Ismael Juma <ismael@juma.me.uk>
Reviewers: Ismael Juma, Guozhang Wang
Closes#1318 from ijuma/KAFKA-2236-offset-request-reply-segment-rolling-race
(cherry picked from commit c46cc48021)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
Author: Eno Thereska <eno.thereska@gmail.com>
Reviewers: Ismael Juma, Michael G. Noll, Guozhang Wang
Closes#1285 from enothereska/more-integration-tests
Author: Jason Gustafson <jason@confluent.io>
Reviewers: Ismael Juma <ismael@juma.me.uk>
Closes#1312 from hachikuji/KAFKA-3632
(cherry picked from commit 7a0821d653)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Author: Ewen Cheslack-Postava <me@ewencp.org>
Reviewers: Ismael Juma <ismael@juma.me.uk>
Closes#1316 from ewencp/minor-handle-null-values-validators
(cherry picked from commit 03a1f7d39c)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
`maxTimeToBlock` needs to be updated in each loop iteration. Also record waitTime before throwing `TimeoutException`
Author: Chen Zhu <amandazhu19620701@gmail.com>
Reviewers: Dong Lin <lindong28@gmail.com>, Ismael Juma <ismael@juma.me.uk>
Closes#1304 from zhuchen1018/KAFKA-3648
(cherry picked from commit 94e12a2e1f)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Author: Liquan Pei <liquanpei@gmail.com>
Reviewers: Jason Gustafson <jason@confluent.io>, Ismael Juma <ismael@juma.me.uk>
Closes#1306 from Ishiihara/minor-consumer-cleanup
(cherry picked from commit af01378843)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
When an address is written textually, the zone index is appended to the address, separated by a percent sign (%). The actual syntax of zone indices depends on the operating system.
Author: Som Sahu <sosahu@microsoft.com>
Author: Soumyajit Sahu <soumyajit-sahu@users.noreply.github.com>
Reviewers: Ismael Juma <ismael@juma.me.uk>
Closes#1305 from soumyajit-sahu/fixIPV6RegexPattern_trunk
(cherry picked from commit 88e5d5a9a1)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Also:
* Remove redundant `time.milliseconds` call in `Sensor.record`
* Clean-up a number of tests and remove a manual test that is no longer required
Author: Ismael Juma <ismael@juma.me.uk>
Reviewers: Liquan Pei <liquanpei@gmail.com>, Jun Rao <junrao@gmail.com>
Closes#1265 from ijuma/kafka-3128-zookeeper-metrics
(cherry picked from commit c7425be5be)
Signed-off-by: Jun Rao <junrao@gmail.com>
Documentation corresponding to KIP-43 - SASL/PLAIN and multiple mechanism support.
Author: Rajini Sivaram <rajinisivaram@googlemail.com>
Reviewers: Magnus Edenhill <apache_m@edenhill.se>, Jun Rao <junrao@gmail.com>
Closes#1232 from rajinisivaram/KAFKA-3517
(cherry picked from commit abac51dc0b)
Signed-off-by: Jun Rao <junrao@gmail.com>
Recent patch adding enable-systest-events flag without any version check breaks all uses of versioned console consumer. E.g. upgrade tests, compatibility tests etc.
Added a check to only apply the flag if running 0.10.0 or greater.
Author: Geoff Anderson <geoff@confluent.io>
Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>
Closes#1298 from granders/minor-systest-fix-versioned-console-consumer
(cherry picked from commit 5c47b9f80e)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
bin/kafka-run-class.sh does not correctly setup the CLASSPATH in release rc2.
Author: Dana Powers <dana.powers@gmail.com>
Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>
Closes#1302 from dpkp/KAFKA-3615-fix
(cherry picked from commit 1e4dd66b19)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
Fixes wrong KeyValue equals logic when keys not equal but values equal.
Original hotfix PR at https://github.com/apache/kafka/pull/1293 (/cc enothereska)
Please review: ewencp ijuma guozhangwang
Author: Eno Thereska <eno.thereska@gmail.com>
Author: Michael G. Noll <michael@confluent.io>
Reviewers: Michael G. Noll <michael@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>
Closes#1294 from miguno/KeyValue-equality-hotfix
(cherry picked from commit 60380e31d4)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
hachikuji ewencp Can you take a look when you have time?
Author: Liquan Pei <liquanpei@gmail.com>
Reviewers: Jason Gustafson <jason@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>
Closes#1248 from Ishiihara/kafka-3459
- add class doc for KTable, KStream, JoinWindows
- add missing return tags
Author: Matthias J. Sax <matthias@confluent.io>
Reviewers: Guozhang Wang <wangguoz@gmail.com>, Michael G. Noll <michael@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>
Closes#1287 from mjsax/kafka-3440-JavaDoc
Server-side implementation and tests for handling ApiVersionsRequest before SaslHandshakeRequest.
Author: Rajini Sivaram <rajinisivaram@googlemail.com>
Reviewers: Gwen Shapira, Ismael Juma
Closes#1286 from rajinisivaram/KAFKA-3618
Even if a test calls stop() on console_consumer or verifiable_producer, it is still possible that producer/consumer will not shutdown cleanly, and will be killed forcefully after a timeout. It will be useful for some tests to know whether a clean shutdown happened or not. This PR adds methods to console_consumer and verifiable_producer to query whether clean shutdown happened or not.
hachikuji and/or granders Please review.
Author: Anna Povzner <anna@confluent.io>
Reviewers: Jason Gustafson, Geoff Anderson, Gwen Shapira
Closes#1278 from apovzner/kafka-3597
granders hachikuji Can you take a look when you have time? Appreciate your time to review.
Author: Liquan Pei <liquanpei@gmail.com>
Reviewers: Grant Henke <granthenke@gmail.com>, Geoff Anderson <geoff@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>
Closes#1263 from Ishiihara/classpath-no-test-jar
Rajini Sivaram
Ismael Juma
Jason Gustafson
Liquan Pei
Vahid Hashemian
Dana Powers
Jonathan Bond
Chen Zhu
Mark Grover
Geoff Anderson
Yuto Kawamura
Dustin Cote
Guozhang Wang
Mayuresh Gharat
Onur Karaman
Eno Thereska
William Thurston
Ewen Cheslack-Postava
Som Sahu
dan norwood
Gwen Shapira
Grant Henke
Matthias J. Sax
Anna Povzner