mirror of https://github.com/apache/kafka.git
e6db0ca48c
In v3.0, we changed the default value for `enable.idempotence` to true, but we didn't adjust the validator and the `idempotence` enabled check method. So if a user didn't explicitly enable idempotence, this feature won't be turned on. This patch addresses the problem, cleans up associated logic, and fixes tests that broke as a result of properly applying the new default. Specifically it does the following: 1. fix the `ProducerConfig#idempotenceEnabled` method, to make it correctly detect if `idempotence` is enabled or not 2. remove some unnecessary config overridden and checks due to we already default `acks`, `retries` and `enable.idempotence` configs. 3. move the config validator for the idempotent producer from `KafkaProducer` into `ProducerConfig`. The config validation should be the responsibility of `ProducerConfig` class. 4. add an `AbstractConfig#hasKeyInOriginals` method, to avoid `originals` configs get copied and only want to check the existence of the key. 5. fix many broken tests. As mentioned, we didn't actually enable idempotence in v3.0. After this PR, there are some tests broken due to some different behavior between idempotent and non-idempotent producer. 6. add additional tests to validate configuration behavior Reviewers: Kirk True <kirk@mustardgrain.com>, Ismael Juma <ismael@juma.me.uk>, Mickael Maison <mimaison@users.noreply.github.com>, Jason Gustafson <jason@confluent.io> |
||
|---|---|---|
| .. | ||
| documentation | ||
| images | ||
| js | ||
| streams | ||
| api.html | ||
| configuration.html | ||
| connect.html | ||
| design.html | ||
| documentation.html | ||
| ecosystem.html | ||
| implementation.html | ||
| introduction.html | ||
| migration.html | ||
| ops.html | ||
| protocol.html | ||
| quickstart.html | ||
| security.html | ||
| toc.html | ||
| upgrade.html | ||
| uses.html | ||