Go to file
Satish Duggana 6f19730164
KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory. (#13535)
This change includes
- Recognize the fetch requests with out of range local log offsets
- Add fetch implementation for the data lying in the range of [logStartOffset, localLogStartOffset]
- Add a new purgatory for async remote read requests which are served through a specific thread pool

We have an extended version of remote fetch that can fetch from multiple remote partitions in parallel, which we will raise as a followup PR.

A few tests for the newly introduced changes are added in this PR. There are some tests available for these scenarios in 2.8.x, refactoring with the trunk changes, will add them in followup PRs.

Other contributors:
Kamal Chandraprakash <kchandraprakash@uber.com> - Further improvements and adding a few tests
Luke Chen <showuon@gmail.com> - Added a few test cases for these changes.

PS: This functionality is pulled out from internal branches with other functionalities related to the feature in 2.8.x. The reason for not pulling all the changes as it makes the PR huge, and burdensome to review and it also needs other metrics, minor enhancements(including perf), and minor changes done for tests. So, we will try to have followup PRs to cover all those.

Reviewers: Jun Rao <junrao@gmail.com>, Alexandre Dupriez <alexandre.dupriez@gmail.com>, Divij Vaidya <diviv@amazon.com>,  Jorge Esteban Quilcate Otoya <quilcate.jorge@gmail.com>
2023-05-18 06:37:37 +05:30
bin KAFKA-14594: Move LogDirsCommand to tools module (#13122) 2023-05-04 12:00:33 +02:00
checkstyle KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory. (#13535) 2023-05-18 06:37:37 +05:30
clients KAFKA-14962: Trim whitespace from ACL configuration (#13670) 2023-05-12 23:51:00 +05:30
config MINOR: remove kraft readme link (#13691) 2023-05-10 16:40:20 +08:00
connect KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics (#13690) 2023-05-10 16:41:52 +02:00
core KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory. (#13535) 2023-05-18 06:37:37 +05:30
docs MINOR: remove kraft readme link (#13691) 2023-05-10 16:40:20 +08:00
examples KAFKA-14752: Kafka examples improvements - demo changes (#13517) 2023-05-12 10:39:12 +08:00
generator/src MINOR: Allow tagged fields with version subset of flexible version range (#13551) 2023-05-03 15:25:32 -07:00
gradle KAFKA-14994: jose4j is vulnerable to CVE- Improper Cryptographic Algorithm (#13717) 2023-05-13 12:42:57 +05:30
group-coordinator KAFKA-14500; [2/N] Rewrite GroupMetadata in Java (#13663) 2023-05-12 11:22:29 +02:00
jmh-benchmarks KAFKA-14766: Improve performance of VarInt encoding and decoding (#13312) 2023-05-05 20:05:20 +08:00
licenses KAFKA-14735: Improve KRaft metadata image change performance at high … (#13280) 2023-04-17 17:52:28 -04:00
log4j-appender/src KAFKA-13761: KafkaLog4jAppender deadlocks when idempotence is enabled (#11939) 2022-03-24 06:36:56 -07:00
metadata MINOR: Rename handleSnapshot to handleLoadSnapshot (#13727) 2023-05-17 09:57:24 -07:00
raft MINOR: Rename handleSnapshot to handleLoadSnapshot (#13727) 2023-05-17 09:57:24 -07:00
server-common/src MINOR: improve QuorumController logging #13540 2023-05-04 11:18:03 -07:00
shell/src MINOR: Rename handleSnapshot to handleLoadSnapshot (#13727) 2023-05-17 09:57:24 -07:00
storage KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory. (#13535) 2023-05-18 06:37:37 +05:30
streams HOTFIX: fix the VersionedKeyValueToBytesStoreAdapter#isOpen API (#13695) 2023-05-10 13:39:15 -07:00
tests HOTFIX: fix broken Streams upgrade system test (#13654) 2023-05-08 14:24:11 -07:00
tools KAFKA-14997: Fix JmxToolTest failing on CI server (#13720) 2023-05-16 10:31:32 +08:00
trogdor KAFKA-8115: Reduce flakiness in Trogdor JsonRestServer shutdown (#12830) 2023-04-15 12:21:56 -07:00
vagrant MINOR; Use 3.3.1 release for system test (#12714) 2022-10-04 16:19:24 -07:00
.asf.yaml MINOR: Fix .asf.yaml (#13722) 2023-05-15 14:24:57 -05:00
.gitignore MINOR: Add .vscode/ to git ignore for devs using vscode or codium (#13045) 2022-12-27 11:03:33 +08:00
CONTRIBUTING.md MINOR: Use https instead of http in links (#6477) 2019-04-22 11:58:25 -07:00
HEADER trivial fix to add missing license header using .gradlew licenseFormatMain and ./gradlew licenseFormatTest; patched by Jun Rao 2014-02-07 14:19:06 -08:00
Jenkinsfile MINOR: Enable spotless for streams-scala when Java 11+ is used (#13311) 2023-02-27 00:28:19 -08:00
LICENSE KAFKA-12602: Fix LICENSE file (#10474) 2021-04-06 15:08:24 -05:00
LICENSE-binary KAFKA-14994: jose4j is vulnerable to CVE- Improper Cryptographic Algorithm (#13717) 2023-05-13 12:42:57 +05:30
NOTICE 2023 (#13083) 2023-01-05 18:51:49 -08:00
NOTICE-binary KAFKA-12625: Fix the NOTICE file (#10693) 2021-07-29 13:53:29 -05:00
PULL_REQUEST_TEMPLATE.md MINOR: Exclude Committer Checklist section from commit message 2017-11-10 12:34:21 +00:00
README.md MINOR: use built-in "--rerun" to replace "-Prerun-tests" (#13343) 2023-03-06 10:53:49 +08:00
TROGDOR.md MINOR: Add RandomComponentPayloadGenerator and update Trogdor documentation (#7103) 2019-07-31 14:00:49 -07:00
Vagrantfile MINOR: kafka system tests should support larger EBS volumes for newer instances (#12382) 2022-07-07 09:14:05 +02:00
build.gradle KAFKA-14839: Exclude protected variable from JavaDocs (#13633) 2023-05-12 18:32:11 -07:00
doap_Kafka.rdf MINOR: Fix category in doap_Kafka.rdf (#11423) 2021-10-27 10:53:48 +02:00
gradle.properties MINOR: Bump trunk to 3.6.0-SNAPSHOT (#13570) 2023-04-14 14:17:07 +02:00
gradlew MINOR: Upgrade gradle to 8.1.1 (#13625) 2023-04-25 14:31:04 -07:00
gradlewAll MINOR: Add shebang to gradlewAll (#11373) 2022-10-06 16:18:12 +02:00
kafka-merge-pr.py MINOR: Bump trunk to 3.6.0-SNAPSHOT (#13570) 2023-04-14 14:17:07 +02:00
release.py MINOR: Fixes in release.py (#12648) 2022-09-20 12:26:11 +02:00
release_notes.py KAFKA-10712; Update release scripts to Python3 (#11538) 2021-11-29 10:42:14 +01:00
retry_zinc MINOR: Update Gradle to 7.6 (#12918) 2022-11-30 05:25:56 -08:00
reviewers.py MINOR add license to reviewers.py 2023-04-27 17:04:56 -04:00
settings.gradle MINOR: move RecordReader from org.apache.kafka.tools (client module) to org.apache.kafka.tools.api (tools-api module) (#13454) 2023-04-07 00:20:56 +08:00
wrapper.gradle MINOR: Upgrade gradle to 6.8 and test retry plugin to 1.2.0 (#9849) 2021-01-18 09:04:20 -08:00

README.md

Apache Kafka

See our web site for details on the project.

You need to have Java installed.

We build and test Apache Kafka with Java 8, 11 and 17. We set the release parameter in javac and scalac to 8 to ensure the generated binaries are compatible with Java 8 or higher (independently of the Java version used for compilation). Java 8 support has been deprecated since Apache Kafka 3.0 and will be removed in Apache Kafka 4.0 (see KIP-750 for more details).

Scala 2.12 and 2.13 are supported and 2.13 is used by default. Scala 2.12 support has been deprecated since Apache Kafka 3.0 and will be removed in Apache Kafka 4.0 (see KIP-751 for more details). See below for how to use a specific Scala version or all of the supported Scala versions.

Build a jar and run it

./gradlew jar

Follow instructions in https://kafka.apache.org/quickstart

Build source jar

./gradlew srcJar

Build aggregated javadoc

./gradlew aggregatedJavadoc

Build javadoc and scaladoc

./gradlew javadoc
./gradlew javadocJar # builds a javadoc jar for each module
./gradlew scaladoc
./gradlew scaladocJar # builds a scaladoc jar for each module
./gradlew docsJar # builds both (if applicable) javadoc and scaladoc jars for each module

Run unit/integration tests

./gradlew test # runs both unit and integration tests
./gradlew unitTest
./gradlew integrationTest

Force re-running tests without code change

./gradlew test --rerun
./gradlew unitTest --rerun
./gradlew integrationTest --rerun

Running a particular unit/integration test

./gradlew clients:test --tests RequestResponseTest

Repeatedly running a particular unit/integration test

I=0; while ./gradlew clients:test --tests RequestResponseTest --rerun --fail-fast; do (( I=$I+1 )); echo "Completed run: $I"; sleep 1; done

Running a particular test method within a unit/integration test

./gradlew core:test --tests kafka.api.ProducerFailureHandlingTest.testCannotSendToInternalTopic
./gradlew clients:test --tests org.apache.kafka.clients.MetadataTest.testTimeToNextUpdate

Running a particular unit/integration test with log4j output

Change the log4j setting in either clients/src/test/resources/log4j.properties or core/src/test/resources/log4j.properties

./gradlew clients:test --tests RequestResponseTest

Specifying test retries

By default, each failed test is retried once up to a maximum of five retries per test run. Tests are retried at the end of the test task. Adjust these parameters in the following way:

./gradlew test -PmaxTestRetries=1 -PmaxTestRetryFailures=5

See Test Retry Gradle Plugin for more details.

Generating test coverage reports

Generate coverage reports for the whole project:

./gradlew reportCoverage -PenableTestCoverage=true -Dorg.gradle.parallel=false

Generate coverage for a single module, i.e.:

./gradlew clients:reportCoverage -PenableTestCoverage=true -Dorg.gradle.parallel=false

Building a binary release gzipped tar ball

./gradlew clean releaseTarGz

The release file can be found inside ./core/build/distributions/.

Building auto generated messages

Sometimes it is only necessary to rebuild the RPC auto-generated message data when switching between branches, as they could fail due to code changes. You can just run:

./gradlew processMessages processTestMessages

Running a Kafka broker in KRaft mode

KAFKA_CLUSTER_ID="$(./bin/kafka-storage.sh random-uuid)"
./bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c config/kraft/server.properties
./bin/kafka-server-start.sh config/kraft/server.properties

Running a Kafka broker in ZooKeeper mode

./bin/zookeeper-server-start.sh config/zookeeper.properties
./bin/kafka-server-start.sh config/server.properties

Cleaning the build

./gradlew clean

Running a task with one of the Scala versions available (2.12.x or 2.13.x)

Note that if building the jars with a version other than 2.13.x, you need to set the SCALA_VERSION variable or change it in bin/kafka-run-class.sh to run the quick start.

You can pass either the major version (eg 2.12) or the full version (eg 2.12.7):

./gradlew -PscalaVersion=2.12 jar
./gradlew -PscalaVersion=2.12 test
./gradlew -PscalaVersion=2.12 releaseTarGz

Running a task with all the scala versions enabled by default

Invoke the gradlewAll script followed by the task(s):

./gradlewAll test
./gradlewAll jar
./gradlewAll releaseTarGz

Running a task for a specific project

This is for core, examples and clients

./gradlew core:jar
./gradlew core:test

Streams has multiple sub-projects, but you can run all the tests:

./gradlew :streams:testAll

Listing all gradle tasks

./gradlew tasks

Building IDE project

Note that this is not strictly necessary (IntelliJ IDEA has good built-in support for Gradle projects, for example).

./gradlew eclipse
./gradlew idea

The eclipse task has been configured to use ${project_dir}/build_eclipse as Eclipse's build directory. Eclipse's default build directory (${project_dir}/bin) clashes with Kafka's scripts directory and we don't use Gradle's build directory to avoid known issues with this configuration.

Publishing the jar for all versions of Scala and for all projects to maven

The recommended command is:

./gradlewAll publish

For backwards compatibility, the following also works:

./gradlewAll uploadArchives

Please note for this to work you should create/update ${GRADLE_USER_HOME}/gradle.properties (typically, ~/.gradle/gradle.properties) and assign the following variables

mavenUrl=
mavenUsername=
mavenPassword=
signing.keyId=
signing.password=
signing.secretKeyRingFile=

Publishing the streams quickstart archetype artifact to maven

For the Streams archetype project, one cannot use gradle to upload to maven; instead the mvn deploy command needs to be called at the quickstart folder:

cd streams/quickstart
mvn deploy

Please note for this to work you should create/update user maven settings (typically, ${USER_HOME}/.m2/settings.xml) to assign the following variables

<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
                       https://maven.apache.org/xsd/settings-1.0.0.xsd">
...                           
<servers>
   ...
   <server>
      <id>apache.snapshots.https</id>
      <username>${maven_username}</username>
      <password>${maven_password}</password>
   </server>
   <server>
      <id>apache.releases.https</id>
      <username>${maven_username}</username>
      <password>${maven_password}</password>
    </server>
    ...
 </servers>
 ...

Installing ALL the jars to the local Maven repository

The recommended command to build for both Scala 2.12 and 2.13 is:

./gradlewAll publishToMavenLocal

For backwards compatibility, the following also works:

./gradlewAll install

Installing specific projects to the local Maven repository

./gradlew -PskipSigning=true :streams:publishToMavenLocal

If needed, you can specify the Scala version with -PscalaVersion=2.13.

Building the test jar

./gradlew testJar

Running code quality checks

There are two code quality analysis tools that we regularly run, spotbugs and checkstyle.

Checkstyle

Checkstyle enforces a consistent coding style in Kafka. You can run checkstyle using:

./gradlew checkstyleMain checkstyleTest

The checkstyle warnings will be found in reports/checkstyle/reports/main.html and reports/checkstyle/reports/test.html files in the subproject build directories. They are also printed to the console. The build will fail if Checkstyle fails.

Spotbugs

Spotbugs uses static analysis to look for bugs in the code. You can run spotbugs using:

./gradlew spotbugsMain spotbugsTest -x test

The spotbugs warnings will be found in reports/spotbugs/main.html and reports/spotbugs/test.html files in the subproject build directories. Use -PxmlSpotBugsReport=true to generate an XML report instead of an HTML one.

JMH microbenchmarks

We use JMH to write microbenchmarks that produce reliable results in the JVM.

See jmh-benchmarks/README.md for details on how to run the microbenchmarks.

Dependency Analysis

The gradle dependency debugging documentation mentions using the dependencies or dependencyInsight tasks to debug dependencies for the root project or individual subprojects.

Alternatively, use the allDeps or allDepInsight tasks for recursively iterating through all subprojects:

./gradlew allDeps

./gradlew allDepInsight --configuration runtimeClasspath --dependency com.fasterxml.jackson.core:jackson-databind

These take the same arguments as the builtin variants.

Determining if any dependencies could be updated

./gradlew dependencyUpdates

Common build options

The following options should be set with a -P switch, for example ./gradlew -PmaxParallelForks=1 test.

  • commitId: sets the build commit ID as .git/HEAD might not be correct if there are local commits added for build purposes.
  • mavenUrl: sets the URL of the maven deployment repository (file://path/to/repo can be used to point to a local repository).
  • maxParallelForks: maximum number of test processes to start in parallel. Defaults to the number of processors available to the JVM.
  • maxScalacThreads: maximum number of worker threads for the scalac backend. Defaults to the lowest of 8 and the number of processors available to the JVM. The value must be between 1 and 16 (inclusive).
  • ignoreFailures: ignore test failures from junit
  • showStandardStreams: shows standard out and standard error of the test JVM(s) on the console.
  • skipSigning: skips signing of artifacts.
  • testLoggingEvents: unit test events to be logged, separated by comma. For example ./gradlew -PtestLoggingEvents=started,passed,skipped,failed test.
  • xmlSpotBugsReport: enable XML reports for spotBugs. This also disables HTML reports as only one can be enabled at a time.
  • maxTestRetries: maximum number of retries for a failing test case.
  • maxTestRetryFailures: maximum number of test failures before retrying is disabled for subsequent tests.
  • enableTestCoverage: enables test coverage plugins and tasks, including bytecode enhancement of classes required to track said coverage. Note that this introduces some overhead when running tests and hence why it's disabled by default (the overhead varies, but 15-20% is a reasonable estimate).
  • keepAliveMode: configures the keep alive mode for the Gradle compilation daemon - reuse improves start-up time. The values should be one of daemon or session (the default is daemon). daemon keeps the daemon alive until it's explicitly stopped while session keeps it alive until the end of the build session. This currently only affects the Scala compiler, see https://github.com/gradle/gradle/pull/21034 for a PR that attempts to do the same for the Java compiler.
  • scalaOptimizerMode: configures the optimizing behavior of the scala compiler, the value should be one of none, method, inline-kafka or inline-scala (the default is inline-kafka). none is the scala compiler default, which only eliminates unreachable code. method also includes method-local optimizations. inline-kafka adds inlining of methods within the kafka packages. Finally, inline-scala also includes inlining of methods within the scala library (which avoids lambda allocations for methods like Option.exists). inline-scala is only safe if the Scala library version is the same at compile time and runtime. Since we cannot guarantee this for all cases (for example, users may depend on the kafka jar for integration tests where they may include a scala library with a different version), we don't enable it by default. See https://www.lightbend.com/blog/scala-inliner-optimizer for more details.

Running system tests

See tests/README.md.

Running in Vagrant

See vagrant/README.md.

Contribution

Apache Kafka is interested in building the community; we would welcome any thoughts or patches. You can reach us on the Apache mailing lists.

To contribute follow the instructions here: