Go to file
Greg Harris 7298e44b4c KAFKA-10763: Fix incomplete cooperative rebalances preventing connector/task revocations (#9765)
When two cooperative rebalances take place soon after one another, a prior rebalance may not complete before the next rebalance is started.
Under Eager rebalancing, no tasks would have been started, so the subsequent onRevoked call is intentionally skipped whenever rebalanceResolved was false.
Under Incremental Cooperative rebalancing, the same logic causes the DistributedHerder to skip stopping all of the connector/task revocations which occur in the second rebalance.
The DistributedHerder still removes the revoked connectors/tasks from its assignment, so that the DistributedHerder and Worker have different knowledge of running connectors/tasks.
This causes the connector/task instances that would have been stopped to disappear from the rebalance protocol, and left running until their workers are halted, or they fail.
Connectors/Tasks which were then reassigned to other workers by the rebalance protocol would be duplicated, and run concurrently with zombie connectors/tasks.
Connectors/Tasks which were reassigned back to the same worker would encounter exceptions in Worker, indicating that the connector/task existed and was already running.

* Added test for revoking and then reassigning a connector under normal circumstances
* Added test for revoking and then reassigning a connector following an incomplete cooperative rebalance
* Changed expectRebalance to make assignment fields mutable before passing them into the DistributedHerder
* Only skip revocation for the Eager protocol, and never skip revocation for incremental cooperative protocols

Reviewers: Konstantine Karantasis <k.karantasis@gmail.com>
2021-01-26 10:19:09 -08:00
bin KAFKA-10018: Change command line tools from /bin/sh to /bin/bash (#8692) 2020-05-27 14:31:31 -07:00
checkstyle Revert KAFKA-9309: Add the ability to translate Message to JSON (#9197) 2020-08-19 11:30:34 -07:00
clients KAFKA-10798; Ensure response is delayed for failed SASL authentication with connection close delay (#9678) 2020-12-16 15:42:15 +00:00
config KAFKA-8470: State change logs should not be in TRACE level (#8320) 2020-03-26 14:53:40 -07:00
connect KAFKA-10763: Fix incomplete cooperative rebalances preventing connector/task revocations (#9765) 2021-01-26 10:19:09 -08:00
core MINOR: Add a log to print acl change notification details 2021-01-07 16:46:03 +05:30
docs MINOR: Update 2.6 branch version to 2.6.2-SNAPSHOT 2021-01-07 17:06:33 +00:00
examples KAFKA-9922: Update demo instructions in examples README (#8559) 2020-04-29 19:31:26 -07:00
generator/src Revert KAFKA-9309: Add the ability to translate Message to JSON (#9197) 2020-08-19 11:30:34 -07:00
gradle MINOR: Update jackson databind to 2.10.5.1 (#9702) 2020-12-15 19:11:42 -08:00
jmh-benchmarks KAFKA-10158: Fix flaky testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress (#9022) 2020-07-26 08:29:14 -07:00
log4j-appender/src KAFKA-8890: Make SSL context/engine configuration extensible (KIP-519) (#8338) 2020-04-08 15:20:32 +01:00
streams KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems (#9968) 2021-01-25 20:30:41 -08:00
tests MINOR: Upgrade ducktape to version 0.7.11 (#9932) 2021-01-22 20:27:56 -08:00
tools/src MINOR: Streams integration tests should not call exit (#9067) 2020-08-05 13:54:55 -07:00
vagrant MINOR: bump 2.5 versions to 2.5.1 (#9165) 2020-08-12 10:31:27 -05:00
.asf.yaml MINOR: Adding github whitelist (#8523) 2020-04-20 14:42:59 -07:00
.gitignore KAFKA-10598: Improve IQ name and type checks (#9408) 2020-10-12 10:37:41 -05:00
.travis.yml MINOR: Add HttpMetricsReporter for system tests 2017-11-09 09:42:46 -08:00
CONTRIBUTING.md MINOR: Use https instead of http in links (#6477) 2019-04-22 11:58:25 -07:00
HEADER
Jenkinsfile MINOR: Add Jenkinsfile to 2.6 (#9471) 2020-10-29 11:43:26 -05:00
LICENSE KAFKA-10224: Update jersey license from CDDL to EPLv2 (#9089) 2020-07-28 13:11:39 -05:00
NOTICE MINOR: Update year in NOTICE (#8207) 2020-03-02 15:53:23 -05:00
PULL_REQUEST_TEMPLATE.md MINOR: Exclude Committer Checklist section from commit message 2017-11-10 12:34:21 +00:00
README.md MINOR: add task ':streams:testAll' (#9073) 2020-09-28 15:01:25 -05:00
TROGDOR.md MINOR: Add RandomComponentPayloadGenerator and update Trogdor documentation (#7103) 2019-07-31 14:00:49 -07:00
Vagrantfile MINOR: upgrade to jdk8 8u202 2019-01-24 22:19:19 -08:00
build.gradle MINOR: add task ':streams:testAll' (#9073) 2020-09-28 15:01:25 -05:00
doap_Kafka.rdf MINOR: Use https instead of http in links (#6477) 2019-04-22 11:58:25 -07:00
gradle.properties MINOR: Update 2.6 branch version to 2.6.2-SNAPSHOT 2021-01-07 17:06:33 +00:00
gradlew MINOR: Update to Gradle 6.5 and tweak build jvm config (#8751) 2020-06-03 13:19:41 -07:00
gradlewAll MINOR: Update to Gradle 6.3 (#7677) 2020-04-19 19:24:21 -07:00
jenkins.sh MINOR: Upgrade gradle plugins and test libraries for Java 14 support (#8519) 2020-04-20 13:55:20 -07:00
kafka-merge-pr.py MINOR: Update 2.6 branch version to 2.6.2-SNAPSHOT 2021-01-07 17:06:33 +00:00
release.py MINOR: speed up release script (#9070) 2020-07-27 09:27:12 -05:00
release_notes.py MINOR: Use https instead of http in links (#6477) 2019-04-22 11:58:25 -07:00
settings.gradle KAFKA-9779: Add Stream system test for 2.5 release (#8378) 2020-04-15 15:59:03 -07:00
wrapper.gradle MINOR: Remove unnecessary license generation code in wrapper.gradle (#7742) 2019-11-24 10:51:49 -08:00

README.md

Apache Kafka

See our web site for details on the project.

You need to have Java installed.

We build and test Apache Kafka with Java 8, 11 and 14. We set the release parameter in javac and scalac to 8 to ensure the generated binaries are compatible with Java 8 or higher (independently of the Java version used for compilation).

Scala 2.13 is used by default, see below for how to use a different Scala version or all of the supported Scala versions.

Build a jar and run it

./gradlew jar

Follow instructions in https://kafka.apache.org/documentation.html#quickstart

Build source jar

./gradlew srcJar

Build aggregated javadoc

./gradlew aggregatedJavadoc

Build javadoc and scaladoc

./gradlew javadoc
./gradlew javadocJar # builds a javadoc jar for each module
./gradlew scaladoc
./gradlew scaladocJar # builds a scaladoc jar for each module
./gradlew docsJar # builds both (if applicable) javadoc and scaladoc jars for each module

Run unit/integration tests

./gradlew test # runs both unit and integration tests
./gradlew unitTest
./gradlew integrationTest

Force re-running tests without code change

./gradlew cleanTest test
./gradlew cleanTest unitTest
./gradlew cleanTest integrationTest

Running a particular unit/integration test

./gradlew clients:test --tests RequestResponseTest

Running a particular test method within a unit/integration test

./gradlew core:test --tests kafka.api.ProducerFailureHandlingTest.testCannotSendToInternalTopic
./gradlew clients:test --tests org.apache.kafka.clients.MetadataTest.testMetadataUpdateWaitTime

Running a particular unit/integration test with log4j output

Change the log4j setting in either clients/src/test/resources/log4j.properties or core/src/test/resources/log4j.properties

./gradlew clients:test --tests RequestResponseTest

Specifying test retries

By default, each failed test is retried once up to a maximum of five retries per test run. Tests are retried at the end of the test task. Adjust these parameters in the following way:

./gradlew test -PmaxTestRetries=1 -PmaxTestRetryFailures=5

See Test Retry Gradle Plugin for more details.

Generating test coverage reports

Generate coverage reports for the whole project:

./gradlew reportCoverage

Generate coverage for a single module, i.e.:

./gradlew clients:reportCoverage

Building a binary release gzipped tar ball

./gradlew clean releaseTarGz

The above command will fail if you haven't set up the signing key. To bypass signing the artifact, you can run:

./gradlew clean releaseTarGz -x signArchives

The release file can be found inside ./core/build/distributions/.

Building auto generated messages

Sometimes it is only necessary to rebuild the RPC auto-generated message data when switching between branches, as they could fail due to code changes. You can just run:

./gradlew processMessages processTestMessages

Cleaning the build

./gradlew clean

Running a task with one of the Scala versions available (2.12.x or 2.13.x)

Note that if building the jars with a version other than 2.12.x, you need to set the SCALA_VERSION variable or change it in bin/kafka-run-class.sh to run the quick start.

You can pass either the major version (eg 2.12) or the full version (eg 2.12.7):

./gradlew -PscalaVersion=2.12 jar
./gradlew -PscalaVersion=2.12 test
./gradlew -PscalaVersion=2.12 releaseTarGz

Running a task with all the scala versions enabled by default

Invoke the gradlewAll script followed by the task(s):

./gradlewAll test
./gradlewAll jar
./gradlewAll releaseTarGz

Running a task for a specific project

This is for core, examples and clients

./gradlew core:jar
./gradlew core:test

Streams has multiple sub-projects, but you can run all the tests:

./gradlew :streams:testAll

Listing all gradle tasks

./gradlew tasks

Building IDE project

Note that this is not strictly necessary (IntelliJ IDEA has good built-in support for Gradle projects, for example).

./gradlew eclipse
./gradlew idea

The eclipse task has been configured to use ${project_dir}/build_eclipse as Eclipse's build directory. Eclipse's default build directory (${project_dir}/bin) clashes with Kafka's scripts directory and we don't use Gradle's build directory to avoid known issues with this configuration.

Publishing the jar for all version of Scala and for all projects to maven

./gradlewAll uploadArchives

Please note for this to work you should create/update ${GRADLE_USER_HOME}/gradle.properties (typically, ~/.gradle/gradle.properties) and assign the following variables

mavenUrl=
mavenUsername=
mavenPassword=
signing.keyId=
signing.password=
signing.secretKeyRingFile=

Publishing the streams quickstart archetype artifact to maven

For the Streams archetype project, one cannot use gradle to upload to maven; instead the mvn deploy command needs to be called at the quickstart folder:

cd streams/quickstart
mvn deploy

Please note for this to work you should create/update user maven settings (typically, ${USER_HOME}/.m2/settings.xml) to assign the following variables

<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
                       https://maven.apache.org/xsd/settings-1.0.0.xsd">
...                           
<servers>
   ...
   <server>
      <id>apache.snapshots.https</id>
      <username>${maven_username}</username>
      <password>${maven_password}</password>
   </server>
   <server>
      <id>apache.releases.https</id>
      <username>${maven_username}</username>
      <password>${maven_password}</password>
    </server>
    ...
 </servers>
 ...

Installing the jars to the local Maven repository

./gradlewAll install

Building the test jar

./gradlew testJar

Determining how transitive dependencies are added

./gradlew core:dependencies --configuration runtime

Determining if any dependencies could be updated

./gradlew dependencyUpdates

Running code quality checks

There are two code quality analysis tools that we regularly run, spotbugs and checkstyle.

Checkstyle

Checkstyle enforces a consistent coding style in Kafka. You can run checkstyle using:

./gradlew checkstyleMain checkstyleTest

The checkstyle warnings will be found in reports/checkstyle/reports/main.html and reports/checkstyle/reports/test.html files in the subproject build directories. They are also printed to the console. The build will fail if Checkstyle fails.

Spotbugs

Spotbugs uses static analysis to look for bugs in the code. You can run spotbugs using:

./gradlew spotbugsMain spotbugsTest -x test

The spotbugs warnings will be found in reports/spotbugs/main.html and reports/spotbugs/test.html files in the subproject build directories. Use -PxmlSpotBugsReport=true to generate an XML report instead of an HTML one.

Common build options

The following options should be set with a -P switch, for example ./gradlew -PmaxParallelForks=1 test.

  • commitId: sets the build commit ID as .git/HEAD might not be correct if there are local commits added for build purposes.
  • mavenUrl: sets the URL of the maven deployment repository (file://path/to/repo can be used to point to a local repository).
  • maxParallelForks: limits the maximum number of processes for each task.
  • showStandardStreams: shows standard out and standard error of the test JVM(s) on the console.
  • skipSigning: skips signing of artifacts.
  • testLoggingEvents: unit test events to be logged, separated by comma. For example ./gradlew -PtestLoggingEvents=started,passed,skipped,failed test.
  • xmlSpotBugsReport: enable XML reports for spotBugs. This also disables HTML reports as only one can be enabled at a time.
  • maxTestRetries: the maximum number of retries for a failing test case.
  • maxTestRetryFailures: maximum number of test failures before retrying is disabled for subsequent tests.

Dependency Analysis

The gradle dependency debugging documentation mentions using the dependencies or dependencyInsight tasks to debug dependencies for the root project or individual subprojects.

Alternatively, use the allDeps or allDepInsight tasks for recursively iterating through all subprojects:

./gradlew allDeps

./gradlew allDepInsight --configuration runtime --dependency com.fasterxml.jackson.core:jackson-databind

These take the same arguments as the builtin variants.

Running system tests

See tests/README.md.

Running in Vagrant

See vagrant/README.md.

Contribution

Apache Kafka is interested in building the community; we would welcome any thoughts or patches. You can reach us on the Apache mailing lists.

To contribute follow the instructions here: