| 
									
										
										
										
											2021-04-19 03:41:13 +08:00
										 |  |  | // Copyright (c) 2015-2021 MinIO, Inc.
 | 
					
						
							|  |  |  | //
 | 
					
						
							|  |  |  | // This file is part of MinIO Object Storage stack
 | 
					
						
							|  |  |  | //
 | 
					
						
							|  |  |  | // This program is free software: you can redistribute it and/or modify
 | 
					
						
							|  |  |  | // it under the terms of the GNU Affero General Public License as published by
 | 
					
						
							|  |  |  | // the Free Software Foundation, either version 3 of the License, or
 | 
					
						
							|  |  |  | // (at your option) any later version.
 | 
					
						
							|  |  |  | //
 | 
					
						
							|  |  |  | // This program is distributed in the hope that it will be useful
 | 
					
						
							|  |  |  | // but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
					
						
							|  |  |  | // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
					
						
							|  |  |  | // GNU Affero General Public License for more details.
 | 
					
						
							|  |  |  | //
 | 
					
						
							|  |  |  | // You should have received a copy of the GNU Affero General Public License
 | 
					
						
							|  |  |  | // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | 
					
						
							| 
									
										
										
										
											2016-12-10 16:42:22 +08:00
										 |  |  | 
 | 
					
						
							|  |  |  | package cmd | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | import ( | 
					
						
							|  |  |  | 	"net/http" | 
					
						
							| 
									
										
										
										
											2018-10-17 10:22:09 +08:00
										 |  |  | 	"net/http/httptest" | 
					
						
							| 
									
										
										
										
											2018-10-27 09:03:17 +08:00
										 |  |  | 	"net/url" | 
					
						
							| 
									
										
										
										
											2017-08-23 07:53:35 +08:00
										 |  |  | 	"strconv" | 
					
						
							| 
									
										
										
										
											2016-12-10 16:42:22 +08:00
										 |  |  | 	"testing" | 
					
						
							| 
									
										
										
										
											2018-08-18 03:52:14 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2021-06-02 05:59:40 +08:00
										 |  |  | 	"github.com/minio/minio/internal/crypto" | 
					
						
							|  |  |  | 	xhttp "github.com/minio/minio/internal/http" | 
					
						
							| 
									
										
										
										
											2016-12-10 16:42:22 +08:00
										 |  |  | ) | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2017-09-02 03:16:54 +08:00
										 |  |  | // Tests request guess function for net/rpc requests.
 | 
					
						
							|  |  |  | func TestGuessIsRPC(t *testing.T) { | 
					
						
							|  |  |  | 	if guessIsRPCReq(nil) { | 
					
						
							|  |  |  | 		t.Fatal("Unexpected return for nil request") | 
					
						
							|  |  |  | 	} | 
					
						
							| 
									
										
										
										
											2018-12-06 06:28:48 +08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	u, err := url.Parse("http://localhost:9000/minio/lock") | 
					
						
							|  |  |  | 	if err != nil { | 
					
						
							|  |  |  | 		t.Fatal(err) | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2017-09-02 03:16:54 +08:00
										 |  |  | 	r := &http.Request{ | 
					
						
							|  |  |  | 		Proto:  "HTTP/1.0", | 
					
						
							| 
									
										
										
										
											2018-06-06 16:51:56 +08:00
										 |  |  | 		Method: http.MethodPost, | 
					
						
							| 
									
										
										
										
											2018-12-06 06:28:48 +08:00
										 |  |  | 		URL:    u, | 
					
						
							| 
									
										
										
										
											2017-09-02 03:16:54 +08:00
										 |  |  | 	} | 
					
						
							|  |  |  | 	if !guessIsRPCReq(r) { | 
					
						
							|  |  |  | 		t.Fatal("Test shouldn't fail for a possible net/rpc request.") | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	r = &http.Request{ | 
					
						
							|  |  |  | 		Proto:  "HTTP/1.1", | 
					
						
							|  |  |  | 		Method: http.MethodGet, | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	if guessIsRPCReq(r) { | 
					
						
							|  |  |  | 		t.Fatal("Test shouldn't report as net/rpc for a non net/rpc request.") | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2017-08-23 07:53:35 +08:00
										 |  |  | var isHTTPHeaderSizeTooLargeTests = []struct { | 
					
						
							|  |  |  | 	header     http.Header | 
					
						
							|  |  |  | 	shouldFail bool | 
					
						
							|  |  |  | }{ | 
					
						
							|  |  |  | 	{header: generateHeader(0, 0), shouldFail: false}, | 
					
						
							|  |  |  | 	{header: generateHeader(1024, 0), shouldFail: false}, | 
					
						
							|  |  |  | 	{header: generateHeader(2048, 0), shouldFail: false}, | 
					
						
							|  |  |  | 	{header: generateHeader(8*1024+1, 0), shouldFail: true}, | 
					
						
							|  |  |  | 	{header: generateHeader(0, 1024), shouldFail: false}, | 
					
						
							|  |  |  | 	{header: generateHeader(0, 2048), shouldFail: true}, | 
					
						
							|  |  |  | 	{header: generateHeader(0, 2048+1), shouldFail: true}, | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func generateHeader(size, usersize int) http.Header { | 
					
						
							|  |  |  | 	header := http.Header{} | 
					
						
							|  |  |  | 	for i := 0; i < size; i++ { | 
					
						
							| 
									
										
										
										
											2020-09-02 07:58:13 +08:00
										 |  |  | 		header.Set(strconv.Itoa(i), "") | 
					
						
							| 
									
										
										
										
											2017-08-23 07:53:35 +08:00
										 |  |  | 	} | 
					
						
							|  |  |  | 	userlength := 0 | 
					
						
							|  |  |  | 	for i := 0; userlength < usersize; i++ { | 
					
						
							|  |  |  | 		userlength += len(userMetadataKeyPrefixes[0] + strconv.Itoa(i)) | 
					
						
							| 
									
										
										
										
											2020-09-02 07:58:13 +08:00
										 |  |  | 		header.Set(userMetadataKeyPrefixes[0]+strconv.Itoa(i), "") | 
					
						
							| 
									
										
										
										
											2017-08-23 07:53:35 +08:00
										 |  |  | 	} | 
					
						
							|  |  |  | 	return header | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func TestIsHTTPHeaderSizeTooLarge(t *testing.T) { | 
					
						
							|  |  |  | 	for i, test := range isHTTPHeaderSizeTooLargeTests { | 
					
						
							|  |  |  | 		if res := isHTTPHeaderSizeTooLarge(test.header); res != test.shouldFail { | 
					
						
							|  |  |  | 			t.Errorf("Test %d: Expected %v got %v", i, res, test.shouldFail) | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							| 
									
										
										
										
											2017-11-08 07:18:59 +08:00
										 |  |  | 
 | 
					
						
							|  |  |  | var containsReservedMetadataTests = []struct { | 
					
						
							|  |  |  | 	header     http.Header | 
					
						
							|  |  |  | 	shouldFail bool | 
					
						
							|  |  |  | }{ | 
					
						
							|  |  |  | 	{ | 
					
						
							|  |  |  | 		header: http.Header{"X-Minio-Key": []string{"value"}}, | 
					
						
							|  |  |  | 	}, | 
					
						
							|  |  |  | 	{ | 
					
						
							| 
									
										
										
										
											2020-12-23 01:19:32 +08:00
										 |  |  | 		header:     http.Header{crypto.MetaIV: []string{"iv"}}, | 
					
						
							| 
									
										
										
										
											2017-11-08 07:18:59 +08:00
										 |  |  | 		shouldFail: true, | 
					
						
							|  |  |  | 	}, | 
					
						
							|  |  |  | 	{ | 
					
						
							| 
									
										
										
										
											2020-12-23 01:19:32 +08:00
										 |  |  | 		header:     http.Header{crypto.MetaAlgorithm: []string{crypto.InsecureSealAlgorithm}}, | 
					
						
							| 
									
										
										
										
											2017-11-08 07:18:59 +08:00
										 |  |  | 		shouldFail: true, | 
					
						
							|  |  |  | 	}, | 
					
						
							|  |  |  | 	{ | 
					
						
							| 
									
										
										
										
											2020-12-23 01:19:32 +08:00
										 |  |  | 		header:     http.Header{crypto.MetaSealedKeySSEC: []string{"mac"}}, | 
					
						
							| 
									
										
										
										
											2017-11-08 07:18:59 +08:00
										 |  |  | 		shouldFail: true, | 
					
						
							|  |  |  | 	}, | 
					
						
							|  |  |  | 	{ | 
					
						
							|  |  |  | 		header:     http.Header{ReservedMetadataPrefix + "Key": []string{"value"}}, | 
					
						
							|  |  |  | 		shouldFail: true, | 
					
						
							|  |  |  | 	}, | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func TestContainsReservedMetadata(t *testing.T) { | 
					
						
							| 
									
										
										
										
											2020-06-13 11:04:01 +08:00
										 |  |  | 	for _, test := range containsReservedMetadataTests { | 
					
						
							|  |  |  | 		test := test | 
					
						
							|  |  |  | 		t.Run("", func(t *testing.T) { | 
					
						
							|  |  |  | 			contains := containsReservedMetadata(test.header) | 
					
						
							|  |  |  | 			if contains && !test.shouldFail { | 
					
						
							|  |  |  | 				t.Errorf("contains reserved header but should not fail") | 
					
						
							|  |  |  | 			} else if !contains && test.shouldFail { | 
					
						
							|  |  |  | 				t.Errorf("does not contain reserved header but failed") | 
					
						
							|  |  |  | 			} | 
					
						
							|  |  |  | 		}) | 
					
						
							| 
									
										
										
										
											2017-11-08 07:18:59 +08:00
										 |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							| 
									
										
										
										
											2018-10-17 10:22:09 +08:00
										 |  |  | 
 | 
					
						
							|  |  |  | var sseTLSHandlerTests = []struct { | 
					
						
							| 
									
										
										
										
											2018-10-27 09:03:17 +08:00
										 |  |  | 	URL               *url.URL | 
					
						
							| 
									
										
										
										
											2018-10-17 10:22:09 +08:00
										 |  |  | 	Header            http.Header | 
					
						
							|  |  |  | 	IsTLS, ShouldFail bool | 
					
						
							|  |  |  | }{ | 
					
						
							| 
									
										
										
										
											2020-12-23 01:19:32 +08:00
										 |  |  | 	{URL: &url.URL{}, Header: http.Header{}, IsTLS: false, ShouldFail: false},                                                                  // 0
 | 
					
						
							|  |  |  | 	{URL: &url.URL{}, Header: http.Header{xhttp.AmzServerSideEncryptionCustomerAlgorithm: []string{"AES256"}}, IsTLS: false, ShouldFail: true}, // 1
 | 
					
						
							|  |  |  | 	{URL: &url.URL{}, Header: http.Header{xhttp.AmzServerSideEncryptionCustomerAlgorithm: []string{"AES256"}}, IsTLS: true, ShouldFail: false}, // 2
 | 
					
						
							|  |  |  | 	{URL: &url.URL{}, Header: http.Header{xhttp.AmzServerSideEncryptionCustomerKey: []string{""}}, IsTLS: true, ShouldFail: false},             // 3
 | 
					
						
							|  |  |  | 	{URL: &url.URL{}, Header: http.Header{xhttp.AmzServerSideEncryptionCopyCustomerAlgorithm: []string{""}}, IsTLS: false, ShouldFail: true},   // 4
 | 
					
						
							| 
									
										
										
										
											2018-10-17 10:22:09 +08:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func TestSSETLSHandler(t *testing.T) { | 
					
						
							| 
									
										
										
										
											2020-12-22 13:42:38 +08:00
										 |  |  | 	defer func(isSSL bool) { globalIsTLS = isSSL }(globalIsTLS) // reset globalIsTLS after test
 | 
					
						
							| 
									
										
										
										
											2018-10-17 10:22:09 +08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	var okHandler http.HandlerFunc = func(w http.ResponseWriter, r *http.Request) { | 
					
						
							|  |  |  | 		w.WriteHeader(http.StatusOK) | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	for i, test := range sseTLSHandlerTests { | 
					
						
							| 
									
										
										
										
											2020-12-22 13:42:38 +08:00
										 |  |  | 		globalIsTLS = test.IsTLS | 
					
						
							| 
									
										
										
										
											2018-10-17 10:22:09 +08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 		w := httptest.NewRecorder() | 
					
						
							|  |  |  | 		r := new(http.Request) | 
					
						
							|  |  |  | 		r.Header = test.Header | 
					
						
							| 
									
										
										
										
											2018-10-27 09:03:17 +08:00
										 |  |  | 		r.URL = test.URL | 
					
						
							| 
									
										
										
										
											2018-10-17 10:22:09 +08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 		h := setSSETLSHandler(okHandler) | 
					
						
							|  |  |  | 		h.ServeHTTP(w, r) | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		switch { | 
					
						
							|  |  |  | 		case test.ShouldFail && w.Code == http.StatusOK: | 
					
						
							|  |  |  | 			t.Errorf("Test %d: should fail but status code is HTTP %d", i, w.Code) | 
					
						
							|  |  |  | 		case !test.ShouldFail && w.Code != http.StatusOK: | 
					
						
							|  |  |  | 			t.Errorf("Test %d: should not fail but status code is HTTP %d and not 200 OK", i, w.Code) | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } |