root
/
minio
mirror of https://github.com/minio/minio.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity
minio/cmd/config-current_test.go

319 lines
14 KiB
Go
Raw Normal View History

server: Startup message now prints configured ARNs. (#2653) Fixes #2628
2016-09-10 17:23:28 +08:00
/*
Add constants for commonly used values. (#3588) This is a consolidation effort, avoiding usage of naked strings in codebase. Whenever possible use constants which can be repurposed elsewhere. This also fixes `goconst ./...` reported issues.
2017-01-19 04:24:34 +08:00
* Minio Cloud Storage, (C) 2016, 2017 Minio, Inc.
server: Startup message now prints configured ARNs. (#2653) Fixes #2628
2016-09-10 17:23:28 +08:00
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
package cmd
import (
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
"io/ioutil"
config: Add browser parameter (#3807) browser new parameter receives "on" or "off" parameter which is similar to MINIO_BROWSER
2017-02-28 06:59:53 +08:00
"os"
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
"path/filepath"
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
"reflect"
"testing"
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
"github.com/tidwall/gjson"
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
)
func TestServerConfig(t *testing.T) {
Add constants for commonly used values. (#3588) This is a consolidation effort, avoiding usage of naked strings in codebase. Whenever possible use constants which can be repurposed elsewhere. This also fixes `goconst ./...` reported issues.
2017-01-19 04:24:34 +08:00
rootPath, err := newTestConfig(globalMinioDefaultRegion)
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
if err != nil {
t.Fatalf("Init Test config failed")
}
Fix the server startup messages and help text. (#3211)
2016-11-10 15:37:12 +08:00
// remove the root directory after the test ends.
posix: Deprecate custom removeAll/mkdirAll implementations. (#4808) Since go1.8 os.RemoveAll and os.MkdirAll both support long path names i.e UNC path on windows. The code we are carrying was directly borrowed from `pkg/os` package and doesn't need to be in our repo anymore. As a side affect this also addresses our codecoverage issue. Refer #4658
2017-08-13 10:25:43 +08:00
defer os.RemoveAll(rootPath)
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
if globalServerConfig.GetRegion() != globalMinioDefaultRegion {
t.Errorf("Expecting region `us-east-1` found %s", globalServerConfig.GetRegion())
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
}
// Set new region and verify.
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
globalServerConfig.SetRegion("us-west-1")
if globalServerConfig.GetRegion() != "us-west-1" {
t.Errorf("Expecting region `us-west-1` found %s", globalServerConfig.GetRegion())
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
}
// Set new amqp notification id.
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
globalServerConfig.Notify.SetAMQPByID("2", amqpNotify{})
savedNotifyCfg1 := globalServerConfig.Notify.GetAMQPByID("2")
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
if !reflect.DeepEqual(savedNotifyCfg1, amqpNotify{}) {
t.Errorf("Expecting AMQP config %#v found %#v", amqpNotify{}, savedNotifyCfg1)
}
// Set new elastic search notification id.
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
globalServerConfig.Notify.SetElasticSearchByID("2", elasticSearchNotify{})
savedNotifyCfg2 := globalServerConfig.Notify.GetElasticSearchByID("2")
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
if !reflect.DeepEqual(savedNotifyCfg2, elasticSearchNotify{}) {
t.Errorf("Expecting Elasticsearch config %#v found %#v", elasticSearchNotify{}, savedNotifyCfg2)
}
// Set new redis notification id.
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
globalServerConfig.Notify.SetRedisByID("2", redisNotify{})
savedNotifyCfg3 := globalServerConfig.Notify.GetRedisByID("2")
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
if !reflect.DeepEqual(savedNotifyCfg3, redisNotify{}) {
t.Errorf("Expecting Redis config %#v found %#v", redisNotify{}, savedNotifyCfg3)
}
Add support for Kafka as a notifications target (#2869) (#3439)
2016-12-16 00:23:48 +08:00
// Set new kafka notification id.
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
globalServerConfig.Notify.SetKafkaByID("2", kafkaNotify{})
savedNotifyCfg4 := globalServerConfig.Notify.GetKafkaByID("2")
Add support for Kafka as a notifications target (#2869) (#3439)
2016-12-16 00:23:48 +08:00
if !reflect.DeepEqual(savedNotifyCfg4, kafkaNotify{}) {
t.Errorf("Expecting Kafka config %#v found %#v", kafkaNotify{}, savedNotifyCfg4)
}
Add notifications by webhook. Add a new config entry moving to version 13. ``` "webhook": { "1": { "enable": true, "address": "http://requestb.in/1i9al7m1" } } ```
2017-01-10 06:22:10 +08:00
// Set new Webhook notification id.
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
globalServerConfig.Notify.SetWebhookByID("2", webhookNotify{})
savedNotifyCfg5 := globalServerConfig.Notify.GetWebhookByID("2")
Add notifications by webhook. Add a new config entry moving to version 13. ``` "webhook": { "1": { "enable": true, "address": "http://requestb.in/1i9al7m1" } } ```
2017-01-10 06:22:10 +08:00
if !reflect.DeepEqual(savedNotifyCfg5, webhookNotify{}) {
Add support for MySQL notifications (fixes #3818) (#3907) As a new configuration parameter is added, configuration version is bumped up from 14 to 15. The MySQL target's behaviour is identical to the PostgreSQL: rows are deleted from the MySQL table on delete-object events, and are created/updated on create/over-write events.
2017-03-18 00:29:17 +08:00
t.Errorf("Expecting Webhook config %#v found %#v", webhookNotify{}, savedNotifyCfg5)
Add notifications by webhook. Add a new config entry moving to version 13. ``` "webhook": { "1": { "enable": true, "address": "http://requestb.in/1i9al7m1" } } ```
2017-01-10 06:22:10 +08:00
}
Add support for MQTT server as a notification target (#4474) This implementation is similar to AMQP notifications: * Notifications are published on a single topic as a JSON feed * Topic is configurable, as is the QoS. Uses the paho.mqtt.golang library for the mqtt connection, and supports connections over tcp and websockets, with optional secure tls support. * Additionally the minio server configuration has been bumped up so mqtt configuration can be added. * Configuration migration code is added with tests. MQTT is an ISO standard M2M/IoT messaging protocol and was originally designed for applications for limited bandwidth networks. Today it's use is growing in the IoT space.
2017-06-15 08:27:03 +08:00
// Set new MySQL notification id.
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
globalServerConfig.Notify.SetMySQLByID("2", mySQLNotify{})
savedNotifyCfg6 := globalServerConfig.Notify.GetMySQLByID("2")
Add support for MySQL notifications (fixes #3818) (#3907) As a new configuration parameter is added, configuration version is bumped up from 14 to 15. The MySQL target's behaviour is identical to the PostgreSQL: rows are deleted from the MySQL table on delete-object events, and are created/updated on create/over-write events.
2017-03-18 00:29:17 +08:00
if !reflect.DeepEqual(savedNotifyCfg6, mySQLNotify{}) {
t.Errorf("Expecting Webhook config %#v found %#v", mySQLNotify{}, savedNotifyCfg6)
}
Add support for MQTT server as a notification target (#4474) This implementation is similar to AMQP notifications: * Notifications are published on a single topic as a JSON feed * Topic is configurable, as is the QoS. Uses the paho.mqtt.golang library for the mqtt connection, and supports connections over tcp and websockets, with optional secure tls support. * Additionally the minio server configuration has been bumped up so mqtt configuration can be added. * Configuration migration code is added with tests. MQTT is an ISO standard M2M/IoT messaging protocol and was originally designed for applications for limited bandwidth networks. Today it's use is growing in the IoT space.
2017-06-15 08:27:03 +08:00
// Set new MQTT notification id.
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
globalServerConfig.Notify.SetMQTTByID("2", mqttNotify{})
savedNotifyCfg7 := globalServerConfig.Notify.GetMQTTByID("2")
Add support for MQTT server as a notification target (#4474) This implementation is similar to AMQP notifications: * Notifications are published on a single topic as a JSON feed * Topic is configurable, as is the QoS. Uses the paho.mqtt.golang library for the mqtt connection, and supports connections over tcp and websockets, with optional secure tls support. * Additionally the minio server configuration has been bumped up so mqtt configuration can be added. * Configuration migration code is added with tests. MQTT is an ISO standard M2M/IoT messaging protocol and was originally designed for applications for limited bandwidth networks. Today it's use is growing in the IoT space.
2017-06-15 08:27:03 +08:00
if !reflect.DeepEqual(savedNotifyCfg7, mqttNotify{}) {
t.Errorf("Expecting Webhook config %#v found %#v", mqttNotify{}, savedNotifyCfg7)
}
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
// Match version.
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
if globalServerConfig.GetVersion() != serverConfigVersion {
t.Errorf("Expecting version %s found %s", globalServerConfig.GetVersion(), serverConfigVersion)
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
}
// Attempt to save.
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
if err := globalServerConfig.Save(); err != nil {
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
t.Fatalf("Unable to save updated config file %s", err)
}
// Do this only once here.
Remove globalQuiet and globalConfigDir global variables (#3830)
2017-03-03 06:21:30 +08:00
setConfigDir(rootPath)
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
// Initialize server config.
server: handle command line and env variables at one place. (#3975)
2017-03-31 02:21:19 +08:00
if err := loadConfig(); err != nil {
Move config to v7 to fix previous v6 bug on null Notification entries. (#2650) Thanks to @koolhead17 for reporting this.
2016-09-10 15:51:25 +08:00
t.Fatalf("Unable to initialize from updated config file %s", err)
}
}
config: Add browser parameter (#3807) browser new parameter receives "on" or "off" parameter which is similar to MINIO_BROWSER
2017-02-28 06:59:53 +08:00
func TestServerConfigWithEnvs(t *testing.T) {
os.Setenv("MINIO_BROWSER", "off")
defer os.Unsetenv("MINIO_BROWSER")
os.Setenv("MINIO_ACCESS_KEY", "minio")
defer os.Unsetenv("MINIO_ACCESS_KEY")
os.Setenv("MINIO_SECRET_KEY", "minio123")
defer os.Unsetenv("MINIO_SECRET_KEY")
server: Introduce a new env MINIO_REGION. (#4078) This is implemented to be able to override region through command line just like how access and secret keys are provided.
2017-04-10 01:44:10 +08:00
os.Setenv("MINIO_REGION", "us-west-1")
defer os.Unsetenv("MINIO_REGION")
Virtual host style S3 requests (#5095)
2017-11-15 08:56:24 +08:00
os.Setenv("MINIO_DOMAIN", "domain.com")
defer os.Unsetenv("MINIO_DOMAIN")
server: Introduce a new env MINIO_REGION. (#4078) This is implemented to be able to override region through command line just like how access and secret keys are provided.
2017-04-10 01:44:10 +08:00
defer resetGlobalIsEnvs()
config: Add browser parameter (#3807) browser new parameter receives "on" or "off" parameter which is similar to MINIO_BROWSER
2017-02-28 06:59:53 +08:00
// Get test root.
rootPath, err := getTestRoot()
if err != nil {
t.Error(err)
}
server: handle command line and env variables at one place. (#3975)
2017-03-31 02:21:19 +08:00
serverHandleEnvVars()
config: Add browser parameter (#3807) browser new parameter receives "on" or "off" parameter which is similar to MINIO_BROWSER
2017-02-28 06:59:53 +08:00
// Do this only once here.
Remove globalQuiet and globalConfigDir global variables (#3830)
2017-03-03 06:21:30 +08:00
setConfigDir(rootPath)
config: Add browser parameter (#3807) browser new parameter receives "on" or "off" parameter which is similar to MINIO_BROWSER
2017-02-28 06:59:53 +08:00
// Init config
initConfig()
// remove the root directory after the test ends.
posix: Deprecate custom removeAll/mkdirAll implementations. (#4808) Since go1.8 os.RemoveAll and os.MkdirAll both support long path names i.e UNC path on windows. The code we are carrying was directly borrowed from `pkg/os` package and doesn't need to be in our repo anymore. As a side affect this also addresses our codecoverage issue. Refer #4658
2017-08-13 10:25:43 +08:00
defer os.RemoveAll(rootPath)
config: Add browser parameter (#3807) browser new parameter receives "on" or "off" parameter which is similar to MINIO_BROWSER
2017-02-28 06:59:53 +08:00
// Check if serverConfig has
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
if globalServerConfig.GetBrowser() {
t.Errorf("Expecting browser is set to false found %v", globalServerConfig.GetBrowser())
config: Add browser parameter (#3807) browser new parameter receives "on" or "off" parameter which is similar to MINIO_BROWSER
2017-02-28 06:59:53 +08:00
}
server: Introduce a new env MINIO_REGION. (#4078) This is implemented to be able to override region through command line just like how access and secret keys are provided.
2017-04-10 01:44:10 +08:00
// Check if serverConfig has
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
if globalServerConfig.GetRegion() != "us-west-1" {
t.Errorf("Expecting region to be \"us-west-1\" found %v", globalServerConfig.GetRegion())
server: Introduce a new env MINIO_REGION. (#4078) This is implemented to be able to override region through command line just like how access and secret keys are provided.
2017-04-10 01:44:10 +08:00
}
config: Add browser parameter (#3807) browser new parameter receives "on" or "off" parameter which is similar to MINIO_BROWSER
2017-02-28 06:59:53 +08:00
// Check if serverConfig has
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
cred := globalServerConfig.GetCredential()
config: Add browser parameter (#3807) browser new parameter receives "on" or "off" parameter which is similar to MINIO_BROWSER
2017-02-28 06:59:53 +08:00
if cred.AccessKey != "minio" {
t.Errorf("Expecting access key to be `minio` found %s", cred.AccessKey)
}
if cred.SecretKey != "minio123" {
t.Errorf("Expecting access key to be `minio123` found %s", cred.SecretKey)
}
server: Introduce a new env MINIO_REGION. (#4078) This is implemented to be able to override region through command line just like how access and secret keys are provided.
2017-04-10 01:44:10 +08:00
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
if globalServerConfig.Domain != "domain.com" {
t.Errorf("Expecting Domain to be `domain.com` found " + globalServerConfig.Domain)
Virtual host style S3 requests (#5095)
2017-11-15 08:56:24 +08:00
}
config: Add browser parameter (#3807) browser new parameter receives "on" or "off" parameter which is similar to MINIO_BROWSER
2017-02-28 06:59:53 +08:00
}
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
func TestCheckDupJSONKeys(t *testing.T) {
testCases := []struct {
json string
shouldPass bool
}{
{`{}`, true},
{`{"version" : "13"}`, true},
{`{"version" : "13", "version": "14"}`, false},
{`{"version" : "13", "credential": {"accessKey": "12345"}}`, true},
{`{"version" : "13", "credential": {"accessKey": "12345", "accessKey":"12345"}}`, false},
{`{"version" : "13", "notify": {"amqp": {"1"}, "webhook":{"3"}}}`, true},
{`{"version" : "13", "notify": {"amqp": {"1"}, "amqp":{"3"}}}`, false},
{`{"version" : "13", "notify": {"amqp": {"1":{}, "2":{}}}}`, true},
{`{"version" : "13", "notify": {"amqp": {"1":{}, "1":{}}}}`, false},
}
for i, testCase := range testCases {
err := doCheckDupJSONKeys(gjson.Result{}, gjson.Parse(testCase.json))
if testCase.shouldPass && err != nil {
t.Errorf("Test %d, should pass but it failed with err = %v", i+1, err)
}
if !testCase.shouldPass && err == nil {
t.Errorf("Test %d, should fail but it succeed.", i+1)
}
}
}
config: Relax browser and region to be empty. (#3912) - If browser field is missing or empty then default to "on". - If region field is empty or missing then default to "us-east-1" (S3 spec behavior)
2017-03-17 02:06:17 +08:00
// Tests config validator..
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
func TestValidateConfig(t *testing.T) {
rootPath, err := newTestConfig(globalMinioDefaultRegion)
if err != nil {
t.Fatalf("Init Test config failed")
}
config: Relax browser and region to be empty. (#3912) - If browser field is missing or empty then default to "on". - If region field is empty or missing then default to "us-east-1" (S3 spec behavior)
2017-03-17 02:06:17 +08:00
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
// remove the root directory after the test ends.
posix: Deprecate custom removeAll/mkdirAll implementations. (#4808) Since go1.8 os.RemoveAll and os.MkdirAll both support long path names i.e UNC path on windows. The code we are carrying was directly borrowed from `pkg/os` package and doesn't need to be in our repo anymore. As a side affect this also addresses our codecoverage issue. Refer #4658
2017-08-13 10:25:43 +08:00
defer os.RemoveAll(rootPath)
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
configPath := filepath.Join(rootPath, minioConfigFile)
Simplify the steps to make changes to config.json (#5186) This change introduces following simplified steps to follow during config migration. ``` // Steps to move from version N to version N+1 // 1. Add new struct serverConfigVN+1 in config-versions.go // 2. Set configCurrentVersion to "N+1" // 3. Set serverConfigCurrent to serverConfigVN+1 // 4. Add new migration function (ex. func migrateVNToVN+1()) in config-migrate.go // 5. Call migrateVNToVN+1() from migrateConfig() in config-migrate.go // 6. Make changes in config-current_test.go for any test change ```
2017-11-30 05:12:47 +08:00
v := serverConfigVersion
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
testCases := []struct {
configData string
shouldPass bool
}{
// Test 1 - wrong json
{`{`, false},
// Test 2 - empty json
{`{}`, false},
// Test 3 - wrong config version
{`{"version": "10"}`, false},
// Test 4 - wrong browser parameter
{`{"version": "` + v + `", "browser": "foo"}`, false},
// Test 5 - missing credential
{`{"version": "` + v + `", "browser": "on"}`, false},
// Test 6 - missing secret key
{`{"version": "` + v + `", "browser": "on", "credential" : {"accessKey":"minio", "secretKey":""}}`, false},
config: Relax browser and region to be empty. (#3912) - If browser field is missing or empty then default to "on". - If region field is empty or missing then default to "us-east-1" (S3 spec behavior)
2017-03-17 02:06:17 +08:00
// Test 7 - missing region should pass, defaults to 'us-east-1'.
{`{"version": "` + v + `", "browser": "on", "credential" : {"accessKey":"minio", "secretKey":"minio123"}}`, true},
// Test 8 - missing browser should pass, defaults to 'on'.
{`{"version": "` + v + `", "region": "us-east-1", "credential" : {"accessKey":"minio", "secretKey":"minio123"}}`, true},
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
config: Relax browser and region to be empty. (#3912) - If browser field is missing or empty then default to "on". - If region field is empty or missing then default to "us-east-1" (S3 spec behavior)
2017-03-17 02:06:17 +08:00
// Test 9 - success
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
{`{"version": "` + v + `", "browser": "on", "region":"us-east-1", "credential" : {"accessKey":"minio", "secretKey":"minio123"}}`, true},
config: Relax browser and region to be empty. (#3912) - If browser field is missing or empty then default to "on". - If region field is empty or missing then default to "us-east-1" (S3 spec behavior)
2017-03-17 02:06:17 +08:00
// Test 10 - duplicated json keys
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
{`{"version": "` + v + `", "browser": "on", "browser": "on", "region":"us-east-1", "credential" : {"accessKey":"minio", "secretKey":"minio123"}}`, false},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 11 - Test AMQP
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "amqp": { "1": { "enable": true, "url": "", "exchange": "", "routingKey": "", "exchangeType": "", "mandatory": false, "immediate": false, "durable": false, "internal": false, "noWait": false, "autoDeleted": false }}}}`, false},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 12 - Test NATS
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "nats": { "1": { "enable": true, "address": "", "subject": "", "username": "", "password": "", "token": "", "secure": false, "pingInterval": 0, "streaming": { "enable": false, "clusterID": "", "clientID": "", "async": false, "maxPubAcksInflight": 0 } } }}}`, false},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 13 - Test ElasticSearch
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "elasticsearch": { "1": { "enable": true, "url": "", "index": "" } }}}`, false},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 14 - Test Redis
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "redis": { "1": { "enable": true, "address": "", "password": "", "key": "" } }}}`, false},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 15 - Test PostgreSQL
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "postgresql": { "1": { "enable": true, "connectionString": "", "table": "", "host": "", "port": "", "user": "", "password": "", "database": "" }}}}`, false},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 16 - Test Kafka
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "kafka": { "1": { "enable": true, "brokers": null, "topic": "" } }}}`, false},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 17 - Test Webhook
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "webhook": { "1": { "enable": true, "endpoint": "" } }}}`, false},
Add support for MySQL notifications (fixes #3818) (#3907) As a new configuration parameter is added, configuration version is bumped up from 14 to 15. The MySQL target's behaviour is identical to the PostgreSQL: rows are deleted from the MySQL table on delete-object events, and are created/updated on create/over-write events.
2017-03-18 00:29:17 +08:00
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 18 - Test MySQL
Add support for MySQL notifications (fixes #3818) (#3907) As a new configuration parameter is added, configuration version is bumped up from 14 to 15. The MySQL target's behaviour is identical to the PostgreSQL: rows are deleted from the MySQL table on delete-object events, and are created/updated on create/over-write events.
2017-03-18 00:29:17 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "mysql": { "1": { "enable": true, "dsnString": "", "table": "", "host": "", "port": "", "user": "", "password": "", "database": "" }}}}`, false},
Support `access` format for database notification targets (#3953) * Add configuration parameter "format" for db targets and perform configuration migration. * Add PostgreSQL `access` format: This causes Minio to append all events to the configured table. Prefix, suffix and event filters continue to be supported for this mode too. * Update documentation for PostgreSQL notification target. * Add MySQL `access` format: It is very similar to the same format for PostgreSQL. * Update MySQL notification documentation.
2017-03-28 02:27:25 +08:00
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 19 - Test Format for MySQL
Support `access` format for database notification targets (#3953) * Add configuration parameter "format" for db targets and perform configuration migration. * Add PostgreSQL `access` format: This causes Minio to append all events to the configured table. Prefix, suffix and event filters continue to be supported for this mode too. * Update documentation for PostgreSQL notification target. * Add MySQL `access` format: It is very similar to the same format for PostgreSQL. * Update MySQL notification documentation.
2017-03-28 02:27:25 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "mysql": { "1": { "enable": true, "dsnString": "", "format": "invalid", "table": "xxx", "host": "10.0.0.1", "port": "3306", "user": "abc", "password": "pqr", "database": "test1" }}}}`, false},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 20 - Test valid Format for MySQL
Support `access` format for database notification targets (#3953) * Add configuration parameter "format" for db targets and perform configuration migration. * Add PostgreSQL `access` format: This causes Minio to append all events to the configured table. Prefix, suffix and event filters continue to be supported for this mode too. * Update documentation for PostgreSQL notification target. * Add MySQL `access` format: It is very similar to the same format for PostgreSQL. * Update MySQL notification documentation.
2017-03-28 02:27:25 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "mysql": { "1": { "enable": true, "dsnString": "", "format": "namespace", "table": "xxx", "host": "10.0.0.1", "port": "3306", "user": "abc", "password": "pqr", "database": "test1" }}}}`, true},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 21 - Test Format for PostgreSQL
Support `access` format for database notification targets (#3953) * Add configuration parameter "format" for db targets and perform configuration migration. * Add PostgreSQL `access` format: This causes Minio to append all events to the configured table. Prefix, suffix and event filters continue to be supported for this mode too. * Update documentation for PostgreSQL notification target. * Add MySQL `access` format: It is very similar to the same format for PostgreSQL. * Update MySQL notification documentation.
2017-03-28 02:27:25 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "postgresql": { "1": { "enable": true, "connectionString": "", "format": "invalid", "table": "xxx", "host": "myhost", "port": "5432", "user": "abc", "password": "pqr", "database": "test1" }}}}`, false},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 22 - Test valid Format for PostgreSQL
Support `access` format for database notification targets (#3953) * Add configuration parameter "format" for db targets and perform configuration migration. * Add PostgreSQL `access` format: This causes Minio to append all events to the configured table. Prefix, suffix and event filters continue to be supported for this mode too. * Update documentation for PostgreSQL notification target. * Add MySQL `access` format: It is very similar to the same format for PostgreSQL. * Update MySQL notification documentation.
2017-03-28 02:27:25 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "postgresql": { "1": { "enable": true, "connectionString": "", "format": "namespace", "table": "xxx", "host": "myhost", "port": "5432", "user": "abc", "password": "pqr", "database": "test1" }}}}`, true},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 23 - Test Format for ElasticSearch
Support `access` format for database notification targets (#3953) * Add configuration parameter "format" for db targets and perform configuration migration. * Add PostgreSQL `access` format: This causes Minio to append all events to the configured table. Prefix, suffix and event filters continue to be supported for this mode too. * Update documentation for PostgreSQL notification target. * Add MySQL `access` format: It is very similar to the same format for PostgreSQL. * Update MySQL notification documentation.
2017-03-28 02:27:25 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "elasticsearch": { "1": { "enable": true, "format": "invalid", "url": "example.com", "index": "myindex" } }}}`, false},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 24 - Test valid Format for ElasticSearch
Support `access` format for database notification targets (#3953) * Add configuration parameter "format" for db targets and perform configuration migration. * Add PostgreSQL `access` format: This causes Minio to append all events to the configured table. Prefix, suffix and event filters continue to be supported for this mode too. * Update documentation for PostgreSQL notification target. * Add MySQL `access` format: It is very similar to the same format for PostgreSQL. * Update MySQL notification documentation.
2017-03-28 02:27:25 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "elasticsearch": { "1": { "enable": true, "format": "namespace", "url": "example.com", "index": "myindex" } }}}`, true},
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 25 - Test Format for Redis
notifiers: Stop using url.Parse in validating address format. (#4011) url.Parse() wrongly parses an address of format "address:port" which is fixed in go1.8. This inculcates a breaking change on our end. We should fix this wrong usage everywhere so that migrating to go1.8 eventually becomes smoother.
2017-03-31 19:47:40 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "redis": { "1": { "enable": true, "format": "invalid", "address": "example.com:80", "password": "xxx", "key": "key1" } }}}`, false},
Support `access` format for database notification targets (#3953) * Add configuration parameter "format" for db targets and perform configuration migration. * Add PostgreSQL `access` format: This causes Minio to append all events to the configured table. Prefix, suffix and event filters continue to be supported for this mode too. * Update documentation for PostgreSQL notification target. * Add MySQL `access` format: It is very similar to the same format for PostgreSQL. * Update MySQL notification documentation.
2017-03-28 02:27:25 +08:00
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 26 - Test valid Format for Redis
notifiers: Stop using url.Parse in validating address format. (#4011) url.Parse() wrongly parses an address of format "address:port" which is fixed in go1.8. This inculcates a breaking change on our end. We should fix this wrong usage everywhere so that migrating to go1.8 eventually becomes smoother.
2017-03-31 19:47:40 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "redis": { "1": { "enable": true, "format": "namespace", "address": "example.com:80", "password": "xxx", "key": "key1" } }}}`, true},
Add support for MQTT server as a notification target (#4474) This implementation is similar to AMQP notifications: * Notifications are published on a single topic as a JSON feed * Topic is configurable, as is the QoS. Uses the paho.mqtt.golang library for the mqtt connection, and supports connections over tcp and websockets, with optional secure tls support. * Additionally the minio server configuration has been bumped up so mqtt configuration can be added. * Configuration migration code is added with tests. MQTT is an ISO standard M2M/IoT messaging protocol and was originally designed for applications for limited bandwidth networks. Today it's use is growing in the IoT space.
2017-06-15 08:27:03 +08:00
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
// Test 27 - Test MQTT
Add support for MQTT server as a notification target (#4474) This implementation is similar to AMQP notifications: * Notifications are published on a single topic as a JSON feed * Topic is configurable, as is the QoS. Uses the paho.mqtt.golang library for the mqtt connection, and supports connections over tcp and websockets, with optional secure tls support. * Additionally the minio server configuration has been bumped up so mqtt configuration can be added. * Configuration migration code is added with tests. MQTT is an ISO standard M2M/IoT messaging protocol and was originally designed for applications for limited bandwidth networks. Today it's use is growing in the IoT space.
2017-06-15 08:27:03 +08:00
{`{"version": "` + v + `", "credential": { "accessKey": "minio", "secretKey": "minio123" }, "region": "us-east-1", "browser": "on", "notify": { "mqtt": { "1": { "enable": true, "broker": "", "topic": "", "qos": 0, "clientId": "", "username": "", "password": ""}}}}`, false},
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
}
for i, testCase := range testCases {
config: Relax browser and region to be empty. (#3912) - If browser field is missing or empty then default to "on". - If region field is empty or missing then default to "us-east-1" (S3 spec behavior)
2017-03-17 02:06:17 +08:00
if werr := ioutil.WriteFile(configPath, []byte(testCase.configData), 0700); werr != nil {
t.Fatal(werr)
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
}
fix: use its own lock in serverConfigV17 (#4014) Previously serverConfigV17 used a global lock that made any instance of serverConfigV17 depended on single global serverConfigMu. This patch fixes by having individual lock per instances.
2017-03-31 13:26:24 +08:00
_, verr := getValidConfig()
config: Relax browser and region to be empty. (#3912) - If browser field is missing or empty then default to "on". - If region field is empty or missing then default to "us-east-1" (S3 spec behavior)
2017-03-17 02:06:17 +08:00
if testCase.shouldPass && verr != nil {
t.Errorf("Test %d, should pass but it failed with err = %v", i+1, verr)
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
}
config: Relax browser and region to be empty. (#3912) - If browser field is missing or empty then default to "on". - If region field is empty or missing then default to "us-east-1" (S3 spec behavior)
2017-03-17 02:06:17 +08:00
if !testCase.shouldPass && verr == nil {
Remove "logger" field from config.json (#5268) File logging removed as part of improvement to server logging. config.json format updated to version 21. Fixes #5176
2017-12-06 15:18:29 +08:00
t.Errorf("Test %d, should fail but it succeeded.", i+1)
config: Check for duplicated entries in all scopes (#3872) Validate Minio config by checking if there is double json key in any scope level. The returned error contains the json path to the duplicated key.
2017-03-16 07:30:34 +08:00
}
}
}