| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | /* | 
					
						
							|  |  |  |  * MinIO Cloud Storage, (C) 2020 MinIO, Inc. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Licensed under the Apache License, Version 2.0 (the "License"); | 
					
						
							|  |  |  |  * you may not use this file except in compliance with the License. | 
					
						
							|  |  |  |  * You may obtain a copy of the License at | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  *     http://www.apache.org/licenses/LICENSE-2.0
 | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Unless required by applicable law or agreed to in writing, software | 
					
						
							|  |  |  |  * distributed under the License is distributed on an "AS IS" BASIS, | 
					
						
							|  |  |  |  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | 
					
						
							|  |  |  |  * See the License for the specific language governing permissions and | 
					
						
							|  |  |  |  * limitations under the License. | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | package cmd | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | import ( | 
					
						
							| 
									
										
										
										
											2021-02-25 14:24:38 +08:00
										 |  |  | 	"bytes" | 
					
						
							|  |  |  | 	"context" | 
					
						
							|  |  |  | 	"errors" | 
					
						
							|  |  |  | 	"fmt" | 
					
						
							|  |  |  | 	"net/http" | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 	"path" | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 	"runtime/debug" | 
					
						
							| 
									
										
										
										
											2021-02-09 03:36:16 +08:00
										 |  |  | 	"sort" | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 	"strings" | 
					
						
							|  |  |  | 	"sync" | 
					
						
							|  |  |  | 	"time" | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2021-02-25 14:24:38 +08:00
										 |  |  | 	"github.com/klauspost/compress/s2" | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 	"github.com/minio/minio/cmd/logger" | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 	"github.com/minio/minio/pkg/console" | 
					
						
							| 
									
										
										
										
											2021-02-25 14:24:38 +08:00
										 |  |  | 	"github.com/minio/minio/pkg/hash" | 
					
						
							|  |  |  | 	"github.com/tinylib/msgp/msgp" | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | ) | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | //go:generate msgp -file $GOFILE -unexported
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | // a bucketMetacache keeps track of all caches generated
 | 
					
						
							|  |  |  | // for a bucket.
 | 
					
						
							|  |  |  | type bucketMetacache struct { | 
					
						
							|  |  |  | 	// Name of bucket
 | 
					
						
							|  |  |  | 	bucket string | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	// caches indexed by id.
 | 
					
						
							|  |  |  | 	caches map[string]metacache | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 	// cache ids indexed by root paths
 | 
					
						
							|  |  |  | 	cachesRoot map[string][]string `msg:"-"` | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	// Internal state
 | 
					
						
							|  |  |  | 	mu        sync.RWMutex `msg:"-"` | 
					
						
							|  |  |  | 	updated   bool         `msg:"-"` | 
					
						
							|  |  |  | 	transient bool         `msg:"-"` // bucket used for non-persisted caches.
 | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | // newBucketMetacache creates a new bucketMetacache.
 | 
					
						
							| 
									
										
										
										
											2020-11-01 01:26:16 +08:00
										 |  |  | // Optionally remove all existing caches.
 | 
					
						
							| 
									
										
										
										
											2021-02-25 14:24:38 +08:00
										 |  |  | func newBucketMetacache(bucket string, cleanup bool) *bucketMetacache { | 
					
						
							|  |  |  | 	if cleanup { | 
					
						
							|  |  |  | 		// Recursively delete all caches.
 | 
					
						
							|  |  |  | 		objAPI := newObjectLayerFn() | 
					
						
							|  |  |  | 		ez, ok := objAPI.(*erasureServerPools) | 
					
						
							|  |  |  | 		if ok { | 
					
						
							|  |  |  | 			ctx := context.Background() | 
					
						
							|  |  |  | 			ez.renameAll(ctx, minioMetaBucket, metacachePrefixForID(bucket, slashSeparator)) | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 	return &bucketMetacache{ | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 		bucket:     bucket, | 
					
						
							|  |  |  | 		caches:     make(map[string]metacache, 10), | 
					
						
							|  |  |  | 		cachesRoot: make(map[string][]string, 10), | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | func (b *bucketMetacache) debugf(format string, data ...interface{}) { | 
					
						
							| 
									
										
										
										
											2020-12-18 08:52:47 +08:00
										 |  |  | 	if serverDebugLog { | 
					
						
							|  |  |  | 		console.Debugf(format+"\n", data...) | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2021-02-25 14:24:38 +08:00
										 |  |  | // loadBucketMetaCache will load the cache from the object layer.
 | 
					
						
							|  |  |  | // If the cache cannot be found a new one is created.
 | 
					
						
							|  |  |  | func loadBucketMetaCache(ctx context.Context, bucket string) (*bucketMetacache, error) { | 
					
						
							|  |  |  | 	objAPI := newObjectLayerFn() | 
					
						
							|  |  |  | 	for objAPI == nil { | 
					
						
							|  |  |  | 		select { | 
					
						
							|  |  |  | 		case <-ctx.Done(): | 
					
						
							|  |  |  | 			return nil, ctx.Err() | 
					
						
							|  |  |  | 		default: | 
					
						
							|  |  |  | 			time.Sleep(250 * time.Millisecond) | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 		objAPI = newObjectLayerFn() | 
					
						
							|  |  |  | 		if objAPI == nil { | 
					
						
							|  |  |  | 			logger.LogIf(ctx, fmt.Errorf("loadBucketMetaCache: object layer not ready. bucket: %q", bucket)) | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	var meta bucketMetacache | 
					
						
							|  |  |  | 	var decErr error | 
					
						
							|  |  |  | 	// Use global context for this.
 | 
					
						
							|  |  |  | 	r, err := objAPI.GetObjectNInfo(GlobalContext, minioMetaBucket, pathJoin("buckets", bucket, ".metacache", "index.s2"), nil, http.Header{}, readLock, ObjectOptions{}) | 
					
						
							|  |  |  | 	if err == nil { | 
					
						
							|  |  |  | 		dec := s2DecPool.Get().(*s2.Reader) | 
					
						
							|  |  |  | 		dec.Reset(r) | 
					
						
							|  |  |  | 		decErr = meta.DecodeMsg(msgp.NewReader(dec)) | 
					
						
							|  |  |  | 		dec.Reset(nil) | 
					
						
							|  |  |  | 		r.Close() | 
					
						
							|  |  |  | 		s2DecPool.Put(dec) | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	if err != nil { | 
					
						
							|  |  |  | 		switch err.(type) { | 
					
						
							|  |  |  | 		case ObjectNotFound: | 
					
						
							|  |  |  | 			err = nil | 
					
						
							|  |  |  | 		case InsufficientReadQuorum: | 
					
						
							|  |  |  | 			// Cache is likely lost. Clean up and return new.
 | 
					
						
							|  |  |  | 			return newBucketMetacache(bucket, true), nil | 
					
						
							|  |  |  | 		default: | 
					
						
							|  |  |  | 			logger.LogIf(ctx, err) | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 		return newBucketMetacache(bucket, false), err | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	if decErr != nil { | 
					
						
							|  |  |  | 		if errors.Is(err, context.Canceled) { | 
					
						
							|  |  |  | 			return newBucketMetacache(bucket, false), err | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 		// Log the error, but assume the data is lost and return a fresh bucket.
 | 
					
						
							|  |  |  | 		// Otherwise a broken cache will never recover.
 | 
					
						
							|  |  |  | 		logger.LogIf(ctx, decErr) | 
					
						
							|  |  |  | 		return newBucketMetacache(bucket, true), nil | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	// Sanity check...
 | 
					
						
							|  |  |  | 	if meta.bucket != bucket { | 
					
						
							|  |  |  | 		logger.Info("loadBucketMetaCache: loaded cache name mismatch, want %s, got %s. Discarding.", bucket, meta.bucket) | 
					
						
							|  |  |  | 		return newBucketMetacache(bucket, true), nil | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	meta.cachesRoot = make(map[string][]string, len(meta.caches)/10) | 
					
						
							|  |  |  | 	// Index roots
 | 
					
						
							|  |  |  | 	for id, cache := range meta.caches { | 
					
						
							|  |  |  | 		meta.cachesRoot[cache.root] = append(meta.cachesRoot[cache.root], id) | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	return &meta, nil | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | // save the bucket cache to the object storage.
 | 
					
						
							|  |  |  | func (b *bucketMetacache) save(ctx context.Context) error { | 
					
						
							|  |  |  | 	if b.transient { | 
					
						
							|  |  |  | 		return nil | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	objAPI := newObjectLayerFn() | 
					
						
							|  |  |  | 	if objAPI == nil { | 
					
						
							|  |  |  | 		return errServerNotInitialized | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	// Keep lock while we marshal.
 | 
					
						
							|  |  |  | 	// We need a write lock since we update 'updated'
 | 
					
						
							|  |  |  | 	b.mu.Lock() | 
					
						
							|  |  |  | 	if !b.updated { | 
					
						
							|  |  |  | 		b.mu.Unlock() | 
					
						
							|  |  |  | 		return nil | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	// Save as s2 compressed msgpack
 | 
					
						
							|  |  |  | 	tmp := bytes.NewBuffer(make([]byte, 0, b.Msgsize())) | 
					
						
							|  |  |  | 	enc := s2.NewWriter(tmp) | 
					
						
							|  |  |  | 	err := msgp.Encode(enc, b) | 
					
						
							|  |  |  | 	if err != nil { | 
					
						
							|  |  |  | 		b.mu.Unlock() | 
					
						
							|  |  |  | 		return err | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	err = enc.Close() | 
					
						
							|  |  |  | 	if err != nil { | 
					
						
							|  |  |  | 		b.mu.Unlock() | 
					
						
							|  |  |  | 		return err | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	b.updated = false | 
					
						
							|  |  |  | 	b.mu.Unlock() | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	hr, err := hash.NewReader(tmp, int64(tmp.Len()), "", "", int64(tmp.Len())) | 
					
						
							|  |  |  | 	if err != nil { | 
					
						
							|  |  |  | 		return err | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	_, err = objAPI.PutObject(ctx, minioMetaBucket, pathJoin("buckets", b.bucket, ".metacache", "index.s2"), NewPutObjReader(hr), ObjectOptions{}) | 
					
						
							|  |  |  | 	logger.LogIf(ctx, err) | 
					
						
							|  |  |  | 	return err | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | // findCache will attempt to find a matching cache for the provided options.
 | 
					
						
							|  |  |  | // If a cache with the same ID exists already it will be returned.
 | 
					
						
							|  |  |  | // If none can be found a new is created with the provided ID.
 | 
					
						
							|  |  |  | func (b *bucketMetacache) findCache(o listPathOptions) metacache { | 
					
						
							|  |  |  | 	if b == nil { | 
					
						
							|  |  |  | 		logger.Info("bucketMetacache.findCache: nil cache for bucket %s", o.Bucket) | 
					
						
							|  |  |  | 		return metacache{} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if o.Bucket != b.bucket && !b.transient { | 
					
						
							|  |  |  | 		logger.Info("bucketMetacache.findCache: bucket %s does not match this bucket %s", o.Bucket, b.bucket) | 
					
						
							|  |  |  | 		debug.PrintStack() | 
					
						
							|  |  |  | 		return metacache{} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 	extend := globalAPIConfig.getExtendListLife() | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	// Grab a write lock, since we create one if we cannot find one.
 | 
					
						
							|  |  |  | 	if o.Create { | 
					
						
							|  |  |  | 		b.mu.Lock() | 
					
						
							|  |  |  | 		defer b.mu.Unlock() | 
					
						
							|  |  |  | 	} else { | 
					
						
							|  |  |  | 		b.mu.RLock() | 
					
						
							|  |  |  | 		defer b.mu.RUnlock() | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	// Check if exists already.
 | 
					
						
							|  |  |  | 	if c, ok := b.caches[o.ID]; ok { | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 		b.debugf("returning existing %v", o.ID) | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 		return c | 
					
						
							|  |  |  | 	} | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 	// No need to do expensive checks on transients.
 | 
					
						
							|  |  |  | 	if b.transient { | 
					
						
							|  |  |  | 		if !o.Create { | 
					
						
							|  |  |  | 			return metacache{ | 
					
						
							|  |  |  | 				id:     o.ID, | 
					
						
							|  |  |  | 				bucket: o.Bucket, | 
					
						
							|  |  |  | 				status: scanStateNone, | 
					
						
							|  |  |  | 			} | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		// Create new
 | 
					
						
							|  |  |  | 		best := o.newMetacache() | 
					
						
							|  |  |  | 		b.caches[o.ID] = best | 
					
						
							|  |  |  | 		b.updated = true | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 		b.debugf("returning new cache %s, bucket: %v", best.id, best.bucket) | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 		return best | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 	var best metacache | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 	rootSplit := strings.Split(o.BaseDir, slashSeparator) | 
					
						
							|  |  |  | 	for i := range rootSplit { | 
					
						
							|  |  |  | 		interesting := b.cachesRoot[path.Join(rootSplit[:i+1]...)] | 
					
						
							| 
									
										
										
										
											2020-11-06 03:49:56 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 		for _, id := range interesting { | 
					
						
							|  |  |  | 			cached, ok := b.caches[id] | 
					
						
							|  |  |  | 			if !ok { | 
					
						
							| 
									
										
										
										
											2020-11-06 03:49:56 +08:00
										 |  |  | 				continue | 
					
						
							|  |  |  | 			} | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 			if !cached.matches(&o, extend) { | 
					
						
							| 
									
										
										
										
											2020-11-06 03:49:56 +08:00
										 |  |  | 				continue | 
					
						
							|  |  |  | 			} | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 			if cached.started.Before(best.started) { | 
					
						
							|  |  |  | 				b.debugf("cache %s disregarded - we have a better", cached.id) | 
					
						
							|  |  |  | 				// If we already have a newer, keep that.
 | 
					
						
							|  |  |  | 				continue | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 			} | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 			best = cached | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	if !best.started.IsZero() { | 
					
						
							|  |  |  | 		if o.Create { | 
					
						
							|  |  |  | 			best.lastHandout = UTCNow() | 
					
						
							|  |  |  | 			b.caches[best.id] = best | 
					
						
							|  |  |  | 			b.updated = true | 
					
						
							|  |  |  | 		} | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 		b.debugf("returning cached %s, status: %v, ended: %v", best.id, best.status, best.ended) | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 		return best | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	if !o.Create { | 
					
						
							|  |  |  | 		return metacache{ | 
					
						
							|  |  |  | 			id:     o.ID, | 
					
						
							|  |  |  | 			bucket: o.Bucket, | 
					
						
							|  |  |  | 			status: scanStateNone, | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	// Create new and add.
 | 
					
						
							|  |  |  | 	best = o.newMetacache() | 
					
						
							|  |  |  | 	b.caches[o.ID] = best | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 	b.cachesRoot[best.root] = append(b.cachesRoot[best.root], best.id) | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 	b.updated = true | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 	b.debugf("returning new cache %s, bucket: %v", best.id, best.bucket) | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 	return best | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | // cleanup removes redundant and outdated entries.
 | 
					
						
							|  |  |  | func (b *bucketMetacache) cleanup() { | 
					
						
							|  |  |  | 	// Entries to remove.
 | 
					
						
							|  |  |  | 	remove := make(map[string]struct{}) | 
					
						
							|  |  |  | 	currentCycle := intDataUpdateTracker.current() | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-12-11 04:30:28 +08:00
										 |  |  | 	// Test on a copy
 | 
					
						
							|  |  |  | 	// cleanup is the only one deleting caches.
 | 
					
						
							|  |  |  | 	caches, rootIdx := b.cloneCaches() | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	for id, cache := range caches { | 
					
						
							| 
									
										
										
										
											2021-02-12 02:22:03 +08:00
										 |  |  | 		if b.transient && time.Since(cache.lastUpdate) > 10*time.Minute && time.Since(cache.lastHandout) > 10*time.Minute { | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 			// Keep transient caches only for 15 minutes.
 | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 			remove[id] = struct{}{} | 
					
						
							| 
									
										
										
										
											2020-11-05 00:01:33 +08:00
										 |  |  | 			continue | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 		} | 
					
						
							|  |  |  | 		if !cache.worthKeeping(currentCycle) { | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 			b.debugf("cache %s not worth keeping", id) | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 			remove[id] = struct{}{} | 
					
						
							| 
									
										
										
										
											2020-11-05 00:01:33 +08:00
										 |  |  | 			continue | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 		} | 
					
						
							|  |  |  | 		if cache.id != id { | 
					
						
							|  |  |  | 			logger.Info("cache ID mismatch %s != %s", id, cache.id) | 
					
						
							|  |  |  | 			remove[id] = struct{}{} | 
					
						
							| 
									
										
										
										
											2020-11-05 00:01:33 +08:00
										 |  |  | 			continue | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 		} | 
					
						
							|  |  |  | 		if cache.bucket != b.bucket && !b.transient { | 
					
						
							|  |  |  | 			logger.Info("cache bucket mismatch %s != %s", b.bucket, cache.bucket) | 
					
						
							|  |  |  | 			remove[id] = struct{}{} | 
					
						
							| 
									
										
										
										
											2020-11-05 00:01:33 +08:00
										 |  |  | 			continue | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	// Check all non-deleted against eachother.
 | 
					
						
							|  |  |  | 	// O(n*n), but should still be rather quick.
 | 
					
						
							| 
									
										
										
										
											2020-12-11 04:30:28 +08:00
										 |  |  | 	for id, cache := range caches { | 
					
						
							| 
									
										
										
										
											2020-11-05 00:01:33 +08:00
										 |  |  | 		if b.transient { | 
					
						
							|  |  |  | 			break | 
					
						
							|  |  |  | 		} | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 		if _, ok := remove[id]; ok { | 
					
						
							|  |  |  | 			continue | 
					
						
							|  |  |  | 		} | 
					
						
							| 
									
										
										
										
											2020-12-11 04:30:28 +08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 		interesting := interestingCaches(cache.root, rootIdx) | 
					
						
							|  |  |  | 		for _, id2 := range interesting { | 
					
						
							|  |  |  | 			if _, ok := remove[id2]; ok || id2 == id { | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 				// Don't check against one we are already removing
 | 
					
						
							|  |  |  | 				continue | 
					
						
							|  |  |  | 			} | 
					
						
							| 
									
										
										
										
											2020-12-11 04:30:28 +08:00
										 |  |  | 			cache2, ok := caches[id2] | 
					
						
							|  |  |  | 			if !ok { | 
					
						
							|  |  |  | 				continue | 
					
						
							|  |  |  | 			} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 			if cache.canBeReplacedBy(&cache2) { | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 				b.debugf("cache %s can be replaced by %s", id, cache2.id) | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 				remove[id] = struct{}{} | 
					
						
							|  |  |  | 				break | 
					
						
							|  |  |  | 			} else { | 
					
						
							| 
									
										
										
										
											2020-12-15 05:13:33 +08:00
										 |  |  | 				b.debugf("cache %s can be NOT replaced by %s", id, cache2.id) | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 			} | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2021-02-09 03:36:16 +08:00
										 |  |  | 	// If above limit, remove the caches with the oldest handout time.
 | 
					
						
							|  |  |  | 	if len(caches)-len(remove) > metacacheMaxEntries { | 
					
						
							|  |  |  | 		remainCaches := make([]metacache, 0, len(caches)-len(remove)) | 
					
						
							|  |  |  | 		for id, cache := range caches { | 
					
						
							|  |  |  | 			if _, ok := remove[id]; ok { | 
					
						
							|  |  |  | 				continue | 
					
						
							|  |  |  | 			} | 
					
						
							|  |  |  | 			remainCaches = append(remainCaches, cache) | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 		if len(remainCaches) > metacacheMaxEntries { | 
					
						
							|  |  |  | 			// Sort oldest last...
 | 
					
						
							|  |  |  | 			sort.Slice(remainCaches, func(i, j int) bool { | 
					
						
							|  |  |  | 				return remainCaches[i].lastHandout.Before(remainCaches[j].lastHandout) | 
					
						
							|  |  |  | 			}) | 
					
						
							|  |  |  | 			// Keep first metacacheMaxEntries...
 | 
					
						
							|  |  |  | 			for _, cache := range remainCaches[metacacheMaxEntries:] { | 
					
						
							| 
									
										
										
										
											2021-02-12 02:22:03 +08:00
										 |  |  | 				if time.Since(cache.lastHandout) > 30*time.Minute { | 
					
						
							| 
									
										
										
										
											2021-02-09 03:36:16 +08:00
										 |  |  | 					remove[cache.id] = struct{}{} | 
					
						
							|  |  |  | 				} | 
					
						
							|  |  |  | 			} | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 	for id := range remove { | 
					
						
							|  |  |  | 		b.deleteCache(id) | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-12-11 04:30:28 +08:00
										 |  |  | // Potentially interesting caches.
 | 
					
						
							|  |  |  | // Will only add root if request is for root.
 | 
					
						
							|  |  |  | func interestingCaches(root string, cachesRoot map[string][]string) []string { | 
					
						
							|  |  |  | 	var interesting []string | 
					
						
							|  |  |  | 	rootSplit := strings.Split(root, slashSeparator) | 
					
						
							|  |  |  | 	for i := range rootSplit { | 
					
						
							|  |  |  | 		want := path.Join(rootSplit[:i+1]...) | 
					
						
							|  |  |  | 		interesting = append(interesting, cachesRoot[want]...) | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	return interesting | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | // updateCache will update a cache by id.
 | 
					
						
							|  |  |  | // If the cache cannot be found nil is returned.
 | 
					
						
							|  |  |  | // The bucket cache will be locked until the done .
 | 
					
						
							|  |  |  | func (b *bucketMetacache) updateCache(id string) (cache *metacache, done func()) { | 
					
						
							|  |  |  | 	b.mu.Lock() | 
					
						
							|  |  |  | 	c, ok := b.caches[id] | 
					
						
							|  |  |  | 	if !ok { | 
					
						
							|  |  |  | 		b.mu.Unlock() | 
					
						
							|  |  |  | 		return nil, func() {} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	return &c, func() { | 
					
						
							|  |  |  | 		c.lastUpdate = UTCNow() | 
					
						
							|  |  |  | 		b.caches[id] = c | 
					
						
							|  |  |  | 		b.mu.Unlock() | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | // updateCacheEntry will update a cache.
 | 
					
						
							|  |  |  | // Returns the updated status.
 | 
					
						
							|  |  |  | func (b *bucketMetacache) updateCacheEntry(update metacache) (metacache, error) { | 
					
						
							|  |  |  | 	b.mu.Lock() | 
					
						
							|  |  |  | 	defer b.mu.Unlock() | 
					
						
							|  |  |  | 	existing, ok := b.caches[update.id] | 
					
						
							|  |  |  | 	if !ok { | 
					
						
							|  |  |  | 		return update, errFileNotFound | 
					
						
							|  |  |  | 	} | 
					
						
							| 
									
										
										
										
											2020-11-05 23:34:08 +08:00
										 |  |  | 	existing.update(update) | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 	b.caches[update.id] = existing | 
					
						
							|  |  |  | 	b.updated = true | 
					
						
							|  |  |  | 	return existing, nil | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-12-11 04:30:28 +08:00
										 |  |  | // cloneCaches will return a clone of all current caches.
 | 
					
						
							|  |  |  | func (b *bucketMetacache) cloneCaches() (map[string]metacache, map[string][]string) { | 
					
						
							|  |  |  | 	b.mu.RLock() | 
					
						
							|  |  |  | 	defer b.mu.RUnlock() | 
					
						
							|  |  |  | 	dst := make(map[string]metacache, len(b.caches)) | 
					
						
							|  |  |  | 	for k, v := range b.caches { | 
					
						
							|  |  |  | 		dst[k] = v | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	// Copy indexes
 | 
					
						
							|  |  |  | 	dst2 := make(map[string][]string, len(b.cachesRoot)) | 
					
						
							|  |  |  | 	for k, v := range b.cachesRoot { | 
					
						
							|  |  |  | 		tmp := make([]string, len(v)) | 
					
						
							|  |  |  | 		copy(tmp, v) | 
					
						
							|  |  |  | 		dst2[k] = tmp | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return dst, dst2 | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | // getCache will return a clone of a specific metacache.
 | 
					
						
							|  |  |  | // Will return nil if the cache doesn't exist.
 | 
					
						
							|  |  |  | func (b *bucketMetacache) getCache(id string) *metacache { | 
					
						
							|  |  |  | 	b.mu.RLock() | 
					
						
							|  |  |  | 	c, ok := b.caches[id] | 
					
						
							|  |  |  | 	b.mu.RUnlock() | 
					
						
							|  |  |  | 	if !ok { | 
					
						
							|  |  |  | 		return nil | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	return &c | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2021-02-25 14:24:38 +08:00
										 |  |  | // deleteAll will delete all on disk data for ALL caches.
 | 
					
						
							|  |  |  | // Deletes are performed concurrently.
 | 
					
						
							|  |  |  | func (b *bucketMetacache) deleteAll() { | 
					
						
							|  |  |  | 	ctx := context.Background() | 
					
						
							|  |  |  | 	ez, ok := newObjectLayerFn().(*erasureServerPools) | 
					
						
							|  |  |  | 	if !ok { | 
					
						
							|  |  |  | 		logger.LogIf(ctx, errors.New("bucketMetacache: expected objAPI to be *erasurePools")) | 
					
						
							|  |  |  | 		return | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	b.mu.Lock() | 
					
						
							|  |  |  | 	defer b.mu.Unlock() | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	b.updated = true | 
					
						
							|  |  |  | 	if !b.transient { | 
					
						
							|  |  |  | 		// Delete all.
 | 
					
						
							|  |  |  | 		ez.renameAll(ctx, minioMetaBucket, metacachePrefixForID(b.bucket, slashSeparator)) | 
					
						
							|  |  |  | 		b.caches = make(map[string]metacache, 10) | 
					
						
							|  |  |  | 		b.cachesRoot = make(map[string][]string, 10) | 
					
						
							|  |  |  | 		return | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	// Transient are in different buckets.
 | 
					
						
							|  |  |  | 	var wg sync.WaitGroup | 
					
						
							|  |  |  | 	for id := range b.caches { | 
					
						
							|  |  |  | 		wg.Add(1) | 
					
						
							|  |  |  | 		go func(cache metacache) { | 
					
						
							|  |  |  | 			defer wg.Done() | 
					
						
							|  |  |  | 			ez.renameAll(ctx, minioMetaBucket, metacachePrefixForID(cache.bucket, cache.id)) | 
					
						
							|  |  |  | 		}(b.caches[id]) | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	wg.Wait() | 
					
						
							|  |  |  | 	b.caches = make(map[string]metacache, 10) | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | // deleteCache will delete a specific cache and all files related to it across the cluster.
 | 
					
						
							|  |  |  | func (b *bucketMetacache) deleteCache(id string) { | 
					
						
							|  |  |  | 	b.mu.Lock() | 
					
						
							|  |  |  | 	c, ok := b.caches[id] | 
					
						
							|  |  |  | 	if ok { | 
					
						
							| 
									
										
										
											
												listcache: Add path index (#11063)
Add a root path index.
```
Before:
Benchmark_bucketMetacache_findCache-32    	   10000	    730737 ns/op
With excluded prints:
Benchmark_bucketMetacache_findCache-32    	   10000	    207100 ns/op
With the root path:
Benchmark_bucketMetacache_findCache-32    	  705765	      1943 ns/op
```
Benchmark used (not linear):
```Go
func Benchmark_bucketMetacache_findCache(b *testing.B) {
	bm := newBucketMetacache("", false)
	for i := 0; i < b.N; i++ {
		bm.findCache(listPathOptions{
			ID:           mustGetUUID(),
			Bucket:       "",
			BaseDir:      "prefix/" + mustGetUUID(),
			Prefix:       "",
			FilterPrefix: "",
			Marker:       "",
			Limit:        0,
			AskDisks:     0,
			Recursive:    false,
			Separator:    slashSeparator,
			Create:       true,
			CurrentCycle: 0,
			OldestCycle:  0,
		})
	}
}
```
Replaces #11058
											
										 
											2020-12-10 00:37:43 +08:00
										 |  |  | 		// Delete from root map.
 | 
					
						
							|  |  |  | 		list := b.cachesRoot[c.root] | 
					
						
							|  |  |  | 		for i, lid := range list { | 
					
						
							|  |  |  | 			if id == lid { | 
					
						
							|  |  |  | 				list = append(list[:i], list[i+1:]...) | 
					
						
							|  |  |  | 				break | 
					
						
							|  |  |  | 			} | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 		b.cachesRoot[c.root] = list | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | 		delete(b.caches, id) | 
					
						
							|  |  |  | 		b.updated = true | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	b.mu.Unlock() | 
					
						
							| 
									
										
										
										
											2021-02-25 14:24:38 +08:00
										 |  |  | 	if ok { | 
					
						
							|  |  |  | 		c.delete(context.Background()) | 
					
						
							|  |  |  | 	} | 
					
						
							| 
									
										
										
										
											2020-10-29 00:18:35 +08:00
										 |  |  | } |