root
/
minio
mirror of https://github.com/minio/minio.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fixing code comments

This commit is contained in:
Mayuresh Chaubal 2025-05-02 09:18:44 +02:00
parent 5d16e2b4bc
commit a0f7fdce4d
2 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Makefile
View File

@ -180,10 +180,6 @@ build: checks build-debugging ## builds minio to $(PWD)
@echo "Building minio binary to './minio'"
@CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) go build -tags kqueue -trimpath --ldflags "$(LDFLAGS)" -o $(PWD)/minio 1>/dev/null
build-linux: checks build-debugging ## builds minio to $(PWD)
@echo "Building minio binary for linux to './minio'"
@CGO_ENABLED=0 GOOS=linux GOARCH=$(GOARCH) go build -tags kqueue -trimpath --ldflags "$(LDFLAGS)" -o $(PWD)/minio 1>/dev/null
hotfix-vars:
$(eval LDFLAGS := $(shell MINIO_RELEASE="RELEASE" MINIO_HOTFIX="hotfix.$(shell git rev-parse --short HEAD)" go run buildscripts/gen-ldflags.go $(shell git describe --tags --abbrev=0 | \
sed 's#RELEASE\.\([0-9]\+\)-\([0-9]\+\)-\([0-9]\+\)T\([0-9]\+\)-\([0-9]\+\)-\([0-9]\+\)Z#\1-\2-\3T\4:\5:\6Z#')))
@ -219,10 +215,6 @@ docker: build ## builds minio docker container
@echo "Building minio docker image '$(TAG)'"
@docker build -q --no-cache -t $(TAG) . -f Dockerfile
podman: build-linux ## builds minio docker container
@echo "Building minio docker image '$(TAG)'"
@podman build -q --no-cache -t $(TAG) . -f Dockerfile
test-resiliency: build
@echo "Running resiliency tests"
@(DOCKER_COMPOSE_FILE=$(PWD)/docs/resiliency/docker-compose.yaml env bash $(PWD)/docs/resiliency/resiliency-tests.sh)

12
internal/config/identity/tls/config.go
View File

@ -43,9 +43,9 @@ const (
EnvIdentityTLSSkipVerify = "MINIO_IDENTITY_TLS_SKIP_VERIFY"
// EnvIdentityTLSSubjectSanURI is an environmental variable that is used to select
// Subject for verfied certificate identity in JWT Claim.
// Subject for verified certificate identity in JWT Claim.
// This claim is sent to Authorization Engine.
// If set to True, First URI will be used as subject instead of CommonName
// If set to true, First URI will be used as subject instead of CommonName
// Valid values for this field are true and false
// By default, it will be false. Thus Common Name will be used
EnvIdentityTLSSubjectSanURI = "MINIO_IDENTITY_TLS_SUBJECT_USE_SANURI"
@ -113,7 +113,6 @@ func Lookup(kvs config.KVS) (Config, error) {
return Config{}, err
}
// SAN URI Flag
cfg.TLSSubjectUseSanURI, err = config.ParseBool(env.Get(EnvIdentityTLSSubjectSanURI, kvs.Get(tlsSubjectUseSanURI)))
if err != nil {
return Config{}, err
@ -124,7 +123,6 @@ func Lookup(kvs config.KVS) (Config, error) {
const (
skipVerify = "skip_verify"
tlsSubject = "common_name"
tlsSubjectUseSanURI = "tls_subject_use_san_uri"
)
@ -137,7 +135,7 @@ var DefaultKVS = config.KVS{
},
config.KV{
Key: tlsSubjectUseSanURI,
Value: "tls_subject_use_san_uri",
Value: "off",
},
}
@ -151,8 +149,8 @@ var Help = config.HelpKVS{
},
config.HelpKV{
Key: tlsSubjectUseSanURI,
Description: `use san uri from certifcate instead common name (default: 'false')`,
Description: `use first san uri from client certificate instead common name (default: 'off')`,
Optional: true,
Type: "true|false",
Type: "on|off",
},
}