minio

Commit Graph

Author	SHA1	Message	Date
Harshavardhana	1d8a8c63db	Simplify data verification with HashReader. (#5071 ) Verify() was being called by caller after the data has been successfully read after io.EOF. This disconnection opens a race under concurrent access to such an object. Verification is not necessary outside of Read() call, we can simply just do checksum verification right inside Read() call at io.EOF. This approach simplifies the usage.	2017-10-22 11:00:34 +05:30
Harshavardhana	d3eb5815d9	Avoid DDOS in PutObject() when objectName is '/' and size '0' (#4962 ) It can happen that an incoming PutObject() request might have inputs of following form eg:- - bucketName is 'testbucket' - objectName is '/' bucketName exists and was previously created but there are no other objects in this bucket. In a situation like this parentDirIsObject() goes into an infinite loop. Verifying that if '/' is an object fails on both backends but the resulting `path.Dir('/')` returns `'/'` this causes the closure to loop onto itself. Fixes #4940	2017-09-25 14:47:58 -07:00

Author

SHA1

Message

Date

Harshavardhana

1d8a8c63db

Simplify data verification with HashReader. (#5071 )

Verify() was being called by caller after the data
has been successfully read after io.EOF. This disconnection
opens a race under concurrent access to such an object.
Verification is not necessary outside of Read() call,
we can simply just do checksum verification right inside
Read() call at io.EOF.

This approach simplifies the usage.

2017-10-22 11:00:34 +05:30

Harshavardhana

d3eb5815d9

Avoid DDOS in PutObject() when objectName is '/' and size '0' (#4962 )

It can happen that an incoming PutObject() request might
have inputs of following form eg:-

 - bucketName is 'testbucket'
 - objectName is '/'

bucketName exists and was previously created but there
are no other objects in this bucket. In a situation like
this parentDirIsObject() goes into an infinite loop.

Verifying that if '/' is an object fails on both backends
but the resulting `path.Dir('/')` returns `'/'` this causes
the closure to loop onto itself.

Fixes #4940

2017-09-25 14:47:58 -07:00

2 Commits