Compare commits

...

5 Commits

Author SHA1 Message Date
Allan Roger Reid 50f2ba2925
Merge e0182b85e0 into de234b888c 2025-07-09 17:19:29 +08:00
Burkov Egor de234b888c
fix: admin api - SetPolicyForUserOrGroup avoid nil deref (#21400)
VulnCheck / Analysis (push) Has been cancelled Details
Lock Threads / action (push) Has been cancelled Details
2025-07-01 09:00:17 -07:00
Allan Roger Reid e0182b85e0
Merge branch 'master' into add-audit-site 2024-12-31 14:50:22 -08:00
Allan Roger Reid 9611aa9b15
Merge branch 'master' into add-audit-site 2024-12-19 12:25:18 -08:00
Allan Reid bebf04e2b6
Add SiteName to both internal and external audit logs 2024-12-19 12:12:03 -08:00
5 changed files with 15 additions and 2 deletions

View File

@ -1827,16 +1827,18 @@ func (a adminAPIHandlers) SetPolicyForUserOrGroup(w http.ResponseWriter, r *http
iamLogIf(ctx, err)
} else if foundGroupDN == nil || !underBaseDN {
err = errNoSuchGroup
} else {
entityName = foundGroupDN.NormDN
}
entityName = foundGroupDN.NormDN
} else {
var foundUserDN *xldap.DNSearchResult
if foundUserDN, err = globalIAMSys.LDAPConfig.GetValidatedDNForUsername(entityName); err != nil {
iamLogIf(ctx, err)
} else if foundUserDN == nil {
err = errNoSuchUser
} else {
entityName = foundUserDN.NormDN
}
entityName = foundUserDN.NormDN
}
if err != nil {
writeErrorResponseJSON(ctx, w, toAdminAPIErr(ctx, err), r.URL)

View File

@ -524,6 +524,7 @@ func lookupConfigs(s config.Config, objAPI ObjectLayer) {
configLogIf(ctx, fmt.Errorf("Invalid site configuration: %w", err))
}
globalSite.Update(siteCfg)
xhttp.SetSiteName(globalSite.Name())
globalAutoEncryption = crypto.LookupAutoEncryption() // Enable auto-encryption if enabled
if globalAutoEncryption && GlobalKMS == nil {

View File

@ -37,6 +37,9 @@ var (
// GlobalDeploymentID - is sent in the header to all http targets
GlobalDeploymentID string
// GlobalSiteName - is sent in the header to all http targets
GlobalSiteName string
)
const (
@ -236,3 +239,8 @@ func SetMinIOVersion(version string) {
func SetDeploymentID(deploymentID string) {
GlobalDeploymentID = deploymentID
}
// SetSiteName -- user defined site from environment variable `MINIO_SITE_NAME` or from configuration `site.name`
func SetSiteName(siteName string) {
GlobalSiteName = siteName
}

View File

@ -52,6 +52,7 @@ func GetAuditEntry(ctx context.Context) *audit.Entry {
r = &audit.Entry{
Version: internalAudit.Version,
DeploymentID: xhttp.GlobalDeploymentID,
SiteName: xhttp.GlobalSiteName,
Time: time.Now().UTC(),
}
return r

View File

@ -36,6 +36,7 @@ func NewEntry(deploymentID string) audit.Entry {
return audit.Entry{
Version: Version,
DeploymentID: deploymentID,
SiteName: xhttp.GlobalSiteName,
Time: time.Now().UTC(),
}
}