root
/
ollama
mirror of https://github.com/ollama/ollama.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

test: add template error test (#12489)

This commit is contained in:
Patrick Devine 2025-10-03 12:05:34 -07:00 committed by GitHub
parent 07e36761c3
commit 2fa1e92a99
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 88 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

107
template/template_test.go
View File

@ -154,24 +154,55 @@ func TestTemplate(t *testing.T) {
} }
func TestParse(t *testing.T) { func TestParse(t *testing.T) {
cases := []struct { validCases := []struct {
name string
template string template string
vars []string vars []string
}{ }{
{"{{ .Prompt }}", []string{"prompt", "response"}}, {
{"{{ .System }} {{ .Prompt }}", []string{"prompt", "response", "system"}}, name: "PromptOnly",
{"{{ .System }} {{ .Prompt }} {{ .Response }}", []string{"prompt", "response", "system"}}, template: "{{ .Prompt }}",
{"{{ with .Tools }}{{ . }}{{ end }} {{ .System }} {{ .Prompt }}", []string{"prompt", "response", "system", "tools"}}, vars: []string{"prompt", "response"},
{"{{ range .Messages }}{{ .Role }} {{ .Content }}{{ end }}", []string{"content", "messages", "role"}}, },
{"{{ range .Messages }}{{ if eq .Role \"tool\" }}Tool Result: {{ .ToolName }} {{ .Content }}{{ end }}{{ end }}", []string{"content", "messages", "role", "toolname"}}, {
{`{{- range .Messages }} name: "SystemAndPrompt",
template: "{{ .System }} {{ .Prompt }}",
vars: []string{"prompt", "response", "system"},
},
{
name: "PromptResponseSystem",
template: "{{ .System }} {{ .Prompt }} {{ .Response }}",
vars: []string{"prompt", "response", "system"},
},
{
name: "ToolsBlock",
template: "{{ with .Tools }}{{ . }}{{ end }} {{ .System }} {{ .Prompt }}",
vars: []string{"prompt", "response", "system", "tools"},
},
{
name: "MessagesRange",
template: "{{ range .Messages }}{{ .Role }} {{ .Content }}{{ end }}",
vars: []string{"content", "messages", "role"},
},
{
name: "ToolResultConditional",
template: "{{ range .Messages }}{{ if eq .Role \"tool\" }}Tool Result: {{ .ToolName }} {{ .Content }}{{ end }}{{ end }}",
vars: []string{"content", "messages", "role", "toolname"},
},
{
name: "MultilineSystemUserAssistant",
template: `{{- range .Messages }}
{{- if eq .Role "system" }}SYSTEM: {{- if eq .Role "system" }}SYSTEM:
{{- else if eq .Role "user" }}USER: {{- else if eq .Role "user" }}USER:
{{- else if eq .Role "assistant" }}ASSISTANT: {{- else if eq .Role "assistant" }}ASSISTANT:
{{- else if eq .Role "tool" }}TOOL: {{- else if eq .Role "tool" }}TOOL:
{{- end }} {{ .Content }} {{- end }} {{ .Content }}
{{- end }}`, []string{"content", "messages", "role"}}, {{- end }}`,
{`{{- if .Messages }} vars: []string{"content", "messages", "role"},
},
{
name: "ChatMLLike",
template: `{{- if .Messages }}
{{- range .Messages }}<|im_start|>{{ .Role }} {{- range .Messages }}<|im_start|>{{ .Role }}
{{ .Content }}<|im_end|> {{ .Content }}<|im_end|>
{{ end }}<|im_start|>assistant {{ end }}<|im_start|>assistant
@ -182,22 +213,60 @@ func TestParse(t *testing.T) {
{{ .Prompt }}<|im_end|> {{ .Prompt }}<|im_end|>
{{ end }}<|im_start|>assistant {{ end }}<|im_start|>assistant
{{ .Response }}<|im_end|> {{ .Response }}<|im_end|>
{{- end -}}`, []string{"content", "messages", "prompt", "response", "role", "system"}}, {{- end -}}`,
vars: []string{"content", "messages", "prompt", "response", "role", "system"},
},
} }
for _, tt := range cases { for _, tt := range validCases {
t.Run("", func(t *testing.T) { tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
tmpl, err := Parse(tt.template) tmpl, err := Parse(tt.template)
if err != nil { if err != nil {
t.Fatal(err) t.Fatalf("Parse returned unexpected error: %v", err)
} }
v, err := tmpl.Vars() gotVars, err := tmpl.Vars()
if err != nil { if err != nil {
t.Fatal(err) t.Fatalf("Vars returned unexpected error: %v", err)
} }
if diff := cmp.Diff(v, tt.vars); diff != "" {
t.Errorf("mismatch (-got +want):\n%s", diff) if diff := cmp.Diff(gotVars, tt.vars); diff != "" {
t.Errorf("Vars mismatch (-got +want):\n%s", diff)
}
})
}
}
func TestParseError(t *testing.T) {
invalidCases := []struct {
name string
template string
errorStr string
}{
{
"TemplateNotClosed",
"{{ .Prompt ",
"unclosed action",
},
{
"Template",
`{{define "x"}}{{template "x"}}{{end}}{{template "x"}}`,
"undefined template specified",
},
}
for _, tt := range invalidCases {
t.Run(tt.name, func(t *testing.T) {
_, err := Parse(tt.template)
if err == nil {
t.Fatalf("expected Parse to return an error for an invalid template, got nil")
}
if !strings.Contains(strings.ToLower(err.Error()), strings.ToLower(tt.errorStr)) {
t.Errorf("unexpected error message.\n got: %q\n want substring (case‑insensitive): %q", err.Error(), tt.errorStr)
} }
}) })
} }