fix: simplify workflow with hardcoded image names

Instead of dynamically determining image names from repository metadata, use hardcoded values that match the actual Docker Hub naming convention: - GHCR: ghcr.io/lfnovo/open-notebook - Docker Hub: lfnovo/open_notebook This is simpler, more reliable, and matches the existing convention. Removes unnecessary complexity from the extract-version job.
fix: prevent empty Docker tags in build workflow
2025-10-18 13:29:28 -03:00 · 2025-10-18 13:11:00 -03:00 · 2025-10-18 13:01:20 -03:00 · 2025-10-16 17:18:21 +11:00 · 2025-10-16 17:18:21 +11:00
1 changed files with 119 additions and 15 deletions
--- a/.github/workflows/build-and-release.yml
+++ b/.github/workflows/build-and-release.yml
@ -20,19 +20,24 @@ on:
  release:
    types: [published]

+permissions:
+  contents: read
+  packages: write
+
 env:
-  REGISTRY: docker.io
-  IMAGE_NAME: lfnovo/open_notebook
+  GHCR_IMAGE: ghcr.io/lfnovo/open-notebook
+  DOCKERHUB_IMAGE: lfnovo/open_notebook

 jobs:
  extract-version:
    runs-on: ubuntu-latest
    outputs:
      version: ${{ steps.version.outputs.version }}
+      has_dockerhub_secrets: ${{ steps.check.outputs.has_dockerhub_secrets }}
    steps:
      - name: Checkout
        uses: actions/checkout@v4
-      
+
      - name: Extract version from pyproject.toml
        id: version
        run: |
@ -40,6 +45,17 @@ jobs:
          echo "version=$VERSION" >> $GITHUB_OUTPUT
          echo "Extracted version: $VERSION"

+      - name: Check for Docker Hub credentials
+        id: check
+        run: |
+          if [[ -n "${{ secrets.DOCKER_USERNAME }}" && -n "${{ secrets.DOCKER_PASSWORD }}" ]]; then
+            echo "has_dockerhub_secrets=true" >> $GITHUB_OUTPUT
+            echo "Docker Hub credentials available"
+          else
+            echo "has_dockerhub_secrets=false" >> $GITHUB_OUTPUT
+            echo "Docker Hub credentials not available - will only push to GHCR"
+          fi
+
  build-regular:
    needs: extract-version
    runs-on: ubuntu-latest
@ -51,7 +67,15 @@ jobs:
      - name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v3

+      - name: Login to GitHub Container Registry
+        uses: docker/login-action@v3
+        with:
+          registry: ${{ env.GHCR_REGISTRY }}
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
      - name: Login to Docker Hub
+        if: needs.extract-version.outputs.has_dockerhub_secrets == 'true'
        uses: docker/login-action@v3
        with:
          username: ${{ secrets.DOCKER_USERNAME }}
@ -65,6 +89,34 @@ jobs:
          restore-keys: |
            ${{ runner.os }}-buildx-regular-

+      - name: Prepare Docker tags for regular build
+        id: tags-regular
+        run: |
+          TAGS="${{ env.GHCR_IMAGE }}:${{ needs.extract-version.outputs.version }}"
+
+          # Determine if we should push latest tags
+          PUSH_LATEST="${{ github.event.inputs.push_latest }}"
+          if [[ -z "$PUSH_LATEST" ]]; then
+            PUSH_LATEST="false"
+          fi
+
+          # Add GHCR latest tag if requested or for non-prerelease releases
+          if [[ "$PUSH_LATEST" == "true" ]] || [[ "${{ github.event_name }}" == "release" && "${{ github.event.release.prerelease }}" != "true" ]]; then
+            TAGS="${TAGS},${{ env.GHCR_IMAGE }}:v1-latest"
+          fi
+
+          # Add Docker Hub tags if credentials available
+          if [[ "${{ needs.extract-version.outputs.has_dockerhub_secrets }}" == "true" ]]; then
+            TAGS="${TAGS},${{ env.DOCKERHUB_IMAGE }}:${{ needs.extract-version.outputs.version }}"
+
+            if [[ "$PUSH_LATEST" == "true" ]] || [[ "${{ github.event_name }}" == "release" && "${{ github.event.release.prerelease }}" != "true" ]]; then
+              TAGS="${TAGS},${{ env.DOCKERHUB_IMAGE }}:v1-latest"
+            fi
+          fi
+
+          echo "tags=${TAGS}" >> $GITHUB_OUTPUT
+          echo "Generated tags: ${TAGS}"
+
      - name: Build and push regular image
        uses: docker/build-push-action@v5
        with:
@ -72,9 +124,7 @@ jobs:
          file: ./Dockerfile
          platforms: linux/amd64,linux/arm64
          push: true
-          tags: |
-            ${{ env.IMAGE_NAME }}:${{ needs.extract-version.outputs.version }}
-            ${{ (github.event.inputs.push_latest == 'true' || (github.event_name == 'release' && !github.event.release.prerelease)) && format('{0}:v1-latest', env.IMAGE_NAME) || '' }}
+          tags: ${{ steps.tags-regular.outputs.tags }}
          cache-from: type=local,src=/tmp/.buildx-cache
          cache-to: type=local,dest=/tmp/.buildx-cache-new,mode=max

@ -94,7 +144,15 @@ jobs:
      - name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v3

+      - name: Login to GitHub Container Registry
+        uses: docker/login-action@v3
+        with:
+          registry: ${{ env.GHCR_REGISTRY }}
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
      - name: Login to Docker Hub
+        if: needs.extract-version.outputs.has_dockerhub_secrets == 'true'
        uses: docker/login-action@v3
        with:
          username: ${{ secrets.DOCKER_USERNAME }}
@ -108,6 +166,34 @@ jobs:
          restore-keys: |
            ${{ runner.os }}-buildx-single-

+      - name: Prepare Docker tags for single build
+        id: tags-single
+        run: |
+          TAGS="${{ env.GHCR_IMAGE }}:${{ needs.extract-version.outputs.version }}-single"
+
+          # Determine if we should push latest tags
+          PUSH_LATEST="${{ github.event.inputs.push_latest }}"
+          if [[ -z "$PUSH_LATEST" ]]; then
+            PUSH_LATEST="false"
+          fi
+
+          # Add GHCR latest tag if requested or for non-prerelease releases
+          if [[ "$PUSH_LATEST" == "true" ]] || [[ "${{ github.event_name }}" == "release" && "${{ github.event.release.prerelease }}" != "true" ]]; then
+            TAGS="${TAGS},${{ env.GHCR_IMAGE }}:v1-latest-single"
+          fi
+
+          # Add Docker Hub tags if credentials available
+          if [[ "${{ needs.extract-version.outputs.has_dockerhub_secrets }}" == "true" ]]; then
+            TAGS="${TAGS},${{ env.DOCKERHUB_IMAGE }}:${{ needs.extract-version.outputs.version }}-single"
+
+            if [[ "$PUSH_LATEST" == "true" ]] || [[ "${{ github.event_name }}" == "release" && "${{ github.event.release.prerelease }}" != "true" ]]; then
+              TAGS="${TAGS},${{ env.DOCKERHUB_IMAGE }}:v1-latest-single"
+            fi
+          fi
+
+          echo "tags=${TAGS}" >> $GITHUB_OUTPUT
+          echo "Generated tags: ${TAGS}"
+
      - name: Build and push single-container image
        uses: docker/build-push-action@v5
        with:
@ -115,9 +201,7 @@ jobs:
          file: ./Dockerfile.single
          platforms: linux/amd64,linux/arm64
          push: true
-          tags: |
-            ${{ env.IMAGE_NAME }}:${{ needs.extract-version.outputs.version }}-single
-            ${{ (github.event.inputs.push_latest == 'true' || (github.event_name == 'release' && !github.event.release.prerelease)) && format('{0}:v1-latest-single', env.IMAGE_NAME) || '' }}
+          tags: ${{ steps.tags-single.outputs.tags }}
          cache-from: type=local,src=/tmp/.buildx-cache-single
          cache-to: type=local,dest=/tmp/.buildx-cache-single-new,mode=max

@ -138,12 +222,26 @@ jobs:
          echo "**Build Type:** ${{ github.event.inputs.build_type || 'both' }}" >> $GITHUB_STEP_SUMMARY
          echo "**Push Latest:** ${{ github.event.inputs.push_latest || 'true' }}" >> $GITHUB_STEP_SUMMARY
          echo "" >> $GITHUB_STEP_SUMMARY
+          echo "### Registries:" >> $GITHUB_STEP_SUMMARY
+          echo "✅ **GHCR:** \`${{ env.GHCR_IMAGE }}\`" >> $GITHUB_STEP_SUMMARY
+          if [[ "${{ needs.extract-version.outputs.has_dockerhub_secrets }}" == "true" ]]; then
+            echo "✅ **Docker Hub:** \`${{ env.DOCKERHUB_IMAGE }}\`" >> $GITHUB_STEP_SUMMARY
+          else
+            echo "⏭️ **Docker Hub:** Skipped (credentials not configured)" >> $GITHUB_STEP_SUMMARY
+          fi
+          echo "" >> $GITHUB_STEP_SUMMARY
          echo "### Images Built:" >> $GITHUB_STEP_SUMMARY
-          
+
          if [[ "${{ needs.build-regular.result }}" == "success" ]]; then
-            echo "✅ **Regular:** \`${{ env.IMAGE_NAME }}:${{ needs.extract-version.outputs.version }}\`" >> $GITHUB_STEP_SUMMARY
+            echo "✅ **Regular (GHCR):** \`${{ env.GHCR_IMAGE }}:${{ needs.extract-version.outputs.version }}\`" >> $GITHUB_STEP_SUMMARY
            if [[ "${{ github.event.inputs.push_latest }}" == "true" ]]; then
-              echo "✅ **Regular v1-Latest:** \`${{ env.IMAGE_NAME }}:v1-latest\`" >> $GITHUB_STEP_SUMMARY
+              echo "✅ **Regular v1-Latest (GHCR):** \`${{ env.GHCR_IMAGE }}:v1-latest\`" >> $GITHUB_STEP_SUMMARY
+            fi
+            if [[ "${{ needs.extract-version.outputs.has_dockerhub_secrets }}" == "true" ]]; then
+              echo "✅ **Regular (Docker Hub):** \`${{ env.DOCKERHUB_IMAGE }}:${{ needs.extract-version.outputs.version }}\`" >> $GITHUB_STEP_SUMMARY
+              if [[ "${{ github.event.inputs.push_latest }}" == "true" ]]; then
+                echo "✅ **Regular v1-Latest (Docker Hub):** \`${{ env.DOCKERHUB_IMAGE }}:v1-latest\`" >> $GITHUB_STEP_SUMMARY
+              fi
            fi
          elif [[ "${{ needs.build-regular.result }}" == "skipped" ]]; then
            echo "⏭️ **Regular:** Skipped" >> $GITHUB_STEP_SUMMARY
@ -152,16 +250,22 @@ jobs:
          fi

          if [[ "${{ needs.build-single.result }}" == "success" ]]; then
-            echo "✅ **Single:** \`${{ env.IMAGE_NAME }}:${{ needs.extract-version.outputs.version }}-single\`" >> $GITHUB_STEP_SUMMARY
+            echo "✅ **Single (GHCR):** \`${{ env.GHCR_IMAGE }}:${{ needs.extract-version.outputs.version }}-single\`" >> $GITHUB_STEP_SUMMARY
            if [[ "${{ github.event.inputs.push_latest }}" == "true" ]]; then
-              echo "✅ **Single v1-Latest:** \`${{ env.IMAGE_NAME }}:v1-latest-single\`" >> $GITHUB_STEP_SUMMARY
+              echo "✅ **Single v1-Latest (GHCR):** \`${{ env.GHCR_IMAGE }}:v1-latest-single\`" >> $GITHUB_STEP_SUMMARY
+            fi
+            if [[ "${{ needs.extract-version.outputs.has_dockerhub_secrets }}" == "true" ]]; then
+              echo "✅ **Single (Docker Hub):** \`${{ env.DOCKERHUB_IMAGE }}:${{ needs.extract-version.outputs.version }}-single\`" >> $GITHUB_STEP_SUMMARY
+              if [[ "${{ github.event.inputs.push_latest }}" == "true" ]]; then
+                echo "✅ **Single v1-Latest (Docker Hub):** \`${{ env.DOCKERHUB_IMAGE }}:v1-latest-single\`" >> $GITHUB_STEP_SUMMARY
+              fi
            fi
          elif [[ "${{ needs.build-single.result }}" == "skipped" ]]; then
            echo "⏭️ **Single:** Skipped" >> $GITHUB_STEP_SUMMARY
          else
            echo "❌ **Single:** Failed" >> $GITHUB_STEP_SUMMARY
          fi
-          
+
          echo "" >> $GITHUB_STEP_SUMMARY
          echo "### Platforms:" >> $GITHUB_STEP_SUMMARY
          echo "- linux/amd64" >> $GITHUB_STEP_SUMMARY
Author	SHA1	Message	Date
LUIS NOVO	490fc66ddf	fix: simplify workflow with hardcoded image names Instead of dynamically determining image names from repository metadata, use hardcoded values that match the actual Docker Hub naming convention: - GHCR: ghcr.io/lfnovo/open-notebook - Docker Hub: lfnovo/open_notebook This is simpler, more reliable, and matches the existing convention. Removes unnecessary complexity from the extract-version job.	2025-10-18 13:29:28 -03:00
LUIS NOVO	ac472f9e54	fix: prevent empty Docker tags in build workflow The previous approach using conditional expressions with empty strings caused Docker buildx to fail with "invalid tag" errors when conditions evaluated to false. Solution: Use shell script to dynamically build tag list with proper comma separation, only including tags when conditions are met. This ensures: - Docker Hub tags are only added when credentials are available - Latest tags are only added when requested - Empty push_latest input defaults to false for release events	2025-10-18 13:11:00 -03:00
LUIS NOVO	8e15e6dde2	fix: resolve merge conflict with main branch - Update tag naming to use v1-latest and v1-latest-single - Maintain GHCR support with Docker Hub as optional fallback - Update summary messages to reflect v1 tag naming convention	2025-10-18 13:01:20 -03:00
Troy Kelly	e848f4f8ee	Add GITHUB_TOKEN permissions for GHCR publishing The workflow needs 'packages: write' permission to push images to GitHub Container Registry (GHCR). Permissions added: - contents: read (required for checkout) - packages: write (required for GHCR push) Without these permissions, the docker login and push to ghcr.io would fail with a 403 Forbidden error.	2025-10-16 17:18:21 +11:00
Troy Kelly	f79503da92	Add GHCR support with conditional Docker Hub publishing This commit enhances the CI/CD pipeline to support both GitHub Container Registry (GHCR) and Docker Hub, with Docker Hub being optional based on the presence of credentials. Changes: - Add GHCR as the primary container registry - Make Docker Hub publishing conditional on DOCKER_USERNAME and DOCKER_PASSWORD secrets - Dynamically determine image names from repository owner/name (e.g., aperim/open-notebook) - Images are pushed to: * GHCR: ghcr.io/{owner}/{repo}:{version\|latest} * Docker Hub (if credentials available): {owner}/{repo}:{version\|latest} - Update build summary to show which registries were used Benefits: - Forks can build and publish to GHCR without Docker Hub credentials - Original repo can continue publishing to both registries - Image names automatically match the repository structure - More flexible deployment options for contributors Technical Details: - Added extract-version job outputs: ghcr_image, dockerhub_image, has_dockerhub_secrets - Added GHCR login step using GITHUB_TOKEN (always runs) - Made Docker Hub login conditional on has_dockerhub_secrets flag - Updated image tags to use dynamic repository-based names - Enhanced build summary to show registry usage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>	2025-10-16 17:18:21 +11:00