| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  | HOW TO CONTRIBUTE TO OpenSSL | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  | ============================ | 
					
						
							| 
									
										
										
										
											2015-10-17 19:10:55 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-17 16:45:49 +08:00
										 |  |  | Please visit our [Getting Started] page for other ideas about how to contribute. | 
					
						
							| 
									
										
										
										
											2015-10-17 19:10:55 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-17 16:45:49 +08:00
										 |  |  |   [Getting Started]: <https://www.openssl.org/community/getting-started.html> | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-17 16:45:49 +08:00
										 |  |  | Development is done on GitHub in the [openssl/openssl] repository. | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-17 16:45:49 +08:00
										 |  |  |   [openssl/openssl]: <https://github.com/openssl/openssl> | 
					
						
							| 
									
										
										
										
											2015-10-17 19:10:55 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2023-12-02 22:54:27 +08:00
										 |  |  | To request new a feature, ask a question, or report a bug, | 
					
						
							|  |  |  | please open an [issue on GitHub](https://github.com/openssl/openssl/issues). | 
					
						
							| 
									
										
										
										
											2016-01-26 06:12:57 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2023-12-02 22:54:27 +08:00
										 |  |  | To submit a patch or implement a new feature, please open a | 
					
						
							|  |  |  | [pull request on GitHub](https://github.com/openssl/openssl/pulls). | 
					
						
							|  |  |  | If you are thinking of making a large contribution, | 
					
						
							|  |  |  | open an issue for it before starting work, to get comments from the community. | 
					
						
							|  |  |  | Someone may be already working on the same thing, | 
					
						
							|  |  |  | or there may be special reasons why a feature is not implemented. | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  | To make it easier to review and accept your pull request, please follow these | 
					
						
							|  |  |  | guidelines: | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  1. Anything other than a trivial contribution requires a [Contributor | 
					
						
							| 
									
										
										
										
											2020-10-17 16:45:49 +08:00
										 |  |  |     License Agreement] (CLA), giving us permission to use your code. | 
					
						
							| 
									
										
										
										
											2023-12-02 22:54:27 +08:00
										 |  |  |     If your contribution is too small to require a CLA (e.g., fixing a spelling | 
					
						
							| 
									
										
										
										
											2023-11-21 02:14:12 +08:00
										 |  |  |     mistake), then place the text "`CLA: trivial`" on a line by itself below | 
					
						
							|  |  |  |     the rest of your commit message separated by an empty line, like this: | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     ``` | 
					
						
							|  |  |  |         One-line summary of trivial change | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         Optional main body of commit message. It might contain a sentence | 
					
						
							|  |  |  |         or two explaining the trivial change. | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         CLA: trivial | 
					
						
							|  |  |  |     ``` | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     It is not sufficient to only place the text "`CLA: trivial`" in the GitHub | 
					
						
							|  |  |  |     pull request description. | 
					
						
							| 
									
										
										
										
											2019-06-27 16:45:26 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-17 16:45:49 +08:00
										 |  |  |     [Contributor License Agreement]: <https://www.openssl.org/policies/cla.html> | 
					
						
							| 
									
										
										
										
											2019-06-27 16:45:26 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     To amend a missing "`CLA: trivial`" line after submission, do the following: | 
					
						
							| 
									
										
										
										
											2020-05-07 19:44:01 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     ``` | 
					
						
							| 
									
										
										
										
											2019-06-27 16:45:26 +08:00
										 |  |  |         git commit --amend | 
					
						
							| 
									
										
										
										
											2023-11-21 02:14:12 +08:00
										 |  |  |         # add the line, save and quit the editor | 
					
						
							|  |  |  |         git push -f [<repository> [<branch>]] | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     ``` | 
					
						
							| 
									
										
										
										
											2020-05-07 19:44:01 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  2. All source files should start with the following text (with | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  |     appropriate comment characters at the start of each line and the | 
					
						
							|  |  |  |     year(s) updated): | 
					
						
							| 
									
										
										
										
											2020-05-07 19:44:01 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     ``` | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  |         Copyright 20xx-20yy The OpenSSL Project Authors. All Rights Reserved. | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2018-12-06 19:52:18 +08:00
										 |  |  |         Licensed under the Apache License 2.0 (the "License").  You may not use | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  |         this file except in compliance with the License.  You can obtain a copy | 
					
						
							|  |  |  |         in the file LICENSE in the source distribution or at | 
					
						
							|  |  |  |         https://www.openssl.org/source/license.html | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     ``` | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  3. Patches should be as current as possible; expect to have to rebase | 
					
						
							| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  |     often. We do not accept merge commits, you will have to remove them | 
					
						
							|  |  |  |     (usually by rebasing) before it will be acceptable. | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2023-12-02 22:54:27 +08:00
										 |  |  |  4. Code provided should follow our [coding style] and compile without warnings. | 
					
						
							|  |  |  |     There is a [Perl tool](util/check-format.pl) that helps | 
					
						
							|  |  |  |     finding code formatting mistakes and other coding style nits. | 
					
						
							| 
									
										
										
										
											2022-09-22 19:27:27 +08:00
										 |  |  |     Where `gcc` or `clang` is available, you should use the | 
					
						
							| 
									
										
										
										
											2020-06-10 23:49:25 +08:00
										 |  |  |     `--strict-warnings` `Configure` option.  OpenSSL compiles on many varied | 
					
						
							| 
									
										
										
										
											2023-12-02 22:54:27 +08:00
										 |  |  |     platforms: try to ensure you only use portable features. | 
					
						
							|  |  |  |     Clean builds via GitHub Actions are required. They are started automatically | 
					
						
							|  |  |  |     whenever a PR is created or updated by committers. | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2022-04-01 17:27:25 +08:00
										 |  |  |     [coding style]: https://www.openssl.org/policies/technical/coding-style.html | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2023-12-02 22:54:27 +08:00
										 |  |  |  5. When at all possible, code contributions should include tests. These can | 
					
						
							| 
									
										
										
										
											2016-10-13 03:49:06 +08:00
										 |  |  |     either be added to an existing test, or completely new.  Please see | 
					
						
							| 
									
										
										
										
											2020-06-10 23:49:25 +08:00
										 |  |  |     [test/README.md](test/README.md) for information on the test framework. | 
					
						
							| 
									
										
										
										
											2016-06-03 17:51:13 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  6. New features or changed functionality must include | 
					
						
							| 
									
										
										
										
											2023-12-02 22:54:27 +08:00
										 |  |  |     documentation. Please look at the `.pod` files in `doc/man[1357]` for | 
					
						
							|  |  |  |     examples of our style. Run `make doc-nits` to make sure that your | 
					
						
							| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  |     documentation changes are clean. | 
					
						
							| 
									
										
										
										
											2018-05-14 11:38:59 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  7. For user visible changes (API changes, behaviour changes, ...), | 
					
						
							| 
									
										
										
										
											2020-04-25 00:25:56 +08:00
										 |  |  |     consider adding a note in [CHANGES.md](CHANGES.md). | 
					
						
							|  |  |  |     This could be a summarising description of the change, and could | 
					
						
							|  |  |  |     explain the grander details. | 
					
						
							| 
									
										
										
										
											2019-02-01 01:55:30 +08:00
										 |  |  |     Have a look through existing entries for inspiration. | 
					
						
							| 
									
										
										
										
											2020-02-03 05:54:01 +08:00
										 |  |  |     Please note that this is NOT simply a copy of git-log one-liners. | 
					
						
							| 
									
										
										
										
											2020-06-10 23:49:25 +08:00
										 |  |  |     Also note that security fixes get an entry in [CHANGES.md](CHANGES.md). | 
					
						
							| 
									
										
										
										
											2023-12-02 22:54:27 +08:00
										 |  |  |     This file helps users get more in-depth information of what comes | 
					
						
							| 
									
										
										
										
											2018-05-14 11:38:59 +08:00
										 |  |  |     with a specific release without having to sift through the higher | 
					
						
							|  |  |  |     noise ratio in git-log. | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2024-02-06 08:01:28 +08:00
										 |  |  |  8. Guidelines on how to integrate error output of new crypto library modules | 
					
						
							| 
									
										
										
										
											2021-01-24 15:42:52 +08:00
										 |  |  |     can be found in [crypto/err/README.md](crypto/err/README.md). |