| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  | HOW TO CONTRIBUTE TO OpenSSL | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  | ============================ | 
					
						
							| 
									
										
										
										
											2015-10-17 19:10:55 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  | Please visit our [Getting Started][gs] page for other ideas about how to contribute. | 
					
						
							| 
									
										
										
										
											2015-10-17 19:10:55 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |   [gs]: https://www.openssl.org/community/getting-started.html | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | Development is done on GitHub in the [openssl/openssl][gh] repository. | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |   [gh]: https://github.com/openssl/openssl | 
					
						
							| 
									
										
										
										
											2015-10-17 19:10:55 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  | To request new features or report bugs, please open an issue on GitHub | 
					
						
							| 
									
										
										
										
											2016-01-26 06:12:57 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  | To submit a patch, please open a pull request on GitHub.  If you are thinking | 
					
						
							|  |  |  | of making a large contribution, open an issue for it before starting work, | 
					
						
							|  |  |  | to get comments from the community.  Someone may be already working on | 
					
						
							|  |  |  | the same thing or there may be reasons why that feature isn't implemented. | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  | To make it easier to review and accept your pull request, please follow these | 
					
						
							|  |  |  | guidelines: | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  1. Anything other than a trivial contribution requires a [Contributor | 
					
						
							|  |  |  |     License Agreement][CLA] (CLA), giving us permission to use your code. | 
					
						
							|  |  |  |     If your contribution is too small to require a CLA (e.g. fixing a spelling | 
					
						
							|  |  |  |     mistake), place the text "`CLA: trivial`" on a line by itself separated by | 
					
						
							| 
									
										
										
										
											2019-06-27 16:45:26 +08:00
										 |  |  |     an empty line from the rest of the commit message. It is not sufficient to | 
					
						
							|  |  |  |     only place the text in the GitHub pull request description. | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     [CLA]: https://www.openssl.org/policies/cla.html | 
					
						
							| 
									
										
										
										
											2019-06-27 16:45:26 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     To amend a missing "`CLA: trivial`" line after submission, do the following: | 
					
						
							|  |  |  |     ``` | 
					
						
							| 
									
										
										
										
											2019-06-27 16:45:26 +08:00
										 |  |  |         git commit --amend | 
					
						
							|  |  |  |         [add the line, save and quit the editor] | 
					
						
							|  |  |  |         git push -f | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     ``` | 
					
						
							|  |  |  |  2. All source files should start with the following text (with | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  |     appropriate comment characters at the start of each line and the | 
					
						
							|  |  |  |     year(s) updated): | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     ``` | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  |         Copyright 20xx-20yy The OpenSSL Project Authors. All Rights Reserved. | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2018-12-06 19:52:18 +08:00
										 |  |  |         Licensed under the Apache License 2.0 (the "License").  You may not use | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  |         this file except in compliance with the License.  You can obtain a copy | 
					
						
							|  |  |  |         in the file LICENSE in the source distribution or at | 
					
						
							|  |  |  |         https://www.openssl.org/source/license.html | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     ``` | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  3. Patches should be as current as possible; expect to have to rebase | 
					
						
							| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  |     often. We do not accept merge commits, you will have to remove them | 
					
						
							|  |  |  |     (usually by rebasing) before it will be acceptable. | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  4. Patches should follow our [coding style][] and compile without warnings. | 
					
						
							|  |  |  |     Where gcc or clang is available you should use the | 
					
						
							| 
									
										
										
										
											2016-06-02 18:03:10 +08:00
										 |  |  |     --strict-warnings Configure option.  OpenSSL compiles on many varied | 
					
						
							| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  |     platforms: try to ensure you only use portable features.  Clean builds | 
					
						
							|  |  |  |     via Travis and AppVeyor are required, and they are started automatically | 
					
						
							|  |  |  |     whenever a PR is created or updated. | 
					
						
							| 
									
										
										
										
											2016-04-27 03:50:28 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |     [coding style]: https://www.openssl.org/policies/codingstyle.html | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |  5. When at all possible, patches should include tests. These can | 
					
						
							| 
									
										
										
										
											2016-10-13 03:49:06 +08:00
										 |  |  |     either be added to an existing test, or completely new.  Please see | 
					
						
							|  |  |  |     test/README for information on the test framework. | 
					
						
							| 
									
										
										
										
											2016-06-03 17:51:13 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  6. New features or changed functionality must include | 
					
						
							| 
									
										
										
										
											2018-04-08 01:09:15 +08:00
										 |  |  |     documentation. Please look at the "pod" files in doc/man[1357] for | 
					
						
							|  |  |  |     examples of our style. Run "make doc-nits" to make sure that your | 
					
						
							|  |  |  |     documentation changes are clean. | 
					
						
							| 
									
										
										
										
											2018-05-14 11:38:59 +08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  7. For user visible changes (API changes, behaviour changes, ...), | 
					
						
							|  |  |  |     consider adding a note in [CHANGES](CHANGES).  This could be a summarising | 
					
						
							| 
									
										
										
										
											2018-05-14 11:38:59 +08:00
										 |  |  |     description of the change, and could explain the grander details. | 
					
						
							| 
									
										
										
										
											2019-02-01 01:55:30 +08:00
										 |  |  |     Have a look through existing entries for inspiration. | 
					
						
							| 
									
										
										
										
											2020-02-03 05:54:01 +08:00
										 |  |  |     Please note that this is NOT simply a copy of git-log one-liners. | 
					
						
							| 
									
										
										
										
											2018-05-14 11:38:59 +08:00
										 |  |  |     Also note that security fixes get an entry in CHANGES. | 
					
						
							|  |  |  |     This file helps users get more in depth information of what comes | 
					
						
							|  |  |  |     with a specific release without having to sift through the higher | 
					
						
							|  |  |  |     noise ratio in git-log. | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-11-29 06:10:51 +08:00
										 |  |  |  8. For larger or more important user visible changes, as well as | 
					
						
							|  |  |  |     security fixes, please add a line in [NEWS](NEWS).  On exception, it might be | 
					
						
							| 
									
										
										
										
											2018-05-14 11:38:59 +08:00
										 |  |  |     worth adding a multi-line entry (such as the entry that announces all | 
					
						
							|  |  |  |     the types that became opaque with OpenSSL 1.1.0). | 
					
						
							|  |  |  |     This file helps users get a very quick summary of what comes with a | 
					
						
							|  |  |  |     specific release, to see if an upgrade is worth the effort. |