root
/
openssl
mirror of https://github.com/openssl/openssl.git
1
0
Fork 0
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fix undefined behaviour when printing the X509 serial 

Found by afl

Reviewed-by: Andy Polyakov <appro@openssl.org>
GH: #2230
This commit is contained in:
Kurt Roeckx 2017-01-14 15:58:42 +01:00
parent a470f02360
commit 244d7b288f
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crypto/x509/t_x509.c
View File

@ -93,12 +93,14 @@ int X509_print_ex(BIO *bp, X509 *x, unsigned long nmflags,
l = -1; l = -1;
} }
if (l != -1) { if (l != -1) {
unsigned long ul;
if (bs->type == V_ASN1_NEG_INTEGER) { if (bs->type == V_ASN1_NEG_INTEGER) {
l = -l; ul = 0 - (unsigned long)l;
neg = "-"; neg = "-";
} else } else
ul = l;
neg = ""; neg = "";
if (BIO_printf(bp, " %s%lu (%s0x%lx)\n", neg, l, neg, l) <= 0) if (BIO_printf(bp, " %s%lu (%s0x%lx)\n", neg, ul, neg, ul) <= 0)
goto err; goto err;
} else { } else {
neg = (bs->type == V_ASN1_NEG_INTEGER) ? " (Negative)" : ""; neg = (bs->type == V_ASN1_NEG_INTEGER) ? " (Negative)" : "";