From 2ee3e38f8f456db4b5afb023ae0472ff79204369 Mon Sep 17 00:00:00 2001 From: Pauli Date: Thu, 13 Jan 2022 12:30:59 +1100 Subject: [PATCH] coverity 1497107: dereference after null check Add null checks to avoid dereferencing a pointer that could be null. Reviewed-by: Tim Hudson Reviewed-by: Tomas Mraz Reviewed-by: David von Oheimb (Merged from https://github.com/openssl/openssl/pull/17488) --- apps/lib/apps.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/apps/lib/apps.c b/apps/lib/apps.c index 25a6b6bcc3..07dd4550f2 100644 --- a/apps/lib/apps.c +++ b/apps/lib/apps.c @@ -696,10 +696,13 @@ int load_cert_certs(const char *uri, if (ret) { if (pcert != NULL) warn_cert(uri, *pcert, 0, vpm); - warn_certs(uri, *pcerts, 1, vpm); + if (pcerts != NULL) + warn_certs(uri, *pcerts, 1, vpm); } else { - sk_X509_pop_free(*pcerts, X509_free); - *pcerts = NULL; + if (pcerts != NULL) { + sk_X509_pop_free(*pcerts, X509_free); + *pcerts = NULL; + } } return ret; }