From 3abc0d3e8504f730117e3b68dfb1aab81c5e51fe Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Mon, 17 Oct 2022 14:37:32 +0100 Subject: [PATCH] Remove supurious set of the record type We already set the record type on the SSL3_RECORD structure. We don't need to do it again (inconsistently). Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz Reviewed-by: Hugo Landau (Merged from https://github.com/openssl/openssl/pull/19424) --- ssl/record/methods/tls_common.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/ssl/record/methods/tls_common.c b/ssl/record/methods/tls_common.c index 40016c121d..5c27a6af15 100644 --- a/ssl/record/methods/tls_common.c +++ b/ssl/record/methods/tls_common.c @@ -1823,13 +1823,6 @@ int tls_write_records_default(OSSL_RECORD_LAYER *rl, goto err; } - /* - * we should now have thiswr->data pointing to the encrypted data, which - * is thiswr->length long. - * Setting the type is not needed but helps for debugging - */ - SSL3_RECORD_set_type(thiswr, thistempl->type); - /* now let's set up wb */ SSL3_BUFFER_set_left(&rl->wbuf[j], SSL3_RECORD_get_length(thiswr)); }