root
/
openssl
mirror of https://github.com/openssl/openssl.git
1
0
Fork 0
Code Issues Actions 7 Packages Projects Releases Wiki Activity

kmac_prov.c.in: avoid resource leak on kmac_new_decoder fail in kmac_fetch_new 

kctx was not freed in a case of kmac_new_decoder failure;  consolidate
all the error paths under the "err:" label and jump to it on kmac_new_decoder()
returning 0.

Fixes: d5efc85379 "kmac: avoid using ossl_prov_digest_load_from_params()"
Resolves: https://github.com/openssl/project/issues/1419
Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1453634
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28516)
This commit is contained in:
Eugene Syromiatnikov 2025-09-11 01:34:12 +02:00 committed by Neil Horman
parent 6c3046657e
commit 3ae8755aa2
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
providers/implementations/macs/kmac_prov.c.in
View File

@ -203,21 +203,23 @@ static void *kmac_fetch_new(void *provctx, const OSSL_PARAM *params)
struct kmac_new_st p;
int md_size;
if (kctx == NULL || !kmac_new_decoder(params, &p))
if (kctx == NULL)
return 0;
if (!kmac_new_decoder(params, &p))
goto err;
if (!ossl_prov_digest_load(&kctx->digest, p.digest, p.propq, p.engine,
PROV_LIBCTX_OF(provctx))) {
kmac_free(kctx);
return 0;
}
PROV_LIBCTX_OF(provctx)))
goto err;
md_size = EVP_MD_get_size(ossl_prov_digest_md(&kctx->digest));
if (md_size <= 0) {
kmac_free(kctx);
return 0;
}
if (md_size <= 0)
goto err;
kctx->out_len = (size_t)md_size;
return kctx;
err:
kmac_free(kctx);
return NULL;
}
static void *kmac128_new(void *provctx)