From 8b940b69457f0dd43496c16afaa01f510f0d8a19 Mon Sep 17 00:00:00 2001 From: Tomas Mraz Date: Wed, 16 Aug 2023 16:07:10 +0200 Subject: [PATCH] ssl_old_test.c: Check inconsistent values from SSL_get0_alpn_selected() Fixes Coverity 1534838 Reviewed-by: Matt Caswell Reviewed-by: Hugo Landau (Merged from https://github.com/openssl/openssl/pull/21755) --- test/ssl_old_test.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/test/ssl_old_test.c b/test/ssl_old_test.c index 439d0ed8d0..8218ab1a90 100644 --- a/test/ssl_old_test.c +++ b/test/ssl_old_test.c @@ -332,6 +332,18 @@ static int verify_alpn(SSL *client, SSL *server) OPENSSL_free(alpn_selected); alpn_selected = NULL; + if (client_proto == NULL && client_proto_len != 0) { + BIO_printf(bio_stdout, + "Inconsistent SSL_get0_alpn_selected() for client!\n"); + goto err; + } + + if (server_proto == NULL && server_proto_len != 0) { + BIO_printf(bio_stdout, + "Inconsistent SSL_get0_alpn_selected() for server!\n"); + goto err; + } + if (client_proto_len != server_proto_len) { BIO_printf(bio_stdout, "ALPN selected protocols differ!\n"); goto err;