From d2a71ed94e82f96a589fbc017d525d415b427337 Mon Sep 17 00:00:00 2001 From: Neil Horman Date: Wed, 13 Aug 2025 10:12:38 -0400 Subject: [PATCH] Add CRYPTO_FREE_REF to ossl_quic_free_token_store MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ossl_quic_free_token_store doesn't call CRYPTO_FREE_REF on the hdl->reference object, which could lead to memory leaks on platforms that don't support atomics (where the call to CRYPTO_NEW_REF allocates a mutex as part of its function. It wasn't caught before because all the platforms we do ci on support threads. Fixes #28241 Reviewed-by: Saša Nedvědický Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/28247) --- ssl/quic/quic_impl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ssl/quic/quic_impl.c b/ssl/quic/quic_impl.c index 6e5970181c..baae2dddba 100644 --- a/ssl/quic/quic_impl.c +++ b/ssl/quic/quic_impl.c @@ -4778,6 +4778,7 @@ void ossl_quic_free_token_store(SSL_TOKEN_STORE *hdl) ossl_crypto_mutex_free(&hdl->mutex); lh_QUIC_TOKEN_doall(hdl->cache, free_this_token); lh_QUIC_TOKEN_free(hdl->cache); + CRYPTO_FREE_REF(&hdl->references); OPENSSL_free(hdl); return; }