14069 Commits

Author	SHA1	Message	Date
Tomas Mraz	18a17538cf	Keep the provided peer EVP_PKEY in the EVP_PKEY_CTX too ... Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26976) (cherry picked from commit 2656922feb)	2025-03-14 09:51:40 +01:00
Jakub Zelenka	6b3d70ffa4	Fix libctx passing for CMS PWRI use ... Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26937) (cherry picked from commit 5045712d3d)	2025-03-03 09:27:21 +01:00
slontis	76d1ffb6f1	Encoder : Fix floating pointer when OSSL_ENCODER_to_data() is called ... twice. Fixes #26862 This only happens when using the FIPS provider, since it needs to export the key. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26891) (cherry picked from commit c2f4d7aae1)	2025-02-28 13:57:48 +01:00
Niels Dossche	9e1fb45a18	Fix potential leak in error path in cert_response() ... get1_cert_status() returns an object that must be freed, but the error path does not do that. Fix it by adding a call to X509_free() in the error path. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26513) (cherry picked from commit 56160f173d)	2025-02-25 15:49:20 +01:00
Bernd Edlinger	d2cc1974ee	Make CRYPTO_atomic_load/store use the same preprocessor guards ... as the other CRYPTO_atomic_X functions. All CRYPTO_atomic functions should use the same logic here, just in case... Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26815) (cherry picked from commit 3240427a85)	2025-02-21 14:52:37 +01:00
Neil Horman	bdce042649	Fix memory leak in ecdsa_keygen_knownanswer_test ... We allocate an EC_POINT with EC_POINT_new here, but in failing a subsequent check, we don't free it, correct that. Fixes #26779 Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from https://github.com/openssl/openssl/pull/26799) (cherry picked from commit 20a2f3beba)	2025-02-19 09:40:03 -05:00
Sebastian Andrzej Siewior	7e3308062f	SPARC assembly: Don't file aes-cbc on T4 with small sizes. ... The "openssl speed -testmode -seconds 1 -bytes 1 aes-128-cbc" test revealed that the assembly code is crashing if length is less than 16. The code shifts the provided length by 4 and than subtracts one until the length hits zero. If it was already zero then it underflows the counter and continues until it segfaults on reading or writing. Replace the check against 0 with less than 15. Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25637) (cherry picked from commit c71c65b922)	2025-02-14 11:43:23 +01:00
openssl-machine	d946580be6	Copyright year updates ... Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Release: yes	2025-02-11 14:40:50 +00:00
Stas Cymbalov	a905dd23d2	Fix data race in asn1_str2tag() on tntmp which was accidentally made static ... Variables tntmp and tnst are declared in the same declaration and thus share storage class specifiers (static). This is unfortunate as tntmp is used during iteration through tnst array and shouldn't be static. In particular this leads to two problems that may arise when multiple threads are executing asn1_str2tag() concurrently: 1. asn1_str2tag() might return value that doesn't correspond to tagstr parameter. This can happen if other thread modifies tntmp to point to a different tnst element right after a successful name check in the if statement. 2. asn1_str2tag() might perform an out-of-bounds read of tnst array. This can happen when multiple threads all first execute tntmp = tnst; line and then start executing the loop. If that case those threads can end up incrementing tntmp past the end of tnst array. CLA: trivial Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26504) (cherry picked from commit 7262c0bcc4)	2025-01-23 12:14:39 +01:00
Michael Baentsch	d345ce4d78	Improve ASN1_TIME_print documentation and output ... This adds missing GMT indication when printing the local time as it is converted to the UTC timezone before printing. Also fixing the fractional seconds printing on EBCDIC platforms. Fixes #26313 Reviewed-by: Todd Short <todd.short@me.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26344) (cherry picked from commit c81ff97866)	2025-01-22 11:31:31 +01:00
Tomas Mraz	2af62e74fb	Fix timing side-channel in ECDSA signature computation ... There is a timing signal of around 300 nanoseconds when the top word of the inverted ECDSA nonce value is zero. This can happen with significant probability only for some of the supported elliptic curves. In particular the NIST P-521 curve is affected. To be able to measure this leak, the attacker process must either be located in the same physical computer or must have a very fast network connection with low latency. Attacks on ECDSA nonce are also known as Minerva attack. Fixes CVE-2024-13176 Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from https://github.com/openssl/openssl/pull/26429) (cherry picked from commit 63c40a66c5)	2025-01-20 09:41:32 +01:00
otherddn1978	2bd0e81e50	If you call X509_add_cert with cert == NULL and the X509_ADD_FLAG_UP_REF ... flag, it will сrash to X509_up_ref. Passing NULL here is not valid, return 0 if cert == NULL. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com> (Merged from https://github.com/openssl/openssl/pull/26267) (cherry picked from commit 3c7db9e0fd)	2025-01-20 08:44:50 +01:00
Nikolay Nikolaev	c4429159f9	Workaround for RSA on AArch64 Big Endian ... 1064616012 introduced and optimized RSA NEON implementation for AArch64 architecture, namely Cortex-A72 and Neoverse N1. This implementation is broken in Big Endian mode, which is not widely used, therefore not properly verified. Here we disable this optimized implementation when Big Endian platform is used. Fixes: #22687 CLA: trivial Signed-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26257) (cherry picked from commit b26894ec69)	2025-01-15 17:53:18 +01:00
Dmitry Belyavskiy	4b3b4027c6	Take into account no_store when pushing algorithm ... When we put algorithm to the store, we have a fallback to the OSSL_LIB_CTX level store when store is NULL. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (cherry picked from commit b3bb214720) Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from https://github.com/openssl/openssl/pull/26231)	2025-01-13 10:48:15 +01:00
Richard Levitte	5d0cf88a83	Fix the use of OPENSSL_HTTP_PROXY / OPENSSL_HTTPS_PROXY ... Fixes #26337 Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26340) (cherry picked from commit 6a2472fb3e)	2025-01-09 12:04:28 +01:00
Frederik Wedel-Heinen	61217d142c	Return NULL from ossl_lib_ctx_get_concrete() when it is uninitialized ... When default_context_inited is set to false we return NULL instead of the global default context. Fixes #25442 Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26319) (cherry picked from commit dfce0d7418)	2025-01-08 11:20:11 +01:00
Niels Dossche	61db4145df	Fix potential memory leak in PKCS12_add_key_ex() ... p8 is allocated using EVP_PKEY2PKCS8(), but when PKCS8_add_keyusage() fails this memory is not freed. Fix this by adding a call to PKCS8_PRIV_KEY_INFO_free(). Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com> Reviewed-by: Hugo Landau <hlandau@devever.net> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25818) (cherry picked from commit f822a48668)	2025-01-06 21:33:30 +01:00
Job Snijders	e4901e6674	Clean up ASN1_STRING comment and improve example in docs ... Reviewed-by: Hugo Landau <hlandau@devever.net> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26195) (cherry picked from commit 2e36bb07b5)	2025-01-06 20:39:52 +01:00
Jakub Zelenka	f3acb0addd	Fix CMS encryption with key agreement when originator set ... OpenSSL currently does not support encryption with originator flag so it should fail nicely instead of segfaulting. Reviewed-by: Hugo Landau <hlandau@devever.net> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26014) (cherry picked from commit 894e69e747)	2025-01-06 11:47:42 +01:00
Adrien Zinger	6c93b03e9a	Fix GCC compilation -Waggressive-loop-optimizations ... GCC 13.1.0 were reporting a compilation warning with -O2/3 and -Waggressive-loop-optimizations. GCC is raising an undefined behavior in the while loop. Replace the while loop with a memset call at the top of the function. Fixes #21088 CLA: trivial Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from https://github.com/openssl/openssl/pull/23898) (cherry picked from commit c45ca0656f)	2025-01-03 16:00:57 +01:00
Niels Dossche	91cbe80409	Fix potential memory leak in BIO_get_accept_socket() ... When BIO_parse_hostserv() fails it may still have allocated memory, yet this memory is not freed. Fix it by jumping to the err label. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25817) (cherry picked from commit 32476957ea)	2025-01-02 14:10:14 +01:00
Andrey Tsygunka	efbbb582e7	ossl_i2c_ASN1_BIT_STRING(): Fix a possible heap buffer overflow ... When data contains only zero values a buffer overflow happens. CLA: trivial Signed-off-by: Andrey Tsygunka <aitsygunka@yandex.ru> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26190) (cherry picked from commit bf2dea0e2c)	2024-12-20 09:49:52 +01:00
otherddn1978	ad8b2a9a0a	Check whether ctx->pctx != NULL ... If it is NULL, ctx->pctx->pmeth dereference will cause a crash. Found by Linux Verification Center (linuxtesting.org) with SVACE. Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26176) (cherry picked from commit 82e7a1130a)	2024-12-17 14:57:17 +01:00
Shakti Shah	163506fa0c	dh_cms_set_peerkey(): Fix the incorrect condition ... Only absent parameters allowed in RFC 3370. Fixes #25824 Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26058) (cherry picked from commit 02e72ccffa)	2024-12-11 18:13:52 +01:00
Tomas Mraz	f971a9ed58	Avoid NULL dereference with PKCS7_OP_SET_DETACHED_SIGNATURE ... We would dereference p7->d.sign pointer which can be NULL. Reported by Han Zheng. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26078) (cherry picked from commit f2348f1f84)	2024-12-02 09:45:36 +01:00
slontis	a9c16d4128	Fix EVP_PKEY_print_private() so that it works with non default providers. ... At some point in time it was decided that the EC keymanagers ec_export() function would only allow the selection to be both the public + private parts. If just the private element is selected it returns an error. Many openssl commandline apps use EVP_PKEY_print_private() which passes EVP_PKEY_PRIVATE_KEY to the encoder. This selection propagates to encoder_construct_pkey(). For external providers (such as the fips provider this will call the keymanagers export() with the selection set to just the private part. So we either need to 1) change the selection in EVP_PKEY_print_private() or 2) modify the selection used in the export used in encoder_construct_pkey 3) Change the ec_export to allow this. I have chosen 2) but I am not sure if this is the correct thing to do or whether it should conditionally do this when the output_type == 'text'. Issue was reported by Ilia Okomin (Oracle). Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26004) (cherry picked from commit 79c98fc6cc)	2024-11-29 17:15:19 +01:00
Kai Pastor	ae11305026	Mark OPENSSL_armcap_P .hidden in arm asm ... Fixes #25601 Fixes #22414 Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/22181) (cherry picked from commit e131868678)	2024-11-22 11:23:28 +01:00
Tomas Mraz	53931e6792	sm2_sig_verify(): Do not call BN_CTX_end() without BN_CTX_start() ... In case of memory allocation failure this could happen. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from https://github.com/openssl/openssl/pull/25994) (cherry picked from commit 93bfe97c5b)	2024-11-21 11:17:53 +01:00
Bernd Edlinger	8d723690b0	Fix error handling in CMS_EncryptedData_encrypt ... That caused several memory leaks in case of error. Also when the CMS object that is created by CMS_EncryptedData_encrypt is not used in the normal way, but instead just deleted by CMS_ContentInfo_free some memory was lost. Fixes #21985 Reviewed-by: Hugo Landau <hlandau@devever.net> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/22044)	2024-11-13 17:12:23 +01:00
Vladimirs Ambrosovs	ff473606bb	Bugfixes for params to legacy control translations for EC parameters ... param->ctrl translation: Fix fix_ecdh_cofactor() In POST_PARAMS_TO_CTRL state the fix_ecdh_cofactor() function should return value in ctx->p1 param->ctrl translation: fix evp_pkey_ctx_setget_params_to_ctrl return Since some of the ctrl operations may return 0 as valid value (e.g. ecdh_cofactor value 0 is valid setting), before colling POST_PARAMS_TO_CTRL, we need to check return value for 0 as well otherwise the evp_pkey_ctx_setget_params_to_ctrl function fails without a chance to fix the return value param->ctrl translation: Set ecdh_cofactor default action_type GET Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/22587) (cherry picked from commit 2aaef03339)	2024-11-07 10:40:22 +01:00
oleg.hoefling	bae01d7e1d	Adjust naming authority formatting when printing out admission extension ... Indent namingAuthority section with two spaces to match the parent node. Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25814) (cherry picked from commit 85a52f7292)	2024-11-07 10:33:36 +01:00
Niels Dossche	bf535a9b00	Fix memory leak on failure in copy_issuer() ... When sk_GENERAL_NAME_reserve() fails, ialt is not freed. Add the freeing operation in the common error path. Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25876) (cherry picked from commit fa856b0ce0)	2024-11-07 10:20:36 +01:00
Jakub Zelenka	7a95946ff5	Fix smime-type for AuthEnvelopedData ... Reviewed-by: Hugo Landau <hlandau@devever.net> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25523) (cherry picked from commit 4c8c37e572)	2024-11-05 18:56:02 +01:00
Dr. David von Oheimb	5174da45a3	TRACE: automatically respect disabled categories ... by fixing OSSL_trace_begin() to return NULL when given category is not enabled Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25652) (cherry picked from commit 72d3e9bac4)	2024-10-23 15:17:15 +02:00
Viktor Dukhovni	fdf6723362	Harden BN_GF2m_poly2arr against misuse. ... The BN_GF2m_poly2arr() function converts characteristic-2 field (GF_{2^m}) Galois polynomials from a representation as a BIGNUM bitmask, to a compact array with just the exponents of the non-zero terms. These polynomials are then used in BN_GF2m_mod_arr() to perform modular reduction. A precondition of calling BN_GF2m_mod_arr() is that the polynomial must have a non-zero constant term (i.e. the array has `0` as its final element). Internally, callers of BN_GF2m_poly2arr() did not verify that precondition, and binary EC curve parameters with an invalid polynomial could lead to out of bounds memory reads and writes in BN_GF2m_mod_arr(). The precondition is always true for polynomials that arise from the standard form of EC parameters for characteristic-two fields (X9.62). See the "Finite Field Identification" section of: https://www.itu.int/ITU-T/formal-language/itu-t/x/x894/2018-cor1/ANSI-X9-62.html The OpenSSL GF(2^m) code supports only the trinomial and pentanomial basis X9.62 forms. This commit updates BN_GF2m_poly2arr() to return `0` (failure) when the constant term is zero (i.e. the input bitmask BIGNUM is not odd). Additionally, the return value is made unambiguous when there is not enough space to also pad the array with a final `-1` sentinel value. The return value is now always the number of elements (including the final `-1`) that would be filled when the output array is sufficiently large. Previously the same count was returned both when the array has just enough room for the final `-1` and when it had only enough space for non-sentinel values. Finally, BN_GF2m_poly2arr() is updated to reject polynomials whose degree exceeds `OPENSSL_ECC_MAX_FIELD_BITS`, this guards against CPU exhausition attacks via excessively large inputs. The above issues do not arise in processing X.509 certificates. These generally have EC keys from "named curves", and RFC5840 (Section 2.1.1) disallows explicit EC parameters. The TLS code in OpenSSL enforces this constraint only after the certificate is decoded, but, even if explicit parameters are specified, they are in X9.62 form, which cannot represent problem values as noted above. Initially reported as oss-fuzz issue 71623. A closely related issue was earlier reported in <https://github.com/openssl/openssl/issues/19826>. Severity: Low, CVE-2024-9143 Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25639) (cherry picked from commit 8e008cb8b2)	2024-10-16 09:22:27 +02:00
Dr. David von Oheimb	2d0e1fc59e	replace various calls to sprintf() by BiO_snprintf() to avoid compiler warnings, e.g., on MacOS ... Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Saša Nedvědický <sashan@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25534) (cherry picked from commit 2c536c8b15)	2024-10-12 15:57:32 +02:00
Niels Dossche	698e36ad21	Fix potential double free through SRP_user_pwd_set1_ids() ... If SRP_user_pwd_set1_ids() fails during one of the duplications, or id is NULL, then the old pointer values are still stored but they are now dangling. Later when SRP_user_pwd_free() is called these are freed again, leading to a double free. Although there are no such uses in OpenSSL as far as I found, it's still a public API. CLA: trivial Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25655) (cherry picked from commit 792b2c8da2)	2024-10-11 14:23:24 +02:00
Taylor R Campbell	3bbc5e66fb	Avoid undefined behaviour with the <ctype.h> functions. ... fix https://github.com/openssl/openssl/issues/25112 As defined in the C standard: In all cases the argument is an int, the value of which shall be representable as an unsigned char or shall equal the value of the macro EOF. If the argument has any other value, the behavior is undefined. This is because they're designed to work with the int values returned by getc or fgetc; they need extra work to handle a char value. If EOF is -1 (as it almost always is), with 8-bit bytes, the allowed inputs to the ctype.h functions are: {-1, 0, 1, 2, 3, ..., 255}. However, on platforms where char is signed, such as x86 with the usual ABI, code like char *p = ...; ... isspace(*p) ... may pass in values in the range: {-128, -127, -126, ..., -2, -1, 0, 1, ..., 127}. This has two problems: 1. Inputs in the set {-128, -127, -126, ..., -2} are forbidden. 2. The non-EOF byte 0xff is conflated with the value EOF = -1, so even though the input is not forbidden, it may give the wrong answer. Casting char inputs to unsigned char first works around this, by mapping the (non-EOF character) range {-128, -127, ..., -1} to {128, 129, ..., 255}, leaving no collisions with EOF. So the above fragment needs to be: char *p = ...; ... isspace((unsigned char)*p) ... This patch inserts unsigned char casts where necessary. Most of the cases I changed, I compile-tested using -Wchar-subscripts -Werror on NetBSD, which defines the ctype.h functions as macros so that they trigger the warning when the argument has type char. The exceptions are under #ifdef __VMS or #ifdef _WIN32. I left alone calls where the input is int where the cast would obviously be wrong; and I left alone calls where the input is already unsigned char so the cast is unnecessary. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25113) (cherry picked from commit 99548cd16e)	2024-10-10 20:48:38 +02:00
Dmitry Belyavskiy	3004712d4b	Increase limit for CRL download ... Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25608) (cherry picked from commit cdbe47bf3c)	2024-10-08 16:04:04 +02:00
Niels Dossche	b1edb56554	Fix potential memory leak in save_statusInfo() ... If sk_ASN1_UTF8STRING_push() fails then the duplicated string will leak memory. Add a ASN1_UTF8STRING_free() to fix this. CLA: trivial Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25604) (cherry picked from commit 0a2a8d970f)	2024-10-07 17:58:54 +02:00
Niels Dossche	09b96bf7b5	Fix potential memory leak in PKCS7_signatureVerify() ... Fixes #25594 The code jumps to an error block when EVP_VerifyUpdate fails. This error block does not free abuf. In the success path the abuf memory is freed. Move the free operation to the error block. CLA: trivial Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25596) (cherry picked from commit d8b7a6eae9)	2024-10-07 17:56:24 +02:00
Зишан Мирза	80e57e9f0b	Remove double engine reference in ossl_ec_key_dup() ... Fixes #25260 Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25453) (cherry picked from commit ffc5a29608)	2024-09-26 10:27:19 +02:00
Shawn C	68af032a78	Fix NULL ptr dereference on EC_POINT *point ... Use non-usual params of pkcs11 module will trigger a null ptr deref bug. Fix it for #25493 CLA: trivial Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25496) (cherry picked from commit 8ac42a5f41)	2024-09-26 10:05:22 +02:00
David von Oheimb	847724a86d	OSSL_HTTP_adapt_proxy(): fix handling of escaped IPv6 host addresses and of whitespace in no_proxy ... Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from https://github.com/openssl/openssl/pull/25533) (cherry picked from commit b59b74fd07)	2024-09-26 10:00:16 +02:00
David von Oheimb	8315e1e505	OSSL_HTTP_open(): fix completion with default port for IPv6 host addresses ... Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from https://github.com/openssl/openssl/pull/25533) (cherry picked from commit a78da17491)	2024-09-26 10:00:15 +02:00
Paul E. Murphy	dde298ca98	Fix big-endian Power10 chacha20 implementation ... Some of the BE specific permutes were incorrect. Fix them. This passes all tests on a P10/ppc64 debian unstable host. Fixes #25451 CLA: trivial Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25483) (cherry picked from commit daead12df0)	2024-09-19 11:14:13 +02:00
Gerd Hoffmann	578d1d1609	fix small footprint builds on arm ... Building with '-D OPENSSL_SMALL_FOOTPRINT' for aarch64 fails due to 'gcm_ghash_4bit' being undeclared. Fix that by not setting the function pointer when building with OPENSSL_SMALL_FOOTPRINT, matching openssl behavior on x86. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25419) (cherry picked from commit 2a53df6947)	2024-09-12 09:11:26 +10:00
erbsland-dev	623b7761c7	Fix Edge Cases in Password Callback Handling ... Fixes #8441: Modify the password callback handling to reserve one byte in the buffer for a null terminator, ensuring compatibility with legacy behavior that puts a terminating null byte at the end. Additionally, validate the length returned by the callback to ensure it does not exceed the given buffer size. If the returned length is too large, the process now stops gracefully with an appropriate error, enhancing robustness by preventing crashes from out-of-bounds access. Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25330) (cherry picked from commit 5387b71acb)	2024-09-09 09:04:30 +02:00
Zhihao Yuan	0810f5570d	Recycle the TLS key that holds thread_event_handler ... Fixes #25278 Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25300) (cherry picked from commit 36840ab577)	2024-09-05 17:20:43 +02:00
Georgi Valkov	135fa8dbe3	threads_win: fix improper cast to long * instead of LONG * ... InterlockedExchangeAdd expects arguments of type LONG *, LONG but the int arguments were improperly cast to long *, long Note: - LONG is always 32 bit - long is 32 bit on Win32 VC x86/x64 and MingW-W64 - long is 64 bit on cygwin64 Signed-off-by: Georgi Valkov <gvalkov@gmail.com> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25360) (cherry picked from commit b0ed90cc30)	2024-09-05 17:12:19 +02:00