Go to file
Billy Brumley b783beeadf [crypto/ec] for ECC parameters with NULL or zero cofactor, compute it
The cofactor argument to EC_GROUP_set_generator is optional, and SCA mitigations for ECC currently use it. So the library currently falls back to very old SCA-vulnerable code if the cofactor is not present.

This PR allows EC_GROUP_set_generator to compute the cofactor for all curves of cryptographic interest. Steering scalar multiplication to more SCA-robust code.

This issue affects persisted private keys in explicit parameter form, where the (optional) cofactor field is zero or absent.

It also affects curves not built-in to the library, but constructed programatically with explicit parameters, then calling EC_GROUP_set_generator with a nonsensical value (NULL, zero).

The very old scalar multiplication code is known to be vulnerable to local uarch attacks, outside of the OpenSSL threat model. New results suggest the code path is also vulnerable to traditional wall clock timing attacks.

CVE-2019-1547

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/9827)
2019-09-05 10:21:04 +01:00
.github Auto add a label depending on the type of issue they report. 2019-07-16 20:33:01 +02:00
Configurations testing: set OPENSSL_MODULES to the providers directory by default 2019-08-27 11:53:33 +02:00
VMS Following the license change, modify the boilerplates in last few 2018-12-06 15:40:33 +01:00
apps Move libapps.a source to apps/lib 2019-09-04 17:26:07 +02:00
boringssl@2070f8ad91 Update ossl_config.json for later BoringSSL commit 2017-03-14 12:12:13 +00:00
crypto [crypto/ec] for ECC parameters with NULL or zero cofactor, compute it 2019-09-05 10:21:04 +01:00
demos Fix Typos 2019-07-02 14:22:29 +02:00
doc Change provider params from int to size_t 2019-09-05 11:23:57 +10:00
engines Replace FUNCerr with ERR_raise_data 2019-08-02 11:41:54 +02:00
external/perl Following the license change, modify the boilerplates in external/ 2018-12-06 15:39:02 +01:00
fuzz Update fuzz README.md 2019-08-29 11:01:39 +01:00
include Change provider params from int to size_t 2019-09-05 11:23:57 +10:00
krb5@b9ad6c4950 [extended tests] Enable krb5 tests in Travis 2017-04-18 19:10:25 +02:00
ms Windows: Call TerminateProcess, not ExitProcess 2019-02-22 21:03:45 +01:00
os-dep Move Haiku configuration to separate config file to denote 2016-05-19 22:39:52 +02:00
providers Change provider params from int to size_t 2019-09-05 11:23:57 +10:00
pyca-cryptography@09403100de Update the pyca-cryptography submodule 2018-09-10 12:04:03 +01:00
ssl Fix bogus check for EVP_PKEY_supports_digest_nid() in check_cert_usable() 2019-08-27 15:32:59 +01:00
test Change provider params from int to size_t 2019-09-05 11:23:57 +10:00
tools Following the license change, modify the boilerplates in util/, tools/ 2018-12-06 14:17:23 +01:00
util Handle the renamed command POD files in find-doc-nits 2019-09-04 17:35:51 +02:00
.gitattributes Don't export the submodules 'boringssl', 'krb5' and 'pyca-cryptography' 2018-11-24 18:40:31 +01:00
.gitignore Refactor apps/progs.* to be generate with 'make update' 2019-07-15 07:00:29 +02:00
.gitmodules [extended tests] Enable krb5 tests in Travis 2017-04-18 19:10:25 +02:00
.travis-apt-pin.preferences Fix travis clang-3.9 builds 2017-06-23 17:57:02 +01:00
.travis-create-release.sh Remove all 'make dist' artifacts 2018-11-23 12:40:32 +01:00
.travis.yml Make failed messages easier to find 2019-09-05 10:56:31 +02:00
ACKNOWLEDGEMENTS
AUTHORS Update AUTHORS list, add commentary 2018-07-08 20:32:04 -04:00
CHANGES Fix NITs in comments and CHANGES for DEVRANDOM seeded check. 2019-08-30 07:55:46 +10:00
CONTRIBUTING Add a note in the contributing file about trivial commits. 2019-06-27 23:23:17 +10:00
Configure Configure: Allow 'DEFINE[]=def' 2019-08-23 17:16:48 +02:00
FAQ
HACKING A very brief explanation of how to add custom functions to OpenSSL. 2019-07-08 20:09:13 +10:00
INSTALL INSTALL: clarify documentation of the --api=x.y.z deprecation option 2019-08-15 14:57:18 +02:00
LICENSE Change license to the Apache License v2.0 2018-12-06 13:27:18 +01:00
NEWS Document recent changes in NEWS and CHANGES 2019-07-31 09:33:24 +02:00
NOTES.ANDROID Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
NOTES.DJGPP Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
NOTES.PERL Fix typo in NOTES.PERL 2019-05-16 11:46:59 +10:00
NOTES.UNIX NOTES.UNIX: add "Linking your application" paragraph 2018-06-26 12:28:06 +02:00
NOTES.VALGRIND Add documentation for running unit tests under Valgrind 2019-05-03 17:46:28 +02:00
NOTES.VMS Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
NOTES.WIN Configure: final cleanup of asm related things 2019-06-17 16:08:53 +02:00
README Change license to the Apache License v2.0 2018-12-06 13:27:18 +01:00
README.ENGINE Remove bsd_cryptodev engine 2017-06-19 09:31:45 -04:00
README.FIPS Remove more (rest?) of FIPS build stuff. 2016-01-06 12:07:26 -05:00
appveyor.yml CI config: no need to make both install and install_docs 2018-05-14 17:51:48 +02:00
build.info Move where include path for providers/common/include gets specified 2019-05-23 11:02:04 +01:00
config iOS build: Replace %20 with space in config script 2019-07-08 10:55:57 +02:00
config.com Following the license change, modify the boilerplates in last few 2018-12-06 15:40:33 +01:00
e_os.h Don't include the DEVRANDOM being seeded logic on Android. 2019-08-30 08:01:34 +10:00

README

 OpenSSL 3.0.0-dev

 Copyright (c) 1998-2018 The OpenSSL Project
 Copyright (c) 1995-1998 Eric A. Young, Tim J. Hudson
 All rights reserved.

 DESCRIPTION
 -----------

 The OpenSSL Project is a collaborative effort to develop a robust,
 commercial-grade, fully featured, and Open Source toolkit implementing the
 Transport Layer Security (TLS) protocols (including SSLv3) as well as a
 full-strength general purpose cryptographic library.

 OpenSSL is descended from the SSLeay library developed by Eric A. Young
 and Tim J. Hudson.

 The OpenSSL toolkit is licensed under the Apache License 2.0, which means
 that you are free to get and use it for commercial and non-commercial
 purposes as long as you fulfill its conditions.

 OVERVIEW
 --------

 The OpenSSL toolkit includes:

 libssl (with platform specific naming):
     Provides the client and server-side implementations for SSLv3 and TLS.

 libcrypto (with platform specific naming):
     Provides general cryptographic and X.509 support needed by SSL/TLS but
     not logically part of it.

 openssl:
     A command line tool that can be used for:
        Creation of key parameters
        Creation of X.509 certificates, CSRs and CRLs
        Calculation of message digests
        Encryption and decryption
        SSL/TLS client and server tests
        Handling of S/MIME signed or encrypted mail
        And more...

 INSTALLATION
 ------------

 See the appropriate file:
        INSTALL         Linux, Unix, Windows, OpenVMS, ...
        NOTES.*         INSTALL addendums for different platforms

 SUPPORT
 -------

 See the OpenSSL website www.openssl.org for details on how to obtain
 commercial technical support. Free community support is available through the
 openssl-users email list (see
 https://www.openssl.org/community/mailinglists.html for further details).

 If you have any problems with OpenSSL then please take the following steps
 first:

    - Download the latest version from the repository
      to see if the problem has already been addressed
    - Configure with no-asm
    - Remove compiler optimization flags

 If you wish to report a bug then please include the following information
 and create an issue on GitHub:

    - OpenSSL version: output of 'openssl version -a'
    - Configuration data: output of 'perl configdata.pm --dump'
    - OS Name, Version, Hardware platform
    - Compiler Details (name, version)
    - Application Details (name, version)
    - Problem Description (steps that will reproduce the problem, if known)
    - Stack Traceback (if the application dumps core)

 Just because something doesn't work the way you expect does not mean it
 is necessarily a bug in OpenSSL. Use the openssl-users email list for this type
 of query.

 HOW TO CONTRIBUTE TO OpenSSL
 ----------------------------

 See CONTRIBUTING

 LEGALITIES
 ----------

 A number of nations restrict the use or export of cryptography. If you
 are potentially subject to such restrictions you should seek competent
 professional legal advice before attempting to develop or distribute
 cryptographic code.