root
/
playwright
mirror of https://github.com/microsoft/playwright.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(trace-viewer): survive broken selectors (#21866) 

Fixes https://github.com/microsoft/playwright/issues/21832
This commit is contained in:
Andrey Lushnikov 2023-03-23 01:52:04 +00:00 committed by GitHub
parent d10fac4f6a
commit 3477c89f20
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/trace-viewer/src/ui/actionList.tsx
View File

@ -60,7 +60,7 @@ const renderAction = (
revealConsole: () => void revealConsole: () => void
) => { ) => {
const { errors, warnings } = modelUtil.stats(action); const { errors, warnings } = modelUtil.stats(action);
const locator = action.params.selector ? asLocator(sdkLanguage || 'javascript', action.params.selector) : undefined; const locator = action.params.selector ? asLocator(sdkLanguage || 'javascript', action.params.selector, false /* isFrameLocator */, true /* playSafe */) : undefined;
let time: string = ''; let time: string = '';
if (action.endTime) if (action.endTime)

2
packages/trace-viewer/src/ui/callTab.tsx
View File

@ -95,7 +95,7 @@ function propertyToString(event: ActionTraceEvent, name: string, value: any, sdk
if ((name === 'value' && isEval) || (name === 'received' && event.method === 'expect')) if ((name === 'value' && isEval) || (name === 'received' && event.method === 'expect'))
value = parseSerializedValue(value, new Array(10).fill({ handle: '<handle>' })); value = parseSerializedValue(value, new Array(10).fill({ handle: '<handle>' }));
if (name === 'selector') if (name === 'selector')
return { text: asLocator(sdkLanguage || 'javascript', event.params.selector), type: 'locator', name: 'locator' }; return { text: asLocator(sdkLanguage || 'javascript', event.params.selector, false /* isFrameLocator */, true /* playSafe */), type: 'locator', name: 'locator' };
const type = typeof value; const type = typeof value;
if (type !== 'object' || value === null) if (type !== 'object' || value === null)
return { text: String(value), type, name }; return { text: String(value), type, name };

2
packages/trace-viewer/src/ui/snapshotTab.tsx
View File

@ -265,7 +265,7 @@ export const InspectModeController: React.FunctionComponent<{
recorder = new Recorder(injectedScript, { recorder = new Recorder(injectedScript, {
async setSelector(selector: string) { async setSelector(selector: string) {
recorder!.setUIState({ mode: 'none', language: sdkLanguage, testIdAttributeName }); recorder!.setUIState({ mode: 'none', language: sdkLanguage, testIdAttributeName });
setHighlightedLocator(asLocator('javascript', selector, false)); setHighlightedLocator(asLocator('javascript', selector, false /* isFrameLocator */, true /* playSafe */));
} }
}); });
win._recorder = recorder; win._recorder = recorder;

13
tests/library/trace-viewer.spec.ts
View File

@ -689,6 +689,19 @@ test('should include requestUrl in route.fulfill', async ({ page, runAndTrace, b
await expect(callLine.getByText('requestUrl')).toContainText('http://test.com'); await expect(callLine.getByText('requestUrl')).toContainText('http://test.com');
}); });
test('should not crash with broken locator', async ({ page, runAndTrace, server }) => {
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/21832' });
const traceViewer = await runAndTrace(async () => {
try {
await page.locator('[class*=github-btn] a]').click();
} catch (e) {
}
});
await expect(traceViewer.page).toHaveTitle('Playwright Trace Viewer');
const header = traceViewer.page.getByText('Playwright', { exact: true });
await expect(header).toBeVisible();
});
test('should include requestUrl in route.continue', async ({ page, runAndTrace, server }) => { test('should include requestUrl in route.continue', async ({ page, runAndTrace, server }) => {
await page.route('**/*', route => { await page.route('**/*', route => {
route.continue({ url: server.EMPTY_PAGE }); route.continue({ url: server.EMPTY_PAGE });