root
/
playwright
mirror of https://github.com/microsoft/playwright.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity

browser(firefox): handle message manager `error` event without error (#1344) 

Type TypeError that happens while loading document is reported in
the message manager but does not have the error event.

Saw this while reproducing #1307
This commit is contained in:
Andrey Lushnikov 2020-03-11 13:37:31 -07:00 committed by GitHub
parent 6b50c8f9cc
commit 3b85bf9c1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browser_patches/firefox/BUILD_NUMBER
View File

@ -1 +1 @@
1041 1042

4
browser_patches/firefox/patches/bootstrap.diff
View File

@ -2458,7 +2458,7 @@ index 0000000000000000000000000000000000000000..be70ea364f9534bb3b344f64970366c3
+ +
diff --git a/juggler/content/PageAgent.js b/juggler/content/PageAgent.js diff --git a/juggler/content/PageAgent.js b/juggler/content/PageAgent.js
new file mode 100644 new file mode 100644
index 0000000000000000000000000000000000000000..05c814d2b6a3df8d770acba723051eb52063bd4f index 0000000000000000000000000000000000000000..3cafc06be2262a79e8459eb9afc03d424bc01303
--- /dev/null --- /dev/null
+++ b/juggler/content/PageAgent.js +++ b/juggler/content/PageAgent.js
@@ -0,0 +1,919 @@ @@ -0,0 +1,919 @@
@ -2821,7 +2821,7 @@ index 0000000000000000000000000000000000000000..05c814d2b6a3df8d770acba723051eb5
+ this._browserPage.emit('pageUncaughtError', { + this._browserPage.emit('pageUncaughtError', {
+ frameId: frame.id(), + frameId: frame.id(),
+ message: errorEvent.message, + message: errorEvent.message,
+ stack: errorEvent.error.stack + stack: errorEvent.error ? errorEvent.error.stack : '',
+ }); + });
+ } + }
+ +