root
/
playwright
mirror of https://github.com/microsoft/playwright.git
1
0
Fork 0
Code Issues Actions 17 Packages Projects Releases Wiki Activity

cherry-pick(#36625): chore: render overlay on top of modal dom content

This commit is contained in:
Pavel Feldman 2025-07-09 12:44:49 -07:00
parent b01d0d1e5f
commit 3da07a7049
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/injected/src/highlight.ts
View File

@ -61,7 +61,7 @@ export class Highlight {
this._glassPaneElement.style.right = '0';
this._glassPaneElement.style.bottom = '0';
this._glassPaneElement.style.left = '0';
this._glassPaneElement.style.zIndex = '2147483646';
this._glassPaneElement.style.zIndex = '2147483647';
this._glassPaneElement.style.pointerEvents = 'none';
this._glassPaneElement.style.display = 'flex';
this._glassPaneElement.style.backgroundColor = 'transparent';
@ -90,7 +90,9 @@ export class Highlight {
install() {
// NOTE: document.documentElement can be null: https://github.com/microsoft/TypeScript/issues/50078
if (this._injectedScript.document.documentElement && !this._injectedScript.document.documentElement.contains(this._glassPaneElement))
if (!this._injectedScript.document.documentElement)
return;
if (!this._injectedScript.document.documentElement.contains(this._glassPaneElement) || this._glassPaneElement.nextElementSibling)
this._injectedScript.document.documentElement.appendChild(this._glassPaneElement);
}

7
packages/injected/src/recorder/recorder.ts
View File

@ -206,7 +206,11 @@ class RecordActionTool implements RecorderTool {
return 'pointer';
}
install() {
private _installObserverIfNeeded() {
if (this._observer)
return;
if (!this._recorder.injectedScript.document?.body)
return;
this._observer = new MutationObserver(mutations => {
if (!this._hoveredElement)
return;
@ -601,6 +605,7 @@ class RecordActionTool implements RecorderTool {
}
private _updateModelForHoveredElement() {
this._installObserverIfNeeded();
if (this._performingActions.size)
return;
if (!this._hoveredElement || !this._hoveredElement.isConnected) {