root
/
prometheus
mirror of https://github.com/prometheus/prometheus.git
1
0
Fork 0
Code Issues Actions 10 Packages Projects Releases Wiki Activity

fix(rules.Manager): ensure non-nil context (#17103) 

Saw some panic on main due to lack of defaulting:
https://github.com/prometheus/prometheus/actions/runs/17317373582/job/49162760911

Signed-off-by: bwplotka <bwplotka@gmail.com>
This commit is contained in:
Bartlomiej Plotka 2025-08-29 11:43:59 +02:00 committed by GitHub
parent 172cde8af1
commit 18626a99c4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rules/manager.go
View File

@ -145,6 +145,10 @@ func NewManager(o *ManagerOptions) *Manager {
default: default:
panic(fmt.Errorf("unrecognized name validation scheme: %s", o.NameValidationScheme)) panic(fmt.Errorf("unrecognized name validation scheme: %s", o.NameValidationScheme))
} }
if o.Context == nil {
o.Context = context.Background()
}
if o.Metrics == nil { if o.Metrics == nil {
o.Metrics = NewGroupMetrics(o.Registerer) o.Metrics = NewGroupMetrics(o.Registerer)
} }