root
/
prometheus
mirror of https://github.com/prometheus/prometheus.git
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Use strings.Builder for neater error formatting 

Signed-off-by: misha <DL-OTTCloudPlatform-Nova@bskyb.internal>
This commit is contained in:
misha 2021-02-05 11:19:09 +00:00
parent c2c5aeb16b
commit 1c3e7b4241
2 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
cmd/promtool/unittest.go
View File

@ -300,26 +300,29 @@ func (tg *testGroup) test(evalInterval time.Duration, groupOrderMap map[string]i
}) })
} }
var sb strings.Builder
if gotAlerts.Len() != expAlerts.Len() { if gotAlerts.Len() != expAlerts.Len() {
if tg.TestGroupName == "" { if tg.TestGroupName != "" {
errs = append(errs, errors.Errorf(" alertname:%s, time:%s, \n exp:%#v, \n got:%#v", fmt.Fprintf(&sb, " name: %s,\n", tg.TestGroupName)
testcase.Alertname, testcase.EvalTime.String(), expAlerts.String(), gotAlerts.String()))
} else {
errs = append(errs, errors.Errorf(" name: %s,\n alertname:%s, time:%s, \n exp:%#v, \n got:%#v",
tg.TestGroupName, testcase.Alertname, testcase.EvalTime.String(), expAlerts.String(), gotAlerts.String()))
} }
fmt.Fprintf(&sb, " alertname:%s, time:%s, \n", testcase.Alertname, testcase.EvalTime.String())
fmt.Fprintf(&sb, " exp:%#v, \n", expAlerts.String())
fmt.Fprintf(&sb, " got:%#v", gotAlerts.String())
errs = append(errs, errors.New(sb.String()))
} else { } else {
sort.Sort(gotAlerts) sort.Sort(gotAlerts)
sort.Sort(expAlerts) sort.Sort(expAlerts)
if !reflect.DeepEqual(expAlerts, gotAlerts) { if !reflect.DeepEqual(expAlerts, gotAlerts) {
if tg.TestGroupName == "" { if tg.TestGroupName != "" {
errs = append(errs, errors.Errorf(" alertname:%s, time:%s, \n exp:%#v, \n got:%#v", fmt.Fprintf(&sb, " name: %s,\n", tg.TestGroupName)
testcase.Alertname, testcase.EvalTime.String(), expAlerts.String(), gotAlerts.String()))
} else {
errs = append(errs, errors.Errorf(" name: %s,\n alertname:%s, time:%s, \n exp:%#v, \n got:%#v",
tg.TestGroupName, testcase.Alertname, testcase.EvalTime.String(), expAlerts.String(), gotAlerts.String()))
} }
fmt.Fprintf(&sb, " alertname:%s, time:%s, \n", testcase.Alertname, testcase.EvalTime.String())
fmt.Fprintf(&sb, " exp:%#v, \n", expAlerts.String())
fmt.Fprintf(&sb, " got:%#v", gotAlerts.String())
errs = append(errs, errors.New(sb.String()))
} }
} }
} }

3
docs/configuration/unit_testing_rules.md
View File

@ -44,6 +44,9 @@ interval: <duration>
input_series: input_series:
[ - <series> ] [ - <series> ]
# Name of the test group
[ name: <string> ]
# Unit tests for the above data. # Unit tests for the above data.
# Unit tests for alerting rules. We consider the alerting rules from the input file. # Unit tests for alerting rules. We consider the alerting rules from the input file.