Closes #14327
This commit is contained in:
parent
73af4aa014
commit
018c4b189b
|
@ -21,12 +21,10 @@ _Put an `x` in the boxes that apply_
|
||||||
|
|
||||||
_Put an `x` in the boxes that apply.
|
_Put an `x` in the boxes that apply.
|
||||||
You can also fill these out after creating the PR.
|
You can also fill these out after creating the PR.
|
||||||
If you're unsure about any of them, don't hesitate to ask on the mailing list.
|
|
||||||
We're here to help!
|
|
||||||
This is simply a reminder of what we are going to look for before merging your code._
|
This is simply a reminder of what we are going to look for before merging your code._
|
||||||
|
|
||||||
|
- [ ] **Mandatory**: I (or my employer/client) have have signed the CA (see https://github.com/rabbitmq/cla)
|
||||||
- [ ] I have read the `CONTRIBUTING.md` document
|
- [ ] I have read the `CONTRIBUTING.md` document
|
||||||
- [ ] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
|
|
||||||
- [ ] I have added tests that prove my fix is effective or that my feature works
|
- [ ] I have added tests that prove my fix is effective or that my feature works
|
||||||
- [ ] All tests pass locally with my changes
|
- [ ] All tests pass locally with my changes
|
||||||
- [ ] If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
|
- [ ] If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
|
||||||
|
|
|
@ -7,13 +7,13 @@ Pull requests is the primary place of discussing code changes.
|
||||||
|
|
||||||
The process is fairly standard:
|
The process is fairly standard:
|
||||||
|
|
||||||
|
* Make sure you (or your employer/client) [signs the Contributor License Agreement](https://github.com/rabbitmq/cla) if needed (see below)
|
||||||
* Present your idea to the RabbitMQ core team using [GitHub Discussions](https://github.com/rabbitmq/rabbitmq-server/discussions) or [RabbitMQ community Discord server](https://rabbitmq.com/discord)
|
* Present your idea to the RabbitMQ core team using [GitHub Discussions](https://github.com/rabbitmq/rabbitmq-server/discussions) or [RabbitMQ community Discord server](https://rabbitmq.com/discord)
|
||||||
* Fork the repository or repositories you plan on contributing to
|
* Fork the repository or repositories you plan on contributing to
|
||||||
* Run `git clean -xfffd && gmake clean && gmake distclean && gmake` to build all subprojects from scratch
|
* Run `git clean -xfffd && gmake clean && gmake distclean && gmake` to build all subprojects from scratch
|
||||||
* Create a branch with a descriptive name
|
* Create a branch with a descriptive name
|
||||||
* Make your changes, run tests, ensure correct code formatting, commit with a [descriptive message](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html), push to your fork
|
* Make your changes, run tests, ensure correct code formatting, commit with a [descriptive message](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html), push to your fork
|
||||||
* Submit pull requests with an explanation what has been changed and **why**
|
* Submit pull requests with an explanation what has been changed and **why**
|
||||||
* Submit a filled out and signed [Contributor Agreement](https://github.com/rabbitmq/cla) if needed (see below)
|
|
||||||
* Be patient. We will get to your pull request eventually
|
* Be patient. We will get to your pull request eventually
|
||||||
|
|
||||||
|
|
||||||
|
@ -213,9 +213,11 @@ See [CODE_OF_CONDUCT.md](./CODE_OF_CONDUCT.md).
|
||||||
|
|
||||||
## Contributor Agreement
|
## Contributor Agreement
|
||||||
|
|
||||||
If you want to contribute a non-trivial change, please submit a signed copy of our
|
Before submitting your first pull request, please submit a signed copy of our
|
||||||
[Contributor Agreement](https://github.com/rabbitmq/cla) before submitting
|
[Contributor Agreement](https://github.com/rabbitmq/cla) over email to `teamrabbitmq </> gmail dot c0m` with the subject of "RabbitMQ CLA".
|
||||||
a pull request to `teamrabbitmq </> gmail dot c0m` and set the subject to "RabbitMQ CLA".
|
|
||||||
|
Team RabbitMQ will not be able to accept contributions from individuals and legal entities (companies, non-profits)
|
||||||
|
that haven't signed the CLA.
|
||||||
|
|
||||||
## Where to Ask Questions
|
## Where to Ask Questions
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue