From 226e00fcd29a29a2cdc78a08bceea91647ed7e94 Mon Sep 17 00:00:00 2001 From: Philip Kuryloski Date: Thu, 24 Feb 2022 11:18:41 +0100 Subject: [PATCH] Tighten up dialyzer usage now that rules_erlang no longer cascades up dialyzer warnings from deps --- deps/amqp10_client/BUILD.bazel | 2 +- .../src/amqp10_client_frame_reader.erl | 2 +- deps/amqp_client/BUILD.bazel | 1 + deps/rabbit/BUILD.bazel | 1 + deps/rabbit/apps/rabbitmq_prelaunch/BUILD.bazel | 9 +++++++-- deps/rabbitmq_amqp1_0/BUILD.bazel | 13 ++++++++++--- deps/rabbitmq_auth_backend_cache/BUILD.bazel | 9 +++++++-- deps/rabbitmq_auth_backend_http/BUILD.bazel | 1 + deps/rabbitmq_auth_backend_ldap/BUILD.bazel | 1 + deps/rabbitmq_auth_backend_oauth2/BUILD.bazel | 15 ++++++++++++--- deps/rabbitmq_auth_mechanism_ssl/BUILD.bazel | 10 +++++++--- .../rabbitmq_consistent_hash_exchange/BUILD.bazel | 11 ++++++++--- deps/rabbitmq_event_exchange/BUILD.bazel | 9 +++++++-- deps/rabbitmq_federation/BUILD.bazel | 11 ++++++++--- deps/rabbitmq_federation_management/BUILD.bazel | 10 +++++++--- deps/rabbitmq_jms_topic_exchange/BUILD.bazel | 9 +++++++-- deps/rabbitmq_management/BUILD.bazel | 9 +++++++-- deps/rabbitmq_management_agent/BUILD.bazel | 3 ++- deps/rabbitmq_mqtt/BUILD.bazel | 11 ++++++++--- deps/rabbitmq_peer_discovery_aws/BUILD.bazel | 1 + deps/rabbitmq_peer_discovery_common/BUILD.bazel | 1 + deps/rabbitmq_peer_discovery_consul/BUILD.bazel | 9 +++++++-- deps/rabbitmq_peer_discovery_etcd/BUILD.bazel | 9 +++++++-- deps/rabbitmq_peer_discovery_k8s/BUILD.bazel | 9 +++++++-- deps/rabbitmq_prometheus/BUILD.bazel | 9 +++++++-- deps/rabbitmq_random_exchange/BUILD.bazel | 10 +++++++--- deps/rabbitmq_recent_history_exchange/BUILD.bazel | 9 +++++++-- deps/rabbitmq_sharding/BUILD.bazel | 9 +++++++-- deps/rabbitmq_shovel/BUILD.bazel | 11 ++++++++--- deps/rabbitmq_shovel_management/BUILD.bazel | 10 +++++++--- deps/rabbitmq_stomp/BUILD.bazel | 11 ++++++++--- deps/rabbitmq_stream/BUILD.bazel | 15 ++++++++++++--- deps/rabbitmq_stream_management/BUILD.bazel | 9 +++++++-- deps/rabbitmq_top/BUILD.bazel | 10 +++++++--- deps/rabbitmq_tracing/BUILD.bazel | 9 +++++++-- deps/rabbitmq_trust_store/BUILD.bazel | 1 + deps/rabbitmq_web_dispatch/BUILD.bazel | 1 + deps/rabbitmq_web_mqtt/BUILD.bazel | 9 +++++++-- deps/rabbitmq_web_mqtt_examples/BUILD.bazel | 1 - deps/rabbitmq_web_stomp/BUILD.bazel | 9 +++++++-- deps/rabbitmq_web_stomp_examples/BUILD.bazel | 1 - 41 files changed, 226 insertions(+), 74 deletions(-) diff --git a/deps/amqp10_client/BUILD.bazel b/deps/amqp10_client/BUILD.bazel index 9adf552906..e94c768038 100644 --- a/deps/amqp10_client/BUILD.bazel +++ b/deps/amqp10_client/BUILD.bazel @@ -45,12 +45,12 @@ plt( name = "base_plt", apps = EXTRA_APPS, plt = "//:base_plt", + deps = BUILD_DEPS + DEPS, ) dialyze( plt = ":base_plt", tags = ["dialyze"], - warnings_as_errors = False, ) rabbitmq_home( diff --git a/deps/amqp10_client/src/amqp10_client_frame_reader.erl b/deps/amqp10_client/src/amqp10_client_frame_reader.erl index 5a0b83d0cf..12a829c081 100644 --- a/deps/amqp10_client/src/amqp10_client_frame_reader.erl +++ b/deps/amqp10_client/src/amqp10_client_frame_reader.erl @@ -138,7 +138,7 @@ handle_event(cast, {unregister_session, _Session, OutgoingChannel, IncomingChann incoming_channels = IncomingChannels1}, {keep_state, State1}; handle_event(cast, close, _StateName, State = #state{socket = Socket}) -> - close_socket(Socket), + _ = close_socket(Socket), {stop, normal, State#state{socket = undefined}}; handle_event({call, From}, _Action, _State, _Data) -> diff --git a/deps/amqp_client/BUILD.bazel b/deps/amqp_client/BUILD.bazel index 0139d98772..067ca222ef 100644 --- a/deps/amqp_client/BUILD.bazel +++ b/deps/amqp_client/BUILD.bazel @@ -51,6 +51,7 @@ plt( name = "base_plt", apps = EXTRA_APPS, plt = "//:base_plt", + deps = DEPS, ) dialyze( diff --git a/deps/rabbit/BUILD.bazel b/deps/rabbit/BUILD.bazel index 74aa37936a..f22a8056e8 100644 --- a/deps/rabbit/BUILD.bazel +++ b/deps/rabbit/BUILD.bazel @@ -224,6 +224,7 @@ plt( name = "base_plt", apps = plt_apps, plt = "//:base_plt", + deps = DEPS, ) dialyze( diff --git a/deps/rabbit/apps/rabbitmq_prelaunch/BUILD.bazel b/deps/rabbit/apps/rabbitmq_prelaunch/BUILD.bazel index fbd8766212..c8a618cdd2 100644 --- a/deps/rabbit/apps/rabbitmq_prelaunch/BUILD.bazel +++ b/deps/rabbit/apps/rabbitmq_prelaunch/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load("//:rabbitmq.bzl", "APP_VERSION", "rabbitmq_app", "rabbitmq_suite") APP_NAME = "rabbitmq_prelaunch" @@ -35,8 +35,13 @@ xref( tags = ["xref"], ) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_amqp1_0/BUILD.bazel b/deps/rabbitmq_amqp1_0/BUILD.bazel index 9a2554556b..c3fe95569c 100644 --- a/deps/rabbitmq_amqp1_0/BUILD.bazel +++ b/deps/rabbitmq_amqp1_0/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -48,10 +48,17 @@ xref( tags = ["xref"], ) +plt( + name = "base_plt", + # this ought to include BUILD_DEPS, but not sure how to + # get dialyze of elixir code working yet + deps = DEPS, +) + dialyze( size = "medium", - dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + dialyzer_opts = RABBITMQ_DIALYZER_OPTS + ["-Wno_behaviours"], + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_auth_backend_cache/BUILD.bazel b/deps/rabbitmq_auth_backend_cache/BUILD.bazel index 51494f637b..2d18097d5d 100644 --- a/deps/rabbitmq_auth_backend_cache/BUILD.bazel +++ b/deps/rabbitmq_auth_backend_cache/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -48,9 +48,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_auth_backend_http/BUILD.bazel b/deps/rabbitmq_auth_backend_http/BUILD.bazel index 437e6c9a9c..a7e6a94acb 100644 --- a/deps/rabbitmq_auth_backend_http/BUILD.bazel +++ b/deps/rabbitmq_auth_backend_http/BUILD.bazel @@ -53,6 +53,7 @@ plt( name = "base_plt", apps = EXTRA_APPS, plt = "//:base_plt", + deps = DEPS, ) dialyze( diff --git a/deps/rabbitmq_auth_backend_ldap/BUILD.bazel b/deps/rabbitmq_auth_backend_ldap/BUILD.bazel index c891af4b3d..1183004d93 100644 --- a/deps/rabbitmq_auth_backend_ldap/BUILD.bazel +++ b/deps/rabbitmq_auth_backend_ldap/BUILD.bazel @@ -68,6 +68,7 @@ plt( name = "base_plt", apps = EXTRA_APPS, plt = "//:base_plt", + deps = DEPS, ) dialyze( diff --git a/deps/rabbitmq_auth_backend_oauth2/BUILD.bazel b/deps/rabbitmq_auth_backend_oauth2/BUILD.bazel index cfa797c555..1a96bfee33 100644 --- a/deps/rabbitmq_auth_backend_oauth2/BUILD.bazel +++ b/deps/rabbitmq_auth_backend_oauth2/BUILD.bazel @@ -1,6 +1,6 @@ load("@rules_erlang//:erlc.bzl", "erlc") load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -10,6 +10,7 @@ load( "rabbitmq_app", "rabbitmq_integration_suite", "rabbitmq_suite", + "without", ) APP_NAME = "rabbitmq_auth_backend_oauth2" @@ -41,9 +42,17 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = without( + "//deps/rabbitmq_cli:rabbitmqctl", + BUILD_DEPS + DEPS, + ), +) + dialyze( - dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + dialyzer_opts = RABBITMQ_DIALYZER_OPTS + ["-Wno_behaviours"], + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_auth_mechanism_ssl/BUILD.bazel b/deps/rabbitmq_auth_mechanism_ssl/BUILD.bazel index efb00b4780..dcbd65416c 100644 --- a/deps/rabbitmq_auth_mechanism_ssl/BUILD.bazel +++ b/deps/rabbitmq_auth_mechanism_ssl/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -35,9 +35,13 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], - warnings_as_errors = False, ) diff --git a/deps/rabbitmq_consistent_hash_exchange/BUILD.bazel b/deps/rabbitmq_consistent_hash_exchange/BUILD.bazel index e8ebfd7e09..9e6c494054 100644 --- a/deps/rabbitmq_consistent_hash_exchange/BUILD.bazel +++ b/deps/rabbitmq_consistent_hash_exchange/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -35,9 +35,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( - dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + dialyzer_opts = RABBITMQ_DIALYZER_OPTS + ["-Wno_behaviours"], + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_event_exchange/BUILD.bazel b/deps/rabbitmq_event_exchange/BUILD.bazel index 93ce41a9cb..913ce61710 100644 --- a/deps/rabbitmq_event_exchange/BUILD.bazel +++ b/deps/rabbitmq_event_exchange/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -27,9 +27,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_federation/BUILD.bazel b/deps/rabbitmq_federation/BUILD.bazel index bd3a5be0af..b81b07d34c 100644 --- a/deps/rabbitmq_federation/BUILD.bazel +++ b/deps/rabbitmq_federation/BUILD.bazel @@ -1,6 +1,6 @@ load("@rules_erlang//:erlc.bzl", "erlc") load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -44,9 +44,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( - dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + dialyzer_opts = RABBITMQ_DIALYZER_OPTS + ["-Wno_behaviours"], + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_federation_management/BUILD.bazel b/deps/rabbitmq_federation_management/BUILD.bazel index 46a28481f8..0048761a0a 100644 --- a/deps/rabbitmq_federation_management/BUILD.bazel +++ b/deps/rabbitmq_federation_management/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -41,11 +41,15 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = BUILD_DEPS + DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], - warnings_as_errors = False, ) broker_for_integration_suites() diff --git a/deps/rabbitmq_jms_topic_exchange/BUILD.bazel b/deps/rabbitmq_jms_topic_exchange/BUILD.bazel index d12d121d03..f0b848e8dc 100644 --- a/deps/rabbitmq_jms_topic_exchange/BUILD.bazel +++ b/deps/rabbitmq_jms_topic_exchange/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -34,9 +34,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_management/BUILD.bazel b/deps/rabbitmq_management/BUILD.bazel index 5a7c40fcb9..9cca5b5544 100644 --- a/deps/rabbitmq_management/BUILD.bazel +++ b/deps/rabbitmq_management/BUILD.bazel @@ -1,6 +1,6 @@ load("@rules_erlang//:erlc.bzl", "erlc") load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "APP_VERSION", @@ -79,9 +79,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_management_agent/BUILD.bazel b/deps/rabbitmq_management_agent/BUILD.bazel index 3e6f24230d..b8cdc03c4d 100644 --- a/deps/rabbitmq_management_agent/BUILD.bazel +++ b/deps/rabbitmq_management_agent/BUILD.bazel @@ -63,10 +63,11 @@ plt( name = "base_plt", apps = plt_apps, plt = "//:base_plt", + deps = DEPS, ) dialyze( - dialyzer_opts = RABBITMQ_DIALYZER_OPTS, + dialyzer_opts = RABBITMQ_DIALYZER_OPTS + ["-Wno_behaviours"], plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, diff --git a/deps/rabbitmq_mqtt/BUILD.bazel b/deps/rabbitmq_mqtt/BUILD.bazel index 81876cba47..bc0b03bf2a 100644 --- a/deps/rabbitmq_mqtt/BUILD.bazel +++ b/deps/rabbitmq_mqtt/BUILD.bazel @@ -1,6 +1,6 @@ load("@rules_erlang//:erlc.bzl", "erlc") load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -73,9 +73,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( - dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + dialyzer_opts = RABBITMQ_DIALYZER_OPTS + ["-Wno_behaviours"], + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_peer_discovery_aws/BUILD.bazel b/deps/rabbitmq_peer_discovery_aws/BUILD.bazel index fedd481b4b..bfc2ea4560 100644 --- a/deps/rabbitmq_peer_discovery_aws/BUILD.bazel +++ b/deps/rabbitmq_peer_discovery_aws/BUILD.bazel @@ -42,6 +42,7 @@ plt( name = "base_plt", apps = EXTRA_APPS, plt = "//:base_plt", + deps = DEPS, ) dialyze( diff --git a/deps/rabbitmq_peer_discovery_common/BUILD.bazel b/deps/rabbitmq_peer_discovery_common/BUILD.bazel index bb44ef8168..bbafec6b54 100644 --- a/deps/rabbitmq_peer_discovery_common/BUILD.bazel +++ b/deps/rabbitmq_peer_discovery_common/BUILD.bazel @@ -44,6 +44,7 @@ plt( name = "base_plt", apps = EXTRA_APPS, plt = "//:base_plt", + deps = DEPS, ) dialyze( diff --git a/deps/rabbitmq_peer_discovery_consul/BUILD.bazel b/deps/rabbitmq_peer_discovery_consul/BUILD.bazel index 518916a905..ca8059ed1e 100644 --- a/deps/rabbitmq_peer_discovery_consul/BUILD.bazel +++ b/deps/rabbitmq_peer_discovery_consul/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -35,9 +35,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_peer_discovery_etcd/BUILD.bazel b/deps/rabbitmq_peer_discovery_etcd/BUILD.bazel index 16e0437cd3..86291b7f92 100644 --- a/deps/rabbitmq_peer_discovery_etcd/BUILD.bazel +++ b/deps/rabbitmq_peer_discovery_etcd/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -37,9 +37,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_peer_discovery_k8s/BUILD.bazel b/deps/rabbitmq_peer_discovery_k8s/BUILD.bazel index 1226cad257..931f98c2d8 100644 --- a/deps/rabbitmq_peer_discovery_k8s/BUILD.bazel +++ b/deps/rabbitmq_peer_discovery_k8s/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -35,9 +35,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_prometheus/BUILD.bazel b/deps/rabbitmq_prometheus/BUILD.bazel index 84efca9b3e..3d594d47cb 100644 --- a/deps/rabbitmq_prometheus/BUILD.bazel +++ b/deps/rabbitmq_prometheus/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -43,9 +43,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = BUILD_DEPS + DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_random_exchange/BUILD.bazel b/deps/rabbitmq_random_exchange/BUILD.bazel index 80a4e02439..325a243391 100644 --- a/deps/rabbitmq_random_exchange/BUILD.bazel +++ b/deps/rabbitmq_random_exchange/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -27,9 +27,13 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], - warnings_as_errors = False, ) diff --git a/deps/rabbitmq_recent_history_exchange/BUILD.bazel b/deps/rabbitmq_recent_history_exchange/BUILD.bazel index 6cddd1044a..e142be93e6 100644 --- a/deps/rabbitmq_recent_history_exchange/BUILD.bazel +++ b/deps/rabbitmq_recent_history_exchange/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -30,9 +30,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_sharding/BUILD.bazel b/deps/rabbitmq_sharding/BUILD.bazel index 5747cb3c52..e54963b739 100644 --- a/deps/rabbitmq_sharding/BUILD.bazel +++ b/deps/rabbitmq_sharding/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -26,9 +26,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_shovel/BUILD.bazel b/deps/rabbitmq_shovel/BUILD.bazel index 89ebbe16be..9784e5ff2f 100644 --- a/deps/rabbitmq_shovel/BUILD.bazel +++ b/deps/rabbitmq_shovel/BUILD.bazel @@ -1,6 +1,6 @@ load("@rules_erlang//:erlc.bzl", "erlc") load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load("//:rabbitmq_home.bzl", "rabbitmq_home") load("//:rabbitmq_run.bzl", "rabbitmq_run") load( @@ -63,9 +63,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( - dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + dialyzer_opts = RABBITMQ_DIALYZER_OPTS + ["-Wno_behaviours"], + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_shovel_management/BUILD.bazel b/deps/rabbitmq_shovel_management/BUILD.bazel index 54a183f116..7dbc6abb2d 100644 --- a/deps/rabbitmq_shovel_management/BUILD.bazel +++ b/deps/rabbitmq_shovel_management/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load("//:rabbitmq_home.bzl", "rabbitmq_home") load("//:rabbitmq_run.bzl", "rabbitmq_run") load( @@ -39,11 +39,15 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = BUILD_DEPS + DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], - warnings_as_errors = False, ) rabbitmq_home( diff --git a/deps/rabbitmq_stomp/BUILD.bazel b/deps/rabbitmq_stomp/BUILD.bazel index aad48032b7..f1dfce4c80 100644 --- a/deps/rabbitmq_stomp/BUILD.bazel +++ b/deps/rabbitmq_stomp/BUILD.bazel @@ -1,6 +1,6 @@ load("@rules_erlang//:erlc.bzl", "erlc") load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -66,9 +66,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = DEPS, +) + dialyze( - dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + dialyzer_opts = RABBITMQ_DIALYZER_OPTS + ["-Wno_behaviours"], + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_stream/BUILD.bazel b/deps/rabbitmq_stream/BUILD.bazel index 4ff520855b..772a204c3f 100644 --- a/deps/rabbitmq_stream/BUILD.bazel +++ b/deps/rabbitmq_stream/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -7,6 +7,7 @@ load( "broker_for_integration_suites", "rabbitmq_app", "rabbitmq_integration_suite", + "without", ) APP_NAME = "rabbitmq_stream" @@ -53,9 +54,17 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = without( + "//deps/rabbitmq_cli:rabbitmqctl", + BUILD_DEPS + DEPS, + ), +) + dialyze( - dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + dialyzer_opts = RABBITMQ_DIALYZER_OPTS + ["-Wno_behaviours"], + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_stream_management/BUILD.bazel b/deps/rabbitmq_stream_management/BUILD.bazel index f5ae27b097..6cb025c1ec 100644 --- a/deps/rabbitmq_stream_management/BUILD.bazel +++ b/deps/rabbitmq_stream_management/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load("//:rabbitmq_home.bzl", "rabbitmq_home") load("//:rabbitmq_run.bzl", "rabbitmq_run") load( @@ -38,9 +38,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = BUILD_DEPS + DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_top/BUILD.bazel b/deps/rabbitmq_top/BUILD.bazel index 1c3fe4c1f7..0935e8b0b6 100644 --- a/deps/rabbitmq_top/BUILD.bazel +++ b/deps/rabbitmq_top/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -37,9 +37,13 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = BUILD_DEPS + DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], - warnings_as_errors = False, ) diff --git a/deps/rabbitmq_tracing/BUILD.bazel b/deps/rabbitmq_tracing/BUILD.bazel index 09ce690707..e2c6112562 100644 --- a/deps/rabbitmq_tracing/BUILD.bazel +++ b/deps/rabbitmq_tracing/BUILD.bazel @@ -1,5 +1,5 @@ load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -47,9 +47,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = BUILD_DEPS + DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_trust_store/BUILD.bazel b/deps/rabbitmq_trust_store/BUILD.bazel index 8bf2380fe8..5f1c7d1abd 100644 --- a/deps/rabbitmq_trust_store/BUILD.bazel +++ b/deps/rabbitmq_trust_store/BUILD.bazel @@ -54,6 +54,7 @@ plt( name = "base_plt", apps = EXTRA_APPS, plt = "//:base_plt", + deps = DEPS, ) dialyze( diff --git a/deps/rabbitmq_web_dispatch/BUILD.bazel b/deps/rabbitmq_web_dispatch/BUILD.bazel index bb4e73995b..98e7f09c20 100644 --- a/deps/rabbitmq_web_dispatch/BUILD.bazel +++ b/deps/rabbitmq_web_dispatch/BUILD.bazel @@ -43,6 +43,7 @@ plt( name = "base_plt", apps = EXTRA_APPS, plt = "//:base_plt", + deps = DEPS, ) dialyze( diff --git a/deps/rabbitmq_web_mqtt/BUILD.bazel b/deps/rabbitmq_web_mqtt/BUILD.bazel index aab5d3c8bb..c0456f6cf4 100644 --- a/deps/rabbitmq_web_mqtt/BUILD.bazel +++ b/deps/rabbitmq_web_mqtt/BUILD.bazel @@ -1,6 +1,6 @@ load("@rules_erlang//:erlc.bzl", "erlc") load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -53,9 +53,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = BUILD_DEPS + DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_web_mqtt_examples/BUILD.bazel b/deps/rabbitmq_web_mqtt_examples/BUILD.bazel index 41ff6e5ed9..8c2c7c348a 100644 --- a/deps/rabbitmq_web_mqtt_examples/BUILD.bazel +++ b/deps/rabbitmq_web_mqtt_examples/BUILD.bazel @@ -37,5 +37,4 @@ dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, plt = "//:base_plt", tags = ["dialyze"], - warnings_as_errors = False, ) diff --git a/deps/rabbitmq_web_stomp/BUILD.bazel b/deps/rabbitmq_web_stomp/BUILD.bazel index 16c0bba514..2829fcde3d 100644 --- a/deps/rabbitmq_web_stomp/BUILD.bazel +++ b/deps/rabbitmq_web_stomp/BUILD.bazel @@ -1,6 +1,6 @@ load("@rules_erlang//:erlc.bzl", "erlc") load("@rules_erlang//:xref.bzl", "xref") -load("@rules_erlang//:dialyze.bzl", "dialyze") +load("@rules_erlang//:dialyze.bzl", "dialyze", "plt") load( "//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", @@ -56,9 +56,14 @@ rabbitmq_app( xref(tags = ["xref"]) +plt( + name = "base_plt", + deps = BUILD_DEPS + DEPS, +) + dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, - plt = "//:base_plt", + plt = ":base_plt", tags = ["dialyze"], warnings_as_errors = False, ) diff --git a/deps/rabbitmq_web_stomp_examples/BUILD.bazel b/deps/rabbitmq_web_stomp_examples/BUILD.bazel index 6e221acf6e..53dd9ad1e3 100644 --- a/deps/rabbitmq_web_stomp_examples/BUILD.bazel +++ b/deps/rabbitmq_web_stomp_examples/BUILD.bazel @@ -37,5 +37,4 @@ dialyze( dialyzer_opts = RABBITMQ_DIALYZER_OPTS, plt = "//:base_plt", tags = ["dialyze"], - warnings_as_errors = False, )