root
/
rabbitmq-server
mirror of https://github.com/rabbitmq/rabbitmq-server.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Skip SNI option to avoid recursive TLS option formatting 

Since every SNI map value is a set of TLS options, the solution
should be more involved. Our goal is not to present every single
option (we already intentionally hide some of them, e.g. configure
cipher suites), and SNI information does not really fit the UI.
So we can avoid the complexity and still fix the issue by
simply skipping the option.

References rabbitmq/rabbitmq-management#567.
This commit is contained in:
Michael Klishin 2018-04-27 22:47:24 -05:00
parent 69dc16c23f
commit 3be2102f1b
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
deps/rabbitmq_management_agent/src/rabbit_mgmt_format.erl vendored
View File

@ -286,12 +286,11 @@ format_socket_opts([{user_lookup_fun, _Value} | Tail], Acc) ->
format_socket_opts(Tail, Acc);
format_socket_opts([{sni_fun, _Value} | Tail], Acc) ->
format_socket_opts(Tail, Acc);
format_socket_opts([{sni_hosts, Value} | Tail], Acc) ->
ConvertedValue = [
{rabbit_data_coercion:to_binary(Hostname), Opts}
|| {Hostname, Opts} <- Value
],
format_socket_opts(Tail, [{sni_hosts, ConvertedValue} | Acc]);
%% we do not report SNI host details in the UI,
%% so skip this option and avoid some recursive formatting
%% complexity
format_socket_opts([{sni_hosts, _Value} | Tail], Acc) ->
format_socket_opts(Tail, Acc);
format_socket_opts([{reuse_session, _Value} | Tail], Acc) ->
format_socket_opts(Tail, Acc);
%% we do not want to report configured cipher suites, even