root
/
rabbitmq-server
mirror of https://github.com/rabbitmq/rabbitmq-server.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity

No real need to catch ets write exceptions 

They are supposed to be truly exceptional cases in which case
we want a process termination and restart, which will leave
visible traces in the log.

Some experimentation with stats GC process termination
reveals no problems: the processes function as expected
after a streak of restarts.
This commit is contained in:
Michael Klishin 2017-02-20 23:30:05 +03:00
parent 0623be32ba
commit 60f2fba828
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
deps/rabbitmq_management_agent/src/rabbit_mgmt_gc.erl vendored
View File

@ -137,7 +137,6 @@ gc_process(Pid, Table, Key) ->
true ->
none;
false ->
%% TODO catch?
ets:delete(Table, Key),
none
end.
@ -160,7 +159,6 @@ gc_entity(Id, Table, Key, GbSet) ->
true ->
none;
false ->
%% TODO catch?
ets:delete(Table, Key),
none
end.
@ -201,7 +199,6 @@ gc_process_and_entity(Id, Pid, Table, Key, GbSet) ->
true ->
none;
false ->
%% TODO catch?
ets:delete(Table, Key),
none
end.
@ -211,7 +208,6 @@ gc_object(Pid, Table, Object) ->
true ->
none;
false ->
%% TODO catch?
ets:delete_object(Table, Object),
none
end.
@ -221,7 +217,6 @@ gc_object(Id, Table, Object, GbSet) ->
true ->
none;
false ->
%% TODO catch?
ets:delete_object(Table, Object),
none
end.